replace public flag with system flag in conversation handling

elastic · Feb 3, 2025 · aa68ff0 · aa68ff0
1 parent f5ac6ef
commit aa68ff0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/x-pack/platform/packages/shared/kbn-ai-assistant/src/hooks/use_conversation.ts b/x-pack/platform/packages/shared/kbn-ai-assistant/src/hooks/use_conversation.ts
@@ -33,7 +33,6 @@ function createNewConversation({
     },
     labels: {},
     numeric_labels: {},
-    public: false,
   };
 }
 

diff --git a/x-pack/platform/plugins/shared/observability_ai_assistant/common/types.ts b/x-pack/platform/plugins/shared/observability_ai_assistant/common/types.ts
@@ -67,7 +67,7 @@ export interface Conversation {
   labels: Record<string, string>;
   numeric_labels: Record<string, number>;
   namespace: string;
-  public: boolean;
+  system?: boolean;
 }
 
 export type ConversationRequestBase = Omit<Conversation, 'user' | 'conversation' | 'namespace'> & {

diff --git a/x-pack/platform/plugins/shared/observability_ai_assistant/server/service/client/index.ts b/x-pack/platform/plugins/shared/observability_ai_assistant/server/service/client/index.ts
@@ -172,7 +172,7 @@ export class ObservabilityAIAssistantClient {
     signal,
     persist,
     kibanaPublicUrl,
-    isPublic,
+    isSystem = false,
     title: predefinedTitle,
     conversationId: predefinedConversationId,
     disableFunctions = false,
@@ -184,7 +184,7 @@ export class ObservabilityAIAssistantClient {
     persist: boolean;
     conversationId?: string;
     title?: string;
-    isPublic?: boolean;
+    isSystem?: boolean;
     kibanaPublicUrl?: string;
     instructions?: AdHocInstruction[];
     simulateFunctionCalling?: boolean;
@@ -409,7 +409,7 @@ export class ObservabilityAIAssistantClient {
                       id: conversationId,
                       token_count: tokenCountResult,
                     },
-                    public: !!isPublic,
+                    system: !!isSystem,
                     labels: {},
                     numeric_labels: {},
                     messages: initialMessagesWithAddedMessages,

diff --git a/.../observability/plugins/observability_ai_assistant_app/server/rule_connector/index.test.ts b/.../observability/plugins/observability_ai_assistant_app/server/rule_connector/index.test.ts
@@ -137,7 +137,7 @@ describe('observabilityAIAssistant rule_connector', () => {
       expect(completeMock).toHaveBeenCalledWith(
         expect.objectContaining({
           persist: true,
-          isPublic: true,
+          isSystem: true,
           connectorId: 'azure-open-ai',
           kibanaPublicUrl: 'http://kibana.com',
           messages: [

diff --git a/...tions/observability/plugins/observability_ai_assistant_app/server/rule_connector/index.ts b/...tions/observability/plugins/observability_ai_assistant_app/server/rule_connector/index.ts
@@ -245,7 +245,7 @@ If available, include the link of the conversation at the end of your answer.`
     .complete({
       functionClient,
       persist: true,
-      isPublic: true,
+      isSystem: true,
       connectorId: execOptions.params.connector,
       signal: new AbortController().signal,
       kibanaPublicUrl: (await resources.plugins.core.start()).http.basePath.publicBaseUrl,
-Original file line number
+Diff line change
@@ Expand Up / @@ -33,7 +33,6 @@ function createNewConversation({ @@
         },
         labels: {},
         numeric_labels: {},
-        public: false,
       };
     }
@@ Expand Down @@