-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Synthetics] Fix overview error popover !! (#211431)
## Summary Fix overview error popover !! Pings aren't being returned as part of overview data anymore, so had to add redux actions to fetch it separately via an existing API Fixes #211745 <img width="1728" alt="image" src="https://github.com/user-attachments/assets/2244948f-e42d-443d-b6e7-42e0a72b1bfa" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Justin Kambic <jk@elastic.co>
- Loading branch information
3 people
authored
Feb 21, 2025
1 parent
74ef9fc
commit aaf73ff
Showing
17 changed files
with
235 additions
and
100 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 changes: 93 additions & 0 deletions
93
...s/synthetics/components/monitors_page/overview/overview/metric_item/metric_error_icon.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { EuiButtonIcon, useEuiShadow, useEuiTheme } from '@elastic/eui'; | ||
| import * as React from 'react'; | ||
| import { useRef } from 'react'; | ||
| import { useDispatch, useSelector } from 'react-redux'; | ||
| import { i18n } from '@kbn/i18n'; | ||
| import { css } from '@emotion/react'; | ||
| import { useSyntheticsSettingsContext } from '../../../../../contexts'; | ||
| import { selectErrorPopoverState, toggleErrorPopoverOpen } from '../../../../../state'; | ||
|
|
||
| export const MetricErrorIcon = ({ configIdByLocation }: { configIdByLocation: string }) => { | ||
| const isPopoverOpen = useSelector(selectErrorPopoverState); | ||
| const dispatch = useDispatch(); | ||
|
|
||
| const setIsPopoverOpen = () => { | ||
| dispatch(toggleErrorPopoverOpen(configIdByLocation)); | ||
| }; | ||
| const timer = useRef<NodeJS.Timeout | null>(null); | ||
| const euiShadow = useEuiShadow('s'); | ||
|
|
||
| const theme = useEuiTheme().euiTheme; | ||
| const { darkMode } = useSyntheticsSettingsContext(); | ||
|
|
||
| return ( | ||
| <div | ||
| css={css` | ||
| box-sizing: border-box; | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| gap: 10px; | ||
| width: 32px; | ||
| height: 32px; | ||
| background: ${darkMode ? theme.colors.backgroundBaseSubdued : theme.colors.lightestShade}; | ||
| border: 1px solid ${darkMode ? theme.colors.darkShade : theme.colors.lightShade}; | ||
| box-shadow: ${euiShadow}; | ||
| border-radius: 16px; | ||
| flex: none; | ||
| order: 0; | ||
| flex-grow: 0; | ||
| `} | ||
| onMouseEnter={() => { | ||
| // show popover with delay | ||
| if (timer.current) { | ||
| clearTimeout(timer.current); | ||
| } | ||
| timer.current = setTimeout(() => { | ||
| setIsPopoverOpen(); | ||
| }, 300); | ||
| }} | ||
| onMouseLeave={() => { | ||
| if (isPopoverOpen) { | ||
| return; | ||
| } else if (timer.current) { | ||
| clearTimeout(timer.current); | ||
| } | ||
| }} | ||
| onClick={() => { | ||
| if (configIdByLocation === isPopoverOpen) { | ||
| dispatch(toggleErrorPopoverOpen(null)); | ||
| } else { | ||
| dispatch(toggleErrorPopoverOpen(configIdByLocation)); | ||
| } | ||
| }} | ||
| onKeyDown={(e) => { | ||
| if (e.key === 'Enter') { | ||
| if (configIdByLocation === isPopoverOpen) { | ||
| dispatch(toggleErrorPopoverOpen(null)); | ||
| } else { | ||
| dispatch(toggleErrorPopoverOpen(configIdByLocation)); | ||
| } | ||
| } | ||
| }} | ||
| > | ||
| <EuiButtonIcon | ||
| data-test-subj="syntheticsMetricItemIconButton" | ||
| iconType="warning" | ||
| color="danger" | ||
| size="m" | ||
| aria-label={ERROR_DETAILS} | ||
| /> | ||
| </div> | ||
| ); | ||
| }; | ||
| const ERROR_DETAILS = i18n.translate('xpack.synthetics.errorDetails.label', { | ||
| defaultMessage: 'Error details', | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.