Fix lint issues

elastic · Mar 3, 2025 · c2aadc3 · c2aadc3
1 parent 9f7df32
commit c2aadc3
Show file tree

Hide file tree

Showing 11 changed files with 30 additions and 28 deletions.
diff --git a/...est/api_integration/deployment_agnostic/apis/observability/ai_assistant/chat/chat.spec.ts b/...est/api_integration/deployment_agnostic/apis/observability/ai_assistant/chat/chat.spec.ts
@@ -85,7 +85,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
           },
         },
       });
-      await proxy.waitForAllInterceptorsSettled();
+      await proxy.waitForAllInterceptorsToHaveBeenCalled();
       expect(status).to.be(200);
     });
 
@@ -104,7 +104,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
           },
         },
       });
-      await proxy.waitForAllInterceptorsSettled();
+      await proxy.waitForAllInterceptorsToHaveBeenCalled();
       const simulator = await simulatorPromise;
       const requestData = simulator.requestBody; // This is the request sent to the LLM
       expect(requestData.messages[0].content).to.eql(SYSTEM_MESSAGE);

diff --git a/...integration/deployment_agnostic/apis/observability/ai_assistant/complete/complete.spec.ts b/...integration/deployment_agnostic/apis/observability/ai_assistant/complete/complete.spec.ts
@@ -76,7 +76,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
           scopes: ['all'],
         });
 
-      await proxy.waitForAllInterceptorsSettled();
+      await proxy.waitForAllInterceptorsToHaveBeenCalled();
 
       return String(response.body)
         .split('\n')
@@ -133,7 +133,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
 
         await new Promise<void>((resolve) => passThrough.on('end', () => resolve()));
 
-        await proxy.waitForAllInterceptorsSettled();
+        await proxy.waitForAllInterceptorsToHaveBeenCalled();
 
         parsedEvents = decodeEvents(receivedChunks.join(''));
       });
@@ -243,7 +243,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
             },
           },
         });
-        await proxy.waitForAllInterceptorsSettled();
+        await proxy.waitForAllInterceptorsToHaveBeenCalled();
         const simulator = await simulatorPromise;
         const requestData = simulator.requestBody;
         expect(requestData.messages[0].role).to.eql('system');
@@ -420,7 +420,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
 
         expect(createResponse.status).to.be(200);
 
-        await proxy.waitForAllInterceptorsSettled();
+        await proxy.waitForAllInterceptorsToHaveBeenCalled();
 
         conversationCreatedEvent = getConversationCreatedEvent(createResponse.body);
 
@@ -463,7 +463,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
 
         expect(updatedResponse.status).to.be(200);
 
-        await proxy.waitForAllInterceptorsSettled();
+        await proxy.waitForAllInterceptorsToHaveBeenCalled();
       });
 
       after(async () => {

diff --git a/...ion/deployment_agnostic/apis/observability/ai_assistant/complete/functions/alerts.spec.ts b/...ion/deployment_agnostic/apis/observability/ai_assistant/complete/functions/alerts.spec.ts
@@ -46,7 +46,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
         },
       });
 
-      await proxy.waitForAllInterceptorsSettled();
+      await proxy.waitForAllInterceptorsToHaveBeenCalled();
 
       alertsEvents = getMessageAddedEvents(alertsResponseBody);
     });

diff --git a/...loyment_agnostic/apis/observability/ai_assistant/complete/functions/elasticsearch.spec.ts b/...loyment_agnostic/apis/observability/ai_assistant/complete/functions/elasticsearch.spec.ts
@@ -65,7 +65,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
         },
       });
 
-      await proxy.waitForAllInterceptorsSettled();
+      await proxy.waitForAllInterceptorsToHaveBeenCalled();
 
       events = getMessageAddedEvents(responseBody);
     });

diff --git a/...nostic/apis/observability/ai_assistant/complete/functions/get_alerts_dataset_info.spec.ts b/...nostic/apis/observability/ai_assistant/complete/functions/get_alerts_dataset_info.spec.ts
@@ -49,13 +49,13 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
         port: llmProxy.getPort(),
       });
 
-      llmProxy.interceptWithFunctionRequest({
+      void llmProxy.interceptWithFunctionRequest({
         name: 'get_alerts_dataset_info',
         arguments: () => JSON.stringify({ start: 'now-10d', end: 'now' }),
         when: () => true,
       });
 
-      llmProxy.interceptWithFunctionRequest({
+      void llmProxy.interceptWithFunctionRequest({
         name: 'select_relevant_fields',
         // @ts-expect-error
         when: (requestBody) => requestBody.tool_choice?.function?.name === 'select_relevant_fields',
@@ -80,13 +80,15 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
         },
       });
 
-      llmProxy.interceptWithFunctionRequest({
+      void llmProxy.interceptWithFunctionRequest({
         name: 'alerts',
         arguments: () => JSON.stringify({ start: 'now-10d', end: 'now' }),
         when: () => true,
       });
 
-      llmProxy.interceptConversation(`You have active alerts for the past 10 days. Back to work!`);
+      void llmProxy.interceptConversation(
+        `You have active alerts for the past 10 days. Back to work!`
+      );
 
       const { status, body } = await observabilityAIAssistantAPIClient.editor({
         endpoint: 'POST /internal/observability_ai_assistant/chat/complete',
@@ -111,7 +113,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
 
       expect(status).to.be(200);
 
-      await llmProxy.waitForAllInterceptorsSettled();
+      await llmProxy.waitForAllInterceptorsToHaveBeenCalled();
       messageAddedEvents = getMessageAddedEvents(body);
     });
 

diff --git a/.../deployment_agnostic/apis/observability/ai_assistant/complete/functions/summarize.spec.ts b/.../deployment_agnostic/apis/observability/ai_assistant/complete/functions/summarize.spec.ts
@@ -64,7 +64,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
         },
       });
 
-      await proxy.waitForAllInterceptorsSettled();
+      await proxy.waitForAllInterceptorsToHaveBeenCalled();
     });
 
     after(async () => {

diff --git a/...c/apis/observability/ai_assistant/knowledge_base/knowledge_base_user_instructions.spec.ts b/...c/apis/observability/ai_assistant/knowledge_base/knowledge_base_user_instructions.spec.ts
@@ -308,7 +308,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
         });
         expect(createResponse.status).to.be(200);
 
-        await proxy.waitForAllInterceptorsSettled();
+        await proxy.waitForAllInterceptorsToHaveBeenCalled();
         const conversationCreatedEvent = getConversationCreatedEvent(createResponse.body);
         const conversationId = conversationCreatedEvent.conversation.id;
 
@@ -321,7 +321,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
           },
         });
 
-        await proxy.waitForAllInterceptorsSettled();
+        await proxy.waitForAllInterceptorsToHaveBeenCalled();
 
         const conversation = res.body;
         return conversation;
@@ -470,7 +470,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
             },
           },
         });
-        await proxy.waitForAllInterceptorsSettled();
+        await proxy.waitForAllInterceptorsToHaveBeenCalled();
         const simulator = await simulatorPromise;
         const requestData = simulator.requestBody;
         expect(requestData.messages[0].content).to.contain(userInstructionText);

diff --git a/...ployment_agnostic/apis/observability/ai_assistant/public_complete/public_complete.spec.ts b/...ployment_agnostic/apis/observability/ai_assistant/public_complete/public_complete.spec.ts
@@ -72,7 +72,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon
         },
       });
 
-      await proxy.waitForAllInterceptorsSettled();
+      await proxy.waitForAllInterceptorsToHaveBeenCalled();
 
       const titleSimulator = await titleSimulatorPromise;
       const conversationSimulator = await conversationSimulatorPromise;

diff --git a/x-pack/test/observability_ai_assistant_api_integration/common/create_llm_proxy.ts b/x-pack/test/observability_ai_assistant_api_integration/common/create_llm_proxy.ts
@@ -38,7 +38,7 @@ export interface ToolMessage {
 }
 export interface LlmResponseSimulator {
   requestBody: ChatCompletionStreamParams;
-  status: (code: number) => Promise<void>;
+  status: (code: number) => void;
   next: (msg: string | ToolMessage) => Promise<void>;
   error: (error: any) => Promise<void>;
   complete: () => Promise<void>;
@@ -113,7 +113,7 @@ export class LlmProxy {
     this.server.close();
   }
 
-  waitForAllInterceptorsSettled() {
+  waitForAllInterceptorsToHaveBeenCalled() {
     return pRetry(
       async () => {
         if (this.interceptors.length === 0) {
@@ -212,7 +212,7 @@ export class LlmProxy {
 
             const simulator: LlmResponseSimulator = {
               requestBody,
-              status: once(async (status: number) => {
+              status: once((status: number) => {
                 response.writeHead(status, {
                   'Elastic-Interceptor': name,
                   'Content-Type': 'text/event-stream',
@@ -221,12 +221,12 @@ export class LlmProxy {
                 });
               }),
               next: (msg) => {
-                simulator.status(200);
+                void simulator.status(200);
                 const chunk = createOpenAiChunk(msg);
                 return write(sseEvent(chunk));
               },
               rawWrite: (chunk: string) => {
-                simulator.status(200);
+                void simulator.status(200);
                 return write(chunk);
               },
               rawEnd: async () => {

diff --git a/x-pack/test/observability_ai_assistant_functional/tests/contextual_insights/index.spec.ts b/x-pack/test/observability_ai_assistant_functional/tests/contextual_insights/index.spec.ts
@@ -126,7 +126,7 @@ export default function ApiTest({ getService, getPageObjects }: FtrProviderConte
 
         await openContextualInsights();
 
-        await proxy.waitForAllInterceptorsSettled();
+        await proxy.waitForAllInterceptorsToHaveBeenCalled();
 
         await retry.tryForTime(5 * 1000, async () => {
           const llmResponse = await testSubjects.getVisibleText(ui.pages.contextualInsights.text);

diff --git a/x-pack/test/observability_ai_assistant_functional/tests/conversations/index.spec.ts b/x-pack/test/observability_ai_assistant_functional/tests/conversations/index.spec.ts
@@ -247,7 +247,7 @@ export default function ApiTest({ getService, getPageObjects }: FtrProviderConte
                 await testSubjects.setValue(ui.pages.conversations.chatInput, 'hello');
                 await testSubjects.pressEnter(ui.pages.conversations.chatInput);
 
-                await proxy.waitForAllInterceptorsSettled();
+                await proxy.waitForAllInterceptorsToHaveBeenCalled();
                 await header.waitUntilLoadingHasFinished();
               });
 
@@ -305,7 +305,7 @@ export default function ApiTest({ getService, getPageObjects }: FtrProviderConte
                   await testSubjects.setValue(ui.pages.conversations.chatInput, 'hello');
                   await testSubjects.pressEnter(ui.pages.conversations.chatInput);
 
-                  await proxy.waitForAllInterceptorsSettled();
+                  await proxy.waitForAllInterceptorsToHaveBeenCalled();
                   await header.waitUntilLoadingHasFinished();
                 });
 
@@ -396,7 +396,7 @@ export default function ApiTest({ getService, getPageObjects }: FtrProviderConte
                   await testSubjects.pressEnter(ui.pages.conversations.chatInput);
                   log.info('SQREN: Waiting for the message to be displayed');
 
-                  await proxy.waitForAllInterceptorsSettled();
+                  await proxy.waitForAllInterceptorsToHaveBeenCalled();
                   await header.waitUntilLoadingHasFinished();
                 });
-Original file line number
+Diff line change
@@ Expand Up @@
             },
           });
-          await proxy.waitForAllInterceptorsSettled();
+          await proxy.waitForAllInterceptorsToHaveBeenCalled();
           alertsEvents = getMessageAddedEvents(alertsResponseBody);
         });
@@ Expand Down @@