Use partial instead

elastic · Mar 3, 2025 · ca7444c · ca7444c
1 parent 6427fa0
commit ca7444c
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 9 deletions.
diff --git a/examples/controls_example/public/app/control_group_renderer_examples/search_example.tsx b/examples/controls_example/public/app/control_group_renderer_examples/search_example.tsx
@@ -38,10 +38,6 @@ interface Props {
   navigation: NavigationPublicPluginStart;
 }
 
-type ControlGroupAPI = DefaultControlApi & {
-  clearSelections?: () => void;
-};
-
 const DEST_COUNTRY_CONTROL_ID = 'DEST_COUNTRY_CONTROL_ID';
 
 export const SearchExample = ({ data, dataView, navigation }: Props) => {
@@ -184,7 +180,7 @@ export const SearchExample = ({ data, dataView, navigation }: Props) => {
           onClick={() => {
             if (controlGroupAPI) {
               Object.values(controlGroupAPI.children$.getValue()).forEach((controlApi) => {
-                (controlApi as ControlGroupAPI)?.clearSelections?.();
+                (controlApi as DefaultControlApi)?.clearSelections?.();
               });
             }
           }}

diff --git a/src/platform/plugins/shared/controls/public/controls/data_controls/types.ts b/src/platform/plugins/shared/controls/public/controls/data_controls/types.ts
@@ -18,7 +18,6 @@ import {
 
 import { DefaultDataControlState } from '../../../common';
 import { ControlGroupApi } from '../../control_group/types';
-import { CanClearSelections } from '../../types';
 import { ControlFactory, DefaultControlApi } from '../types';
 import { PublishesAsyncFilters } from './publishes_async_filters';
 
@@ -31,7 +30,6 @@ export interface PublishesField {
 
 export type DataControlApi = DefaultControlApi &
   Omit<PublishesTitle, 'hideTitle$'> & // control titles cannot be hidden
-  CanClearSelections &
   HasEditCapabilities &
   PublishesDataViews &
   PublishesField &

diff --git a/src/platform/plugins/shared/controls/public/controls/timeslider_control/types.ts b/src/platform/plugins/shared/controls/public/controls/timeslider_control/types.ts
@@ -9,7 +9,6 @@
 
 import type { PublishesTitle, PublishesTimeslice } from '@kbn/presentation-publishing';
 import type { DefaultControlState } from '../../../common';
-import { CanClearSelections } from '../../types';
 import type { DefaultControlApi } from '../types';
 
 export type Timeslice = [number, number];
@@ -22,6 +21,5 @@ export interface TimesliderControlState extends DefaultControlState {
 }
 
 export type TimesliderControlApi = DefaultControlApi &
-  CanClearSelections &
   Pick<PublishesTitle, 'defaultTitle$'> &
   PublishesTimeslice;
diff --git a/src/platform/plugins/shared/controls/public/controls/types.ts b/src/platform/plugins/shared/controls/public/controls/types.ts
@@ -36,6 +36,7 @@ export type DefaultControlApi = PublishesDataLoading &
   PublishesBlockingError &
   PublishesUnsavedChanges &
   Partial<PublishesTitle & PublishesDisabledActionIds & HasCustomPrepend> &
+  Partial<CanClearSelections> &
   HasType &
   HasUniqueId &
   HasSerializableState<DefaultControlState> &