Skip to content

Commit

Permalink
[Security Solution] Fixed Table height row rendering - Event Rendered…
Browse files Browse the repository at this point in the history
… View (#212130)

## Summary

Today Alert table has a height of 600px if the number of items it
displays exceeds 20. If not, it has a height of `auto` which means it
adjust the table height according to the number of rows displayed.

This height `auto` surfaces an issue with EuiDataGrid where it is not
able to calculate the height of the displayed rows. This results in
arbitrary height everytime the number of rows < 20.

## Solution

We are working with EUI Team to permanently fix the issue. But as a
workaround, we are setting up a fixed height of EuiDataGrid to `600px`
irrespective of the number of rows that are visible on the screen. This
would sometime lead of extra flush space visible as can be seen in below
demo.

But it ensures that user is never in an unusable state. Below is the
summary of changes applied

- Fixed height of `600px` in case of Event Rendered View

Below `Before` and `After` Sections show the demo

### Before

https://github.com/user-attachments/assets/6efd70b1-a33f-4c98-bd8f-82f57e9cd0cd

### After

https://github.com/user-attachments/assets/8da31611-12ff-4609-bafb-4b0f53398407

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
(cherry picked from commit 88ab8b6)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_table/index.tsx
  • Loading branch information
logeekal authored and PhilippeOberti committed Feb 26, 2025
1 parent 8b527f1 commit ecb531b
Showing 1 changed file with 21 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,25 @@ export const AlertsTableComponent: FC<DetectionEngineAlertTableProps> = ({
};
}, [isEventRenderedView]);

/**
* if records are too less, we don't want table to be of fixed height.
* it should shrink to the content height.
* Height setting enables/disables virtualization depending on fixed/undefined height values respectively.
* */
const alertTableHeight = useMemo(
() =>
isEventRenderedView
? `${DEFAULT_DATA_GRID_HEIGHT}px`
: /*
* We keep fixed height in Event rendered because of the row height issue
* as mentioned here
*/
count > 20
? `${DEFAULT_DATA_GRID_HEIGHT}px`
: undefined,
[count, isEventRenderedView]
);

const alertStateProps: AlertsTableStateProps = useMemo(
() => ({
alertsTableConfigurationRegistry: triggersActionsUi.alertsTableConfigurationRegistry,
Expand All @@ -296,10 +315,7 @@ export const AlertsTableComponent: FC<DetectionEngineAlertTableProps> = ({
cellContext,
onLoaded: onLoad,
toolbarVisibility,
// if records are too less, we don't want table to be of fixed height.
// it should shrink to the content height.
// Height setting enables/disables virtualization depending on fixed/undefined height values respectively.
height: count >= 20 ? `${DEFAULT_DATA_GRID_HEIGHT}px` : undefined,
height: alertTableHeight,
initialPageSize: 50,
runtimeMappings: sourcererDataView.runtimeFieldMap as RunTimeMappings,
}),
Expand All @@ -316,8 +332,8 @@ export const AlertsTableComponent: FC<DetectionEngineAlertTableProps> = ({
cellContext,
onLoad,
toolbarVisibility,
count,
sourcererDataView.runtimeFieldMap,
alertTableHeight,
]
);

Expand Down

0 comments on commit ecb531b

Please sign in to comment.