Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] scrolling down to result not available on small screen #100329

Open
jmartin51 opened this issue May 19, 2021 · 16 comments
Open

[Discover] scrolling down to result not available on small screen #100329

jmartin51 opened this issue May 19, 2021 · 16 comments
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@jmartin51
Copy link

Kibana version:
7.12.x

Browser version:
Chrome Version 90.0.4430.212

Describe the bug:
When using small screen and lots of filter it is possible scroll down to result in 7.12.1 .
It was working fine in previous version, I tried in 7.5.2 and scroll down to the result is working fine.
You can have a look to the screenshot for the repro. Indeed you can see that the scrolling bar on right side is at the bottom, and unable to scroll down to see the result (even with the mouse wheel).

Workaround is to hide the chart or reduce the width of the window to switch to mobile friendly mode.

Expected behavior:
Being able to scroll down in the result

Screenshots (if relevant):
Screenshot 2021-05-19 at 11 56 19

@jmartin51 jmartin51 added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application labels May 19, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label May 19, 2021
@jmartin51 jmartin51 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 19, 2021
@kertal
Copy link
Member

kertal commented May 27, 2021

FYI @andreadelrio, although this is not a 100% solution, i think we should scale the histogram when there's little vertical space available? Don't think it's a problem limited to Discover that you can have an infinite number of filters, all being rendered, eating up lot's of vertical space

@kertal
Copy link
Member

kertal commented May 27, 2021

Another related issue that's being fixed here: #97634, scrolling the classic table down didn't trigger displaying more than 50 documents when there was little vertical space available

@mbondyra
Copy link
Contributor

mbondyra commented Jun 3, 2021

Reserving for mob-programming session.

@mbondyra mbondyra self-assigned this Jun 3, 2021
@ryankeairns
Copy link
Contributor

Let's be considerate of the fact that what we do here - if it involves changes to the UX of the search/filter bar - has a wide reach. It's temping to just dive into a solution, but I suggest employ some caution and think through our options. :)

@markov00
Copy link
Member

markov00 commented Jun 4, 2021

Let's be considerate of the fact that what we do here - if it involves changes to the UX of the search/filter bar - has a wide reach. It's temping to just dive into a solution, but I suggest employ some caution and think through our options. :)

Just my 2 cents here: I also struggle with Discover when exploring, because the scroll involves scrolling everything, both the filter/query bar and the field list on the left. This usually slows down the exploration because I need to scroll up every time I need to change the filter or a query or add a new field as a column. Some competitors use to keep fixed the filter/query and field list letting just the table scroll up and down (see Splunk).
I know that this doesn't solve the mentioned issue, but I think it is a good thing to consider when refactoring the scrolling behavior of discover

@mbondyra
Copy link
Contributor

mbondyra commented Jun 4, 2021

Hi @ryankeairns and @markov00 we just had a mob programming session where we went through multiple solutions as a start. We were thinking about:

  1. Scrolling the chart along with the datagrid to increase scrollable space
  2. Making the height of the chart dependant on the space left after calculating how much space the header with filter occupy (we'll call this space 'app space')
  3. Collapse filters bar

We chose to explore the third option during our session. There were couple of approaches we thought about:
a. automatically detect multiline filters and collapse it if they take a lot of lines (we decided not to follow this path)
b. allow user to manually collapse filters bar to one horizontally scrollable line. The result is this PR: #101386
We added an extra option collapse bar to the filters options popover that is saved across the apps in the local storage.

I am now unassigning myself from this issue, hopefully someone from the Discover team will take over.

@mbondyra mbondyra removed their assignment Jun 7, 2021
@kertal kertal self-assigned this Jun 7, 2021
@timroes timroes added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jul 15, 2021
@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@kertal kertal removed their assignment May 30, 2023
@davismcphee davismcphee added the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 8, 2023
@kertal kertal added Feature:Unified search Unified search related tasks Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Feature:Discover Discover Application labels Oct 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kertal
Copy link
Member

kertal commented Oct 22, 2024

relabeling / reassigning this issue, since the problem of having this amount of filters is surfacing in Disocver, and I'm pretty sure it will be resolved in the further iterations of UnifiedSearch

@kertal kertal removed the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Oct 22, 2024
@jb1b84 jb1b84 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Unified search Unified search related tasks labels Jan 21, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Feb 12, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Feb 14, 2025

This issue is going in circles. The only way we could solve this in Discover, would be if we switch the whole application to be scrollable again, this is what we're doing in "mobile" view ... But I guess we won't do this wdyt @l-suarez @andreadelrio ? Else it's up to the owners of untied search / the filterbar to make the filters collapsible

@kertal kertal self-assigned this Feb 14, 2025
@davismcphee
Copy link
Contributor

Agreed, there's little we can do on the Discover side except make all of Discover scrollable again, which comes with its own set of UX issues. The fundamental issue is that filters can consume way too much space, and that would need to be addressed at the Unified Search level. I don't think this should have been reassigned back to Data Discovery.

@kertal
Copy link
Member

kertal commented Feb 18, 2025

@jb1b84 @nreese before this issue runs in team circles, are you fine to assign it back? I think Lens would have the same issue with filters that consume too much space

@andreadelrio
Copy link
Contributor

andreadelrio commented Mar 4, 2025

I think this has to be solved on the Unified Search side. Multiple solutions have been suggested with pros and cons. I suggest we pick an easy one that won't be too costly to implement. One that comes to mind is setting a max height to the area where the filter pills are displayed. When that height is reached we enable vertical scrolling. Eventually we will have Unified Search 2.0 which should incorporate considerations for this scenario out of the box. cc @ThomThomson

@timductive timductive added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Mar 5, 2025
@timductive
Copy link
Member

Swapping this to Presentation team for triage as they own Unified Search now. If the level of effort is relatively low we should do it sooner than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests