Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs onboarding] Elastic agent download url #159382

Closed
yngrdyn opened this issue Jun 9, 2023 · 2 comments · Fixed by #162622
Closed

[Logs onboarding] Elastic agent download url #159382

yngrdyn opened this issue Jun 9, 2023 · 2 comments · Fixed by #162622
Assignees
@yngrdyn
Labels
8.10 candidate apm:test-plan-done Pull request that was successfully tested during the test plan Feature:Logs Onboarding Logs Onboarding feature Feature: Observability Onboarding Team:obs-ux-logs Observability Logs User Experience Team

Comments

@yngrdyn
Copy link
Contributor

yngrdyn commented Jun 9, 2023

At the moment elastic agent url is being hardcoded in the setup script.

We need to find a reliable way to get the elastic agent version (should this version be aligned with the stack version or getting the latest released version is the way to go?) and probably set the elastic agent download url as an input for the script.
@yngrdyn yngrdyn added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. apm:logs-onboarding labels Jun 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@yngrdyn yngrdyn mentioned this issue Jun 9, 2023
Merged
@gbamparop
Copy link
Contributor

We need to find a reliable way to get the elastic agent version (should this version be aligned with the stack version or getting the latest released version is the way to go?)

Fleet UI uses the Kibana version to construct the download url in the list of instructions, I think we should go with this for now.

@yngrdyn yngrdyn self-assigned this Jul 12, 2023
@yngrdyn yngrdyn mentioned this issue Jul 27, 2023
Merged
yngrdyn added a commit that referenced this issue Jul 27, 2023
@yngrdyn
[Logs onboarding] Align elastic-agent version with stackVersion (#162622
11e56ec 
)

Closes #159382.

### Changes
- `kibanaVersion` is passed as a resources to the routes.
- `elastic-agent` version is based on `kibanaVersion`.

#### Before
<img width="1073" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/00e291a2-3f8d-4d1d-9520-c0a29cc9454e">

#### After
<img width="1115" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/dffcf95f-f3a2-46f0-bb78-daebe8597b89">
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@yngrdyn
[Logs onboarding] Align elastic-agent version with stackVersion (elas…
f417511 
…tic#162622)

Closes elastic#159382.

### Changes
- `kibanaVersion` is passed as a resources to the routes.
- `elastic-agent` version is based on `kibanaVersion`.

#### Before
<img width="1073" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/00e291a2-3f8d-4d1d-9520-c0a29cc9454e">

#### After
<img width="1115" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/dffcf95f-f3a2-46f0-bb78-daebe8597b89">
@yngrdyn yngrdyn added the apm:test-plan-done Pull request that was successfully tested during the test plan label Sep 6, 2023
@gbamparop gbamparop added Team:obs-ux-logs Observability Logs User Experience Team Feature:Logs Onboarding Logs Onboarding feature and removed Team:APM - DEPRECATED Use Team:obs-ux-infra_services. apm:logs-onboarding labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yngrdyn yngrdyn

Labels
8.10 candidate apm:test-plan-done Pull request that was successfully tested during the test plan Feature:Logs Onboarding Logs Onboarding feature Feature: Observability Onboarding Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
3 participants
@yngrdyn @gbamparop @elasticmachine