Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs onboarding] Custom logs api tests #159451

Closed
6 tasks done
yngrdyn opened this issue Jun 12, 2023 · 2 comments
Closed
6 tasks done

[Logs onboarding] Custom logs api tests #159451

yngrdyn opened this issue Jun 12, 2023 · 2 comments
Assignees
@yngrdyn
Labels
8.10 candidate apm:test-plan-done Pull request that was successfully tested during the test plan Feature:Logs Onboarding Logs Onboarding feature Feature: Observability Onboarding Team:obs-ux-logs Observability Logs User Experience Team

Comments

@yngrdyn
Copy link
Contributor

yngrdyn commented Jun 12, 2023 •
edited
Loading

Most endpoints in customLogs onboarding should be covered by API tests. This issue captures a list of endpoints without API tests:

Tasks
Preview Give feedback

Consider also adding tests for serverless
@yngrdyn yngrdyn added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. apm:logs-onboarding labels Jun 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@ogupte ogupte mentioned this issue Jun 12, 2023
Merged
@yngrdyn yngrdyn self-assigned this Jun 12, 2023
@yngrdyn yngrdyn mentioned this issue Jun 21, 2023
Merged
3 tasks
yngrdyn added a commit that referenced this issue Jun 26, 2023
@yngrdyn @kibanamachine
[Logs Onboarding] Added api integration tests (#160165)
39ddf4d 
Relates to #159451.


This PR adds api integration tests to:

- [x] GET /internal/observability_onboarding/custom_logs/privileges
- [x] GET
/internal/observability_onboarding/custom_logs/install_shipper_setup
- [x] POST /internal/observability_onboarding/custom_logs/save

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@yngrdyn yngrdyn mentioned this issue Jun 28, 2023
Merged
4 tasks
yngrdyn added a commit that referenced this issue Jun 29, 2023
@yngrdyn
[Logs onboarding] Added api tests for progress endpoints (#160750)
1e918df 
Relates to #159451.

This PR adds

* api integration tests to:

- [x] GET
/internal/observability_onboarding/custom_logs/{onboardingId}/progress
- [x] ~~GET /api/observability_onboarding/custom_logs/{id}/step/{name}
2023-05-24~~ POST
/internal/observability_onboarding/custom_logs/{id}/step/{name}
- [x] GET /api/observability_onboarding/elastic_agent/config

* unit tests to:
- [x] `generate_yml.ts` as part of GET
/api/observability_onboarding/elastic_agent/config
@yngrdyn yngrdyn closed this as completed Jun 30, 2023
@yngrdyn yngrdyn added apm:test-plan-8.10.0 apm:test-plan-done Pull request that was successfully tested during the test plan labels Aug 16, 2023
@yngrdyn
Copy link
Contributor Author

yngrdyn commented Aug 17, 2023

Tests are enabled in the CI.

@yngrdyn yngrdyn reopened this Aug 17, 2023
@yngrdyn yngrdyn closed this as completed Aug 17, 2023
@gbamparop gbamparop added Team:obs-ux-logs Observability Logs User Experience Team Feature:Logs Onboarding Logs Onboarding feature and removed Team:APM - DEPRECATED Use Team:obs-ux-infra_services. apm:logs-onboarding labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yngrdyn yngrdyn

Labels
8.10 candidate apm:test-plan-done Pull request that was successfully tested during the test plan Feature:Logs Onboarding Logs Onboarding feature Feature: Observability Onboarding Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

159451-logs-onboarding-custom-logs-api-tests yngrdyn/kibana
159451-logs-onboarding-custom-logs-api-tests-2nd-part yngrdyn/kibana
3 participants
@yngrdyn @gbamparop @elasticmachine