Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs onboarding] Add service name to logs setup step #159492

Closed
yngrdyn opened this issue Jun 12, 2023 · 4 comments · Fixed by #159592
Closed

[Logs onboarding] Add service name to logs setup step #159492

yngrdyn opened this issue Jun 12, 2023 · 4 comments · Fixed by #159592
Assignees
@yngrdyn
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan Feature:Logs Onboarding Logs Onboarding feature Feature: Observability Onboarding Team:obs-ux-logs Observability Logs User Experience Team

Comments

@yngrdyn
Copy link
Contributor

yngrdyn commented Jun 12, 2023

Add service name as optional input while configuring custom logs.

image

This can be done using add_fields processor.
@yngrdyn yngrdyn added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. apm:logs-onboarding labels Jun 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@yngrdyn yngrdyn self-assigned this Jun 12, 2023
@yngrdyn
Copy link
Contributor Author

yngrdyn commented Jun 12, 2023

@sqren do you think we could a get a default value for it? For example dataset name is being autogenerated from first Log file path.
If not, and since it's optional, we probably will end up not capturing that field

@sorenlouv
Copy link
Member

do you think we could a get a default value for it?

Hmm.. Not sure. If the log lines themselves contains service.name or similar we should obviously use that. But we don't know that ahead of time.

@yngrdyn yngrdyn mentioned this issue Jun 13, 2023
Merged
yngrdyn added a commit that referenced this issue Jun 13, 2023
@yngrdyn
[Logs onboarding] Add service name to logs setup (#159592)
eaf2d33 
Closes #159492.

This PR adds a field to logs setup so users can define optionally the
service name of the service generating logs.

### Changes
- New input for serviceName in setup step.
- ServiceName is added to SO.
- ServiceName is used in `generateYml`.

#### Demo


https://github.com/elastic/kibana/assets/1313018/15fe33ec-1c36-413a-809a-897b2c0a9042
@yngrdyn
Copy link
Contributor Author

yngrdyn commented Aug 17, 2023

This was tested in qa cloud deployment.

707fe7d5-9e66-4e34-8b0f-82e7cdb37ad0.mp4

The service.name is configured in the first step of custom logs:

image

and then user can inspect the log document and find the configured service.name

image

@yngrdyn yngrdyn added the apm:test-plan-done Pull request that was successfully tested during the test plan label Aug 17, 2023
@gbamparop gbamparop added Team:obs-ux-logs Observability Logs User Experience Team Feature:Logs Onboarding Logs Onboarding feature and removed Team:APM - DEPRECATED Use Team:obs-ux-infra_services. apm:logs-onboarding labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yngrdyn yngrdyn

Labels
apm:test-plan-done Pull request that was successfully tested during the test plan Feature:Logs Onboarding Logs Onboarding feature Feature: Observability Onboarding Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
4 participants
@sorenlouv @yngrdyn @gbamparop @elasticmachine