Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs Onboarding] APIs should be made internal only #160148

Closed
Tracked by #160249
ogupte opened this issue Jun 21, 2023 · 1 comment · Fixed by #160749
Closed
Tracked by #160249

[Logs Onboarding] APIs should be made internal only #160148

ogupte opened this issue Jun 21, 2023 · 1 comment · Fixed by #160749
Assignees
@ogupte
Labels
8.9 candidate apm:test-plan-done Pull request that was successfully tested during the test plan Feature:Logs Onboarding Logs Onboarding feature Feature: Observability Onboarding Team:obs-ux-logs Observability Logs User Experience Team

Comments

@ogupte
Copy link
Contributor

ogupte commented Jun 21, 2023

Until API-based onboarding is implemented (#154942) we should assume all APIs in Logs Onboarding to be internal since we don't expect them to be called from outside the Kibana-based flow, this includes calls made by the setup scripts.

The following are still defined as public APIs and should be made internal before release:

  • 'GET /api/observability_onboarding/custom_logs/{id}/step/{name} 2023-05-24'
    • used to report progress
  • 'GET /api/observability_onboarding/elastic_agent/config 2023-05-24'
    • used to fetch elastic-agent yaml
@ogupte ogupte self-assigned this Jun 21, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 21, 2023
@ogupte ogupte added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. and removed needs-team Issues missing a team label labels Jun 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@ogupte ogupte added 8.9 candidate bug Fixes for quality problems that affect the customer experience labels Jun 21, 2023
@gbamparop gbamparop mentioned this issue Jun 22, 2023
Closed
ogupte added a commit to ogupte/kibana that referenced this issue Jun 28, 2023
@ogupte
[Logs onboarding] fixes existing logs onboarding APIs to be internal …
d9f04d8 
…only (elastic#160148)
@ogupte ogupte mentioned this issue Jun 28, 2023
Merged
@yngrdyn yngrdyn added the apm:test-plan-done Pull request that was successfully tested during the test plan label Sep 6, 2023
@gbamparop gbamparop added Team:obs-ux-logs Observability Logs User Experience Team Feature:Logs Onboarding Logs Onboarding feature and removed Team:APM - DEPRECATED Use Team:obs-ux-infra_services. apm:logs-onboarding labels Oct 10, 2023
@gbamparop gbamparop added Feature: Observability Onboarding and removed bug Fixes for quality problems that affect the customer experience labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
8.9 candidate apm:test-plan-done Pull request that was successfully tested during the test plan Feature:Logs Onboarding Logs Onboarding feature Feature: Observability Onboarding Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs onboarding] Make existing APIs internal only ogupte/kibana
4 participants
@yngrdyn @ogupte @gbamparop @elasticmachine