Added versioning to inventory_view_saved_object #207007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryce-b
added
release_note:fix
backport:all-open
bryce-b
added
core-apm
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
bryce-b
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
… src/core/server/integration_tests/ci_checks'
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]
History
|
There was a problem hiding this comment.
Saved object changes LGTM.
Should we add notes to all versions of kibana between v8.10 and oldest version available for backport describing this bug?
Adding it to known issues for those releases would be optimal if it's possible.
The other alternative is to highlight the bug in the current release notes and calling it out in the inventory view API public docs.
TinaHeiligers
approved these changes
Jan 27, 2025
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
3 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
crespocarlos
removed
the
backport:all-open
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
7 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
This was referenced Feb 18, 2025
bryce-b
added a commit
to bryce-b/kibana
that referenced
this pull request
Feb 18, 2025
## Summary Fixes elastic#187254 Strict checks on the attribute `legend.steps` was added to the inventory view API in v8.10 (elastic#160852), but they were not defined in the saved object type for that data, resulting in older versions migrating bad data, and being unable to use the API. This PR adds versioning to the Inventory view saved object type that constrains legend.steps to between 2 and 18, per the strict typing added in elastic#160852 #### Open questions Should we add notes to all versions of kibana between v8.10 and oldest version available for backport describing this bug? ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit a108c63) # Conflicts: # x-pack/solutions/observability/plugins/infra/tsconfig.json
bryce-b
added a commit
to bryce-b/kibana
that referenced
this pull request
Feb 18, 2025
## Summary Fixes elastic#187254 Strict checks on the attribute `legend.steps` was added to the inventory view API in v8.10 (elastic#160852), but they were not defined in the saved object type for that data, resulting in older versions migrating bad data, and being unable to use the API. This PR adds versioning to the Inventory view saved object type that constrains legend.steps to between 2 and 18, per the strict typing added in elastic#160852 #### Open questions Should we add notes to all versions of kibana between v8.10 and oldest version available for backport describing this bug? ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit a108c63) # Conflicts: # x-pack/plugins/observability_solution/infra/server/saved_objects/inventory_view/inventory_view_saved_object.test.ts # x-pack/plugins/observability_solution/infra/tsconfig.json
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
bryce-b
added a commit
that referenced
this pull request
Feb 21, 2025
) # Backport This will backport the following commits from `main` to `8.x`: - [Added versioning to inventory_view_saved_object (#207007)](#207007) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bryce Buchanan","email":"75274611+bryce-b@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-27T18:09:32Z","message":"Added versioning to inventory_view_saved_object (#207007)\n\n## Summary\r\n\r\nFixes #187254 \r\nStrict checks on the attribute `legend.steps` was added to the inventory\r\nview API in v8.10 (#160852), but they were not defined in the\r\nsaved object type for that data, resulting in older versions migrating\r\nbad data, and being unable to use the API. This PR adds versioning to\r\nthe Inventory view saved object type that constrains legend.steps to\r\nbetween 2 and 18, per the strict typing added in #160852\r\n\r\n#### Open questions\r\nShould we add notes to all versions of kibana between v8.10 and oldest\r\nversion available for backport describing this bug?\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a108c632a459240f9c27262395e2584f92d43779","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:fix","backport missing","v9.0.0","Team:obs-ux-infra_services"],"title":"Added versioning to inventory_view_saved_object","number":207007,"url":"https://github.com/elastic/kibana/pull/207007","mergeCommit":{"message":"Added versioning to inventory_view_saved_object (#207007)\n\n## Summary\r\n\r\nFixes #187254 \r\nStrict checks on the attribute `legend.steps` was added to the inventory\r\nview API in v8.10 (#160852), but they were not defined in the\r\nsaved object type for that data, resulting in older versions migrating\r\nbad data, and being unable to use the API. This PR adds versioning to\r\nthe Inventory view saved object type that constrains legend.steps to\r\nbetween 2 and 18, per the strict typing added in #160852\r\n\r\n#### Open questions\r\nShould we add notes to all versions of kibana between v8.10 and oldest\r\nversion available for backport describing this bug?\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a108c632a459240f9c27262395e2584f92d43779"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207007","number":207007,"mergeCommit":{"message":"Added versioning to inventory_view_saved_object (#207007)\n\n## Summary\r\n\r\nFixes #187254 \r\nStrict checks on the attribute `legend.steps` was added to the inventory\r\nview API in v8.10 (#160852), but they were not defined in the\r\nsaved object type for that data, resulting in older versions migrating\r\nbad data, and being unable to use the API. This PR adds versioning to\r\nthe Inventory view saved object type that constrains legend.steps to\r\nbetween 2 and 18, per the strict typing added in #160852\r\n\r\n#### Open questions\r\nShould we add notes to all versions of kibana between v8.10 and oldest\r\nversion available for backport describing this bug?\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a108c632a459240f9c27262395e2584f92d43779"}}]}] BACKPORT-->
bryce-b
added a commit
that referenced
this pull request
Feb 21, 2025
…1632) # Backport This will backport the following commits from `main` to `8.18`: - [Added versioning to inventory_view_saved_object (#207007)](#207007) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bryce Buchanan","email":"75274611+bryce-b@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-27T18:09:32Z","message":"Added versioning to inventory_view_saved_object (#207007)\n\n## Summary\r\n\r\nFixes #187254 \r\nStrict checks on the attribute `legend.steps` was added to the inventory\r\nview API in v8.10 (#160852), but they were not defined in the\r\nsaved object type for that data, resulting in older versions migrating\r\nbad data, and being unable to use the API. This PR adds versioning to\r\nthe Inventory view saved object type that constrains legend.steps to\r\nbetween 2 and 18, per the strict typing added in #160852\r\n\r\n#### Open questions\r\nShould we add notes to all versions of kibana between v8.10 and oldest\r\nversion available for backport describing this bug?\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a108c632a459240f9c27262395e2584f92d43779","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:fix","backport missing","v9.0.0","Team:obs-ux-infra_services"],"title":"Added versioning to inventory_view_saved_object","number":207007,"url":"https://github.com/elastic/kibana/pull/207007","mergeCommit":{"message":"Added versioning to inventory_view_saved_object (#207007)\n\n## Summary\r\n\r\nFixes #187254 \r\nStrict checks on the attribute `legend.steps` was added to the inventory\r\nview API in v8.10 (#160852), but they were not defined in the\r\nsaved object type for that data, resulting in older versions migrating\r\nbad data, and being unable to use the API. This PR adds versioning to\r\nthe Inventory view saved object type that constrains legend.steps to\r\nbetween 2 and 18, per the strict typing added in #160852\r\n\r\n#### Open questions\r\nShould we add notes to all versions of kibana between v8.10 and oldest\r\nversion available for backport describing this bug?\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a108c632a459240f9c27262395e2584f92d43779"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207007","number":207007,"mergeCommit":{"message":"Added versioning to inventory_view_saved_object (#207007)\n\n## Summary\r\n\r\nFixes #187254 \r\nStrict checks on the attribute `legend.steps` was added to the inventory\r\nview API in v8.10 (#160852), but they were not defined in the\r\nsaved object type for that data, resulting in older versions migrating\r\nbad data, and being unable to use the API. This PR adds versioning to\r\nthe Inventory view saved object type that constrains legend.steps to\r\nbetween 2 and 18, per the strict typing added in #160852\r\n\r\n#### Open questions\r\nShould we add notes to all versions of kibana between v8.10 and oldest\r\nversion available for backport describing this bug?\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a108c632a459240f9c27262395e2584f92d43779"}}]}] BACKPORT-->
bryce-b
added a commit
that referenced
this pull request
Feb 21, 2025
…1634) # Backport This will backport the following commits from `main` to `8.17`: - [Added versioning to inventory_view_saved_object (#207007)](#207007) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bryce Buchanan","email":"75274611+bryce-b@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-27T18:09:32Z","message":"Added versioning to inventory_view_saved_object (#207007)\n\n## Summary\r\n\r\nFixes #187254 \r\nStrict checks on the attribute `legend.steps` was added to the inventory\r\nview API in v8.10 (#160852), but they were not defined in the\r\nsaved object type for that data, resulting in older versions migrating\r\nbad data, and being unable to use the API. This PR adds versioning to\r\nthe Inventory view saved object type that constrains legend.steps to\r\nbetween 2 and 18, per the strict typing added in #160852\r\n\r\n#### Open questions\r\nShould we add notes to all versions of kibana between v8.10 and oldest\r\nversion available for backport describing this bug?\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a108c632a459240f9c27262395e2584f92d43779","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:fix","backport missing","v9.0.0","Team:obs-ux-infra_services"],"title":"Added versioning to inventory_view_saved_object","number":207007,"url":"https://github.com/elastic/kibana/pull/207007","mergeCommit":{"message":"Added versioning to inventory_view_saved_object (#207007)\n\n## Summary\r\n\r\nFixes #187254 \r\nStrict checks on the attribute `legend.steps` was added to the inventory\r\nview API in v8.10 (#160852), but they were not defined in the\r\nsaved object type for that data, resulting in older versions migrating\r\nbad data, and being unable to use the API. This PR adds versioning to\r\nthe Inventory view saved object type that constrains legend.steps to\r\nbetween 2 and 18, per the strict typing added in #160852\r\n\r\n#### Open questions\r\nShould we add notes to all versions of kibana between v8.10 and oldest\r\nversion available for backport describing this bug?\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a108c632a459240f9c27262395e2584f92d43779"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207007","number":207007,"mergeCommit":{"message":"Added versioning to inventory_view_saved_object (#207007)\n\n## Summary\r\n\r\nFixes #187254 \r\nStrict checks on the attribute `legend.steps` was added to the inventory\r\nview API in v8.10 (#160852), but they were not defined in the\r\nsaved object type for that data, resulting in older versions migrating\r\nbad data, and being unable to use the API. This PR adds versioning to\r\nthe Inventory view saved object type that constrains legend.steps to\r\nbetween 2 and 18, per the strict typing added in #160852\r\n\r\n#### Open questions\r\nShould we add notes to all versions of kibana between v8.10 and oldest\r\nversion available for backport describing this bug?\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a108c632a459240f9c27262395e2584f92d43779"}}]}] BACKPORT-->
kibanamachine
added
v8.18.0
v8.17.3
and removed
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #187254
Strict checks on the attribute
legend.stepswas added to the inventory view API in v8.10 (#160852), but they were not defined in thesaved object type for that data, resulting in older versions migrating bad data, and being unable to use the API. This PR adds versioning to the Inventory view saved object type that constrains legend.steps to between 2 and 18, per the strict typing added in #160852
Open questions
Should we add notes to all versions of kibana between v8.10 and oldest version available for backport describing this bug?Notes were added here: https://github.com/elastic/kibana/pull/207629/files
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines