Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Defend Workflows][Eui Visual Refresh] Removed transparentize usage in responder #208457

Merged
merged 8 commits into from
Feb 11, 2025
Merged

[Defend Workflows][Eui Visual Refresh] Removed transparentize usage in responder #208457

merged 8 commits into from
Feb 11, 2025

Conversation

parkiino
Copy link
Contributor

@parkiino parkiino commented Jan 27, 2025 •
edited
Loading

Summary

  • Removed use of color calculating function transparentize()
  • Begin removal of JSON tokens when possible in favor of colors tokens

@parkiino parkiino requested a review from a team as a code owner January 27, 2025 22:40
@parkiino parkiino changed the title remove transparentize usage, start updating to euiTheme instead of json [Defend Workflows][Eui Visual Refresh] Removed transparentize usage in responder Jan 27, 2025
@parkiino parkiino added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution EUI Visual Refresh labels Jan 27, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner January 27, 2025 22:48
jbudz
jbudz approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/kbn-babel-preset/styled_components_files.js LGTM

gergoabraham
gergoabraham approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great to address the deprecations, but it looks good nonetheless! 🚀

...y_solution/public/management/components/artifact_entry_card/artifact_entry_card_minified.tsx Outdated
}
`;

const CustomSplitInnerPanel = styled(EuiSplitPanel.Inner)`
background-color: ${({ theme }) => theme.eui.euiColorLightestShade} !important;
background-color: ${({ theme }) => theme.euiTheme.colors.lightestShade} !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like lightestShade is deprecated - since this PR already touches this line, do you think we can use another color here?

...solution/public/management/components/console/components/side_panel/side_panel_flex_item.tsx Outdated
border-radius: ${({ theme: { eui } }) => `0 ${eui.euiSizeXS} ${eui.euiSizeXS} 0`};
box-shadow: 0 ${({ theme: { eui } }) => eui.euiSizeXS} ${({ theme: { eui } }) => eui.euiSizeXS}
${({ theme: { eui } }) => transparentize(eui.euiShadowColor, 0.04)};
background-color: ${({ theme: { euiTheme } }) => euiTheme.colors.emptyShade} !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, emptyShade is deprecated as well

tomsonpl
tomsonpl approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

...y_solution/public/management/components/artifact_entry_card/artifact_entry_card_minified.tsx Outdated
}
`;

const CustomSplitInnerPanel = styled(EuiSplitPanel.Inner)`
background-color: ${({ theme }) => theme.eui.euiColorLightestShade} !important;
background-color: ${({ theme }) => theme.euiTheme.colors.lightestShade} !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is !important still necessary after the refactor?

@parkiino parkiino enabled auto-merge (squash) February 11, 2025 20:46
@parkiino parkiino merged commit eac85d4 into elastic:main Feb 11, 2025
9 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #59 / maps app geo file upload shapefile upload should add as document layer

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 24.9MB 24.9MB -17.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 92.5KB 92.6KB +24.0B
Unknown metric groups

async chunk count

id before after diff
securitySolution 109 110 +1

History

@parkiino parkiino deleted the task/eui-borealis-refresh2 branch February 12, 2025 04:42
@kibanamachine kibanamachine mentioned this pull request Feb 13, 2025
Merged
@parkiino parkiino added v8.19.0 and removed backport:skip This commit does not require backporting labels Feb 14, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208457 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 17, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208457 locally

5 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208457 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208457 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208457 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208457 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208457 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208457 locally

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208457 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208457 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208457 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208457 locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@tomsonpl tomsonpl tomsonpl approved these changes

@gergoabraham gergoabraham gergoabraham approved these changes

Assignees
No one assigned
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. backport EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@parkiino @elasticmachine @kibanamachine @jbudz @tomsonpl @gergoabraham