Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security GenAI] "Select a Connector" popup does not show up after the user selects any connector and then cancels it from Endpoint Insights. #208907

Open
sukhwindersingh-qasource opened this issue Jan 30, 2025 · 14 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Ready for Testing Code is merged and ready for QA to validate Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0

Comments

@sukhwindersingh-qasource

Describe the bug:

  • "Select a Connector" popup does not show up after the user selects any connector and then cancels it from Endpoint Insights.

Build Details:
VERSION: 9.0.0
BUILD: 83258
COMMIT: 199e75e

Login Credentials

Preconditions

  • Kibana should be running.
  • Endpoint should be present in the Endpoints tab

Steps to Reproduce

  • Click on the endpoint name.
  • Now click on Add Connector under the Endpoint Insights section.
  • Select any connector, for example, Amazon Bedrock.
  • Click on the cross icon to cancel.
  • Click on the Add Connector button again.
  • Observe that the "Select a Connector" popup does not show up after the user selects a connector and then cancels it from Endpoint Insights.

What is Working :

  • It works correctly when the user performs a hard refresh of the page after canceling the selected connector.

Actual result

  • "Select a Connector" popup does not show up after the user selects any connector and then cancels it from Endpoint Insights.

Expected Result

  • "Select a Connector" popup should be shown after the user selects any connector and then cancels it from Endpoint Insights.
  • This is important because sometimes another connector is selected mistakenly.

Screen-cast

Endpoints.-.Kibana.Mozilla.Firefox.2025-01-30.14-56-30.mp4

Logs

  • N/A
@sukhwindersingh-qasource sukhwindersingh-qasource added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v9.0.0 labels Jan 30, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@sukhwindersingh-qasource
Copy link
Author

@amolnater-qasource please review this

@amolnater-qasource
Copy link

Reviewed & assigned to @dasansol92

@e40pud
Copy link
Contributor

e40pud commented Jan 30, 2025

@elastic/security-generative-ai will take over this one.

@e40pud e40pud added the Team:Security Generative AI Security Generative AI label Jan 30, 2025
@e40pud e40pud changed the title [Defend Workflows] "Select a Connector" popup does not show up after the user selects any connector and then cancels it from Endpoint Insights. [Security GenAI] "Select a Connector" popup does not show up after the user selects any connector and then cancels it from Endpoint Insights. Jan 30, 2025
@e40pud e40pud removed the Team:Defend Workflows “EDR Workflows” sub-team of Security Solution label Jan 30, 2025
@e40pud
Copy link
Contributor

e40pud commented Jan 30, 2025

Steps to reproduce without required endpoint installation:

  1. Make sure there are no connectors
  2. Open "AI Assistant" on one of the security solution pages
  3. Press "(+) Add connector" button
  4. Connector type selection modal is visible
  5. Select "Amazon Bedrock" type (or any other connector type)
  6. Cancel the modal
  7. Press "(+) Add connector" button again

ISSUE: previously selected connector type is being displayed and there is no way to switch between types
EXPECTED: we should show connector type selection modal once previous one was closed

Screen.Recording.2025-01-30.at.15.55.30.mov

e40pud added a commit to e40pud/kibana that referenced this issue Jan 30, 2025
…e user selects any connector and then cancels it from Endpoint Insights. (elastic#208907)
e40pud added a commit that referenced this issue Jan 30, 2025
…e user selects any connector and then cancels it from Endpoint Insights. (#208907) (#208969)

## Summary

BUG: #208907

This PR fixes the issue where user cannot select a different connector
type after mistakenly selecting a wrong one.

### Steps to reproduce without required endpoint installation:

1. Make sure there are no connectors
2. Open "AI Assistant" on one of the security solution pages
3. Press "(+) Add connector" button
4. Connector type selection modal is visible
5. Select "Amazon Bedrock" type (or any other connector type)
6. Cancel the modal
7. Press "(+) Add connector" button again

**ISSUE**: previously selected connector type is being displayed and
there is no way to switch between types
**EXPECTED**: we should show connector type selection modal once
previous one was closed

### Issue recording


https://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf

### Fixed state recording


https://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 30, 2025
…e user selects any connector and then cancels it from Endpoint Insights. (elastic#208907) (elastic#208969)

## Summary

BUG: elastic#208907

This PR fixes the issue where user cannot select a different connector
type after mistakenly selecting a wrong one.

### Steps to reproduce without required endpoint installation:

1. Make sure there are no connectors
2. Open "AI Assistant" on one of the security solution pages
3. Press "(+) Add connector" button
4. Connector type selection modal is visible
5. Select "Amazon Bedrock" type (or any other connector type)
6. Cancel the modal
7. Press "(+) Add connector" button again

**ISSUE**: previously selected connector type is being displayed and
there is no way to switch between types
**EXPECTED**: we should show connector type selection modal once
previous one was closed

### Issue recording

https://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf

### Fixed state recording

https://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb
(cherry picked from commit b28036a)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 30, 2025
…e user selects any connector and then cancels it from Endpoint Insights. (elastic#208907) (elastic#208969)

## Summary

BUG: elastic#208907

This PR fixes the issue where user cannot select a different connector
type after mistakenly selecting a wrong one.

### Steps to reproduce without required endpoint installation:

1. Make sure there are no connectors
2. Open "AI Assistant" on one of the security solution pages
3. Press "(+) Add connector" button
4. Connector type selection modal is visible
5. Select "Amazon Bedrock" type (or any other connector type)
6. Cancel the modal
7. Press "(+) Add connector" button again

**ISSUE**: previously selected connector type is being displayed and
there is no way to switch between types
**EXPECTED**: we should show connector type selection modal once
previous one was closed

### Issue recording

https://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf

### Fixed state recording

https://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb
(cherry picked from commit b28036a)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 30, 2025
…e user selects any connector and then cancels it from Endpoint Insights. (elastic#208907) (elastic#208969)

## Summary

BUG: elastic#208907

This PR fixes the issue where user cannot select a different connector
type after mistakenly selecting a wrong one.

### Steps to reproduce without required endpoint installation:

1. Make sure there are no connectors
2. Open "AI Assistant" on one of the security solution pages
3. Press "(+) Add connector" button
4. Connector type selection modal is visible
5. Select "Amazon Bedrock" type (or any other connector type)
6. Cancel the modal
7. Press "(+) Add connector" button again

**ISSUE**: previously selected connector type is being displayed and
there is no way to switch between types
**EXPECTED**: we should show connector type selection modal once
previous one was closed

### Issue recording

https://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf

### Fixed state recording

https://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb
(cherry picked from commit b28036a)
kibanamachine added a commit that referenced this issue Jan 30, 2025
…show up after the user selects any connector and then cancels it from Endpoint Insights. (#208907) (#208969) (#208992)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security GenAI] "Select a Connector" popup does not show
up after the user selects any connector and then cancels it from
Endpoint Insights. (#208907)
(#208969)](#208969)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2025-01-30T16:53:36Z","message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:
SecuritySolution","backport:prev-major","Team:Security Generative
AI"],"title":"[Security GenAI] \"Select a Connector\" popup does not
show up after the user selects any connector and then cancels it from
Endpoint Insights.
(#208907)","number":208969,"url":"https://github.com/elastic/kibana/pull/208969","mergeCommit":{"message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208969","number":208969,"mergeCommit":{"message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
kibanamachine added a commit that referenced this issue Jan 30, 2025
… show up after the user selects any connector and then cancels it from Endpoint Insights. (#208907) (#208969) (#208989)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security GenAI] &quot;Select a Connector&quot; popup does not show
up after the user selects any connector and then cancels it from
Endpoint Insights. (#208907)
(#208969)](#208969)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2025-01-30T16:53:36Z","message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:
SecuritySolution","backport:prev-major","Team:Security Generative
AI"],"title":"[Security GenAI] \"Select a Connector\" popup does not
show up after the user selects any connector and then cancels it from
Endpoint Insights.
(#208907)","number":208969,"url":"https://github.com/elastic/kibana/pull/208969","mergeCommit":{"message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208969","number":208969,"mergeCommit":{"message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
kibanamachine added a commit that referenced this issue Jan 30, 2025
… show up after the user selects any connector and then cancels it from Endpoint Insights. (#208907) (#208969) (#208991)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Security GenAI] &quot;Select a Connector&quot; popup does not show
up after the user selects any connector and then cancels it from
Endpoint Insights. (#208907)
(#208969)](#208969)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2025-01-30T16:53:36Z","message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:
SecuritySolution","backport:prev-major","Team:Security Generative
AI"],"title":"[Security GenAI] \"Select a Connector\" popup does not
show up after the user selects any connector and then cancels it from
Endpoint Insights.
(#208907)","number":208969,"url":"https://github.com/elastic/kibana/pull/208969","mergeCommit":{"message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208969","number":208969,"mergeCommit":{"message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
@e40pud
Copy link
Contributor

e40pud commented Jan 30, 2025

@sukhwindersingh-qasource @MadameSheema this bug was fixed and changes were merged. Fix should be available in next versions: v8.16.4, v8.17.2, v8.18.0, v9.0.0.

@e40pud e40pud added the fixed label Jan 30, 2025
@sukhwindersingh-qasource sukhwindersingh-qasource added the QA:Ready for Testing Code is merged and ready for QA to validate label Jan 31, 2025
@peluja1012
Copy link
Contributor

Thanks for the fix @e40pud. I ran into this bug a couple of times recently.

@muskangulati-qasource
Copy link

Hi @MadameSheema ,

We have validated this is issue on 8.18.0 and verified that this feature is not available for the same. We revalidated this issue for 9.0.0 rc1 and found that issue is fixed there 🟢

Please find below the testing details:
Build details:

VERSION: 9.0.0-rc1
BUILD: 83822
COMMIT: 07dc0afa460bddff658ee6d5342ad1f087fc766b

Screen Recording

Endpoints.mp4

Please let us know if this ticket can be closed as it is fixed for 9.0.0 or needs to be kept open to validate on 8.18.0(if feature will be available on 8.18.0)

Thank you!

@MadameSheema
Copy link
Member

@muskangulati-qasource is pending the validation on 8.17.3

@e40pud can you please quickly check why this issue ins not present on 8.18?

@muskangulati-qasource
Copy link

Hi @MadameSheema,

The endpoints feature is planned for 9.0. Sorry for the confusions

I revalidated this ticket for the security side, and found everything to be working as expected for 8.17.3 but issue is not fixed on 8.18.0 BC5. Please find below the testing details:

Build details:

VERSION: 8.17.3
BUILD: 80852
COMMIT: faabb4e47ac99b6f367713ef845613b7313914b8
VERSION: 8.18.0
BUILD: 82557
COMMIT: b1da764d7db918082e4b9b82a8df5007f555e9b0

Screen Recordings

  • 8.18.0:
818.mp4
  • 8.17.3:
8173.mp4

We will revalidate this issue on 8.18.0 BC6.

Thank you!

e40pud added a commit to e40pud/kibana that referenced this issue Mar 3, 2025
…e user selects any connector and then cancels it from Endpoint Insights. (elastic#208907) (elastic#208969)

## Summary

BUG: elastic#208907

This PR fixes the issue where user cannot select a different connector
type after mistakenly selecting a wrong one.

### Steps to reproduce without required endpoint installation:

1. Make sure there are no connectors
2. Open "AI Assistant" on one of the security solution pages
3. Press "(+) Add connector" button
4. Connector type selection modal is visible
5. Select "Amazon Bedrock" type (or any other connector type)
6. Cancel the modal
7. Press "(+) Add connector" button again

**ISSUE**: previously selected connector type is being displayed and
there is no way to switch between types
**EXPECTED**: we should show connector type selection modal once
previous one was closed

### Issue recording

https://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf

### Fixed state recording

https://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb
(cherry picked from commit b28036a)
@e40pud
Copy link
Contributor

e40pud commented Mar 3, 2025

Hey @MadameSheema @muskangulati-qasource thank you for testing this. It looks like there were some issue with backporting my fix into 8.18 branch which happened during the cut off process and somehow my fix did not end up in 8.18.

I reported this backporting issue to the operations team and also created a new backport #212911. Once it is merged we can check it in the next v8.18.0 BC.

e40pud added a commit that referenced this issue Mar 3, 2025
…fter the user selects any connector and then cancels it from Endpoint Insights. (#208907) (#208969) (#212911)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Security GenAI] "Select a Connector" popup does not show up after
the user selects any connector and then cancels it from Endpoint
Insights. (#208907)
(#208969)](#208969)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2025-01-30T16:53:36Z","message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:
SecuritySolution","backport:prev-major","Team:Security Generative
AI","v8.18.0","v8.16.4","v8.17.2"],"title":"[Security GenAI] \"Select a
Connector\" popup does not show up after the user selects any connector
and then cancels it from Endpoint Insights.
(#208907)","number":208969,"url":"https://github.com/elastic/kibana/pull/208969","mergeCommit":{"message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208969","number":208969,"mergeCommit":{"message":"[Security
GenAI] \"Select a Connector\" popup does not show up after the user
selects any connector and then cancels it from Endpoint Insights.
(#208907) (#208969)\n\n## Summary\r\n\r\nBUG:
https://github.com/elastic/kibana/issues/208907\r\n\r\nThis PR fixes the
issue where user cannot select a different connector\r\ntype after
mistakenly selecting a wrong one.\r\n\r\n### Steps to reproduce without
required endpoint installation:\r\n\r\n1. Make sure there are no
connectors\r\n2. Open \"AI Assistant\" on one of the security solution
pages\r\n3. Press \"(+) Add connector\" button\r\n4. Connector type
selection modal is visible\r\n5. Select \"Amazon Bedrock\" type (or any
other connector type)\r\n6. Cancel the modal\r\n7. Press \"(+) Add
connector\" button again\r\n\r\n**ISSUE**: previously selected connector
type is being displayed and\r\nthere is no way to switch between
types\r\n**EXPECTED**: we should show connector type selection modal
once\r\nprevious one was closed\r\n\r\n### Issue
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48052bf1-4e00-43b7-a63e-f8a7969b9dbf\r\n\r\n###
Fixed state
recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/48be1cc4-0326-43a1-bd57-bb82fc1f19eb","sha":"b28036a2e0f13358b4da614761d32667612ac03a"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/208992","number":208992,"state":"MERGED","mergeCommit":{"sha":"5c65fcf815440c5d2a8db08f8591cc3e57849859","message":"[8.x]
[Security GenAI] &quot;Select a Connector&quot; popup does not show up
after the user selects any connector and then cancels it from Endpoint
Insights. (#208907) (#208969) (#208992)\n\n# Backport\n\nThis will
backport the following commits from `main` to `8.x`:\n- [[Security
GenAI] &quot;Select a Connector&quot; popup does not show\nup after the
user selects any connector and then cancels it from\nEndpoint Insights.
(#208907)\n(#208969)](https://github.com/elastic/kibana/pull/208969)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by:
Ievgen Sorokopud
<ievgen.sorokopud@elastic.co>"}},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/208989","number":208989,"state":"MERGED","mergeCommit":{"sha":"310514fd16025211903ba09a6c86d6f977caaf4f","message":"[8.16]
[Security GenAI] &quot;Select a Connector&quot; popup does not show up
after the user selects any connector and then cancels it from Endpoint
Insights. (#208907) (#208969) (#208989)\n\n# Backport\n\nThis will
backport the following commits from `main` to `8.16`:\n- [[Security
GenAI] &quot;Select a Connector&quot; popup does not show\nup after the
user selects any connector and then cancels it from\nEndpoint Insights.
(#208907)\n(#208969)](https://github.com/elastic/kibana/pull/208969)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by:
Ievgen Sorokopud
<ievgen.sorokopud@elastic.co>"}},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/208991","number":208991,"state":"MERGED","mergeCommit":{"sha":"5a829eb7bdda7e7bd6ff06736d5c8895d838d98d","message":"[8.17]
[Security GenAI] &quot;Select a Connector&quot; popup does not show up
after the user selects any connector and then cancels it from Endpoint
Insights. (#208907) (#208969) (#208991)\n\n# Backport\n\nThis will
backport the following commits from `main` to `8.17`:\n- [[Security
GenAI] &quot;Select a Connector&quot; popup does not show\nup after the
user selects any connector and then cancels it from\nEndpoint Insights.
(#208907)\n(#208969)](https://github.com/elastic/kibana/pull/208969)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by:
Ievgen Sorokopud <ievgen.sorokopud@elastic.co>"}}]}] BACKPORT-->
@e40pud
Copy link
Contributor

e40pud commented Mar 3, 2025

@MadameSheema just a heads-up, backport was merged into 8.18 branch, so next BC will contain the fix.

@MadameSheema
Copy link
Member

@muskangulati-qasource please validate the issue on the new BC, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Ready for Testing Code is merged and ready for QA to validate Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0
Projects
None yet
Development

No branches or pull requests

8 participants