-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visualizations] Replace SCSS with CSS-in-JS #208908
Labels
Comments
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
This was referenced Jan 31, 2025
This was referenced Feb 4, 2025
mariairiartef
added a commit
that referenced
this issue
Feb 6, 2025
## Summary Part of #208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Feb 6, 2025
## Summary Part of elastic#208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> (cherry picked from commit 228f83f)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Feb 6, 2025
## Summary Part of elastic#208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> (cherry picked from commit 228f83f)
drewdaemon
pushed a commit
to drewdaemon/kibana
that referenced
this issue
Feb 6, 2025
## Summary Part of elastic#208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
mariairiartef
added a commit
to mariairiartef/kibana
that referenced
this issue
Feb 7, 2025
## Summary Part of elastic#208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
This was referenced Feb 10, 2025
mariairiartef
added a commit
that referenced
this issue
Feb 13, 2025
## Summary Part of #208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Feb 13, 2025
…209578) ## Summary Part of elastic#208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Marco Liberati <dej611@users.noreply.github.com> (cherry picked from commit 623119c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Feb 18, 2025
…ts and gauge expression (elastic#208891) ## Summary part of elastic#208908 Replaces scss to css-in-js. I've tested all the changes. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 91a19c0)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Feb 18, 2025
…ts and gauge expression (elastic#208891) ## Summary part of elastic#208908 Replaces scss to css-in-js. I've tested all the changes. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 91a19c0)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Feb 18, 2025
…ts and gauge expression (elastic#208891) ## Summary part of elastic#208908 Replaces scss to css-in-js. I've tested all the changes. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 91a19c0)
mariairiartef
added a commit
that referenced
this issue
Mar 3, 2025
## Summary Part of #208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Mar 3, 2025
## Summary Part of elastic#208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> (cherry picked from commit 8cb484c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Mar 3, 2025
## Summary Part of elastic#208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> (cherry picked from commit 8cb484c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Mar 3, 2025
## Summary Part of elastic#208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> (cherry picked from commit 8cb484c)
mariairiartef
added a commit
that referenced
this issue
Mar 3, 2025
## Summary Part of #208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Mar 3, 2025
…09982) ## Summary Part of elastic#208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> (cherry picked from commit 3b3bbb1)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Mar 3, 2025
…09982) ## Summary Part of elastic#208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> (cherry picked from commit 3b3bbb1)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Mar 3, 2025
…09982) ## Summary Part of elastic#208908 Replaces scss to css-in-js. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> (cherry picked from commit 3b3bbb1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This issue tracks the removal of SCSS (Sass) throughout our plugins. The recommended replacement is to use @emotion/react wherever possible. More info at https://github.com/elastic/kibana-team/issues/1417.
DoD
kbn-event-annotation-components
src/platform/packages/shared/kbn-event-annotation-components/components/annotation_editor_controls/index.scss
kbn-visualization-ui-components
src/platform/packages/shared/kbn-visualization-ui-components/components/dimension_editor_section.scss
src/platform/packages/shared/kbn-visualization-ui-components/components/field_picker/field_picker.scss
src/platform/packages/shared/kbn-visualization-ui-components/components/query_input/filter_query_input.scss
Chart Expressions
src/platform/plugins/shared/chart_expressions
expression_gauge/public/components/gauge.scss
expression_gauge/public/components/index.scss
@mariairiartef
expression_heatmap/public/components/index.scss
[Lens] Replace scss for heatmap expression #209246expression_legacy_metric/public/components/metric.scss
[Lens/SCSS] Replace expression legacy metric scss #209546expression_tagcloud/public/components/tag_cloud.scss
[Lens/SCSS] Replace tag cloud expression metric css with js #209578expression_xy/public/components/annotations.scss
[Lens/SCSS] Delete and migrateannotations.scss
file #209074expression_xy/public/components/reference_lines/reference_lines.scss
[Lens/SCSS] Delete and migratereference_lines.scss
file #209982expression_xy/public/components/tooltip/tooltip.scss
expression_xy/public/components/xy_chart.scss
[Lens/SCSS] Migratexy_chart.scss
file to JS #210379Expressions
@mariairiartef
src/platform/plugins/shared/expressions/public/_expression_renderer.scss
[Lens/SCSS] Migrate_expression_renderer.scss
file to JS #210408src/platform/plugins/shared/expressions/public/index.scss
[Lens/SCSS] Migrate_expression_renderer.scss
file to JS #210408graph
@mariairiartef
x-pack/platform/plugins/private/graph/public/_main.scss
x-pack/platform/plugins/private/graph/public/_mixins.scss
x-pack/platform/plugins/private/graph/public/components/_app.scss
x-pack/platform/plugins/private/graph/public/components/_graph.scss
x-pack/platform/plugins/private/graph/public/components/_index.scss
x-pack/platform/plugins/private/graph/public/components/_inspect.scss
x-pack/platform/plugins/private/graph/public/components/_search_bar.scss
x-pack/platform/plugins/private/graph/public/components/_sidebar.scss
x-pack/platform/plugins/private/graph/public/components/_source_modal.scss
x-pack/platform/plugins/private/graph/public/components/field_manager/_field_editor.scss
x-pack/platform/plugins/private/graph/public/components/field_manager/_field_picker.scss
x-pack/platform/plugins/private/graph/public/components/field_manager/_index.scss
x-pack/platform/plugins/private/graph/public/components/graph_visualization/_graph_visualization.scss
x-pack/platform/plugins/private/graph/public/components/graph_visualization/_index.scss
x-pack/platform/plugins/private/graph/public/components/guidance_panel/_guidance_panel.scss
x-pack/platform/plugins/private/graph/public/components/guidance_panel/_index.scss
x-pack/platform/plugins/private/graph/public/components/settings/_index.scss
x-pack/platform/plugins/private/graph/public/components/settings/_legacy_icon.scss
x-pack/platform/plugins/private/graph/public/components/settings/_url_template_list.scss
x-pack/platform/plugins/private/graph/public/components/venn_diagram/_index.scss
x-pack/platform/plugins/private/graph/public/components/venn_diagram/_venn_diagram.scss
x-pack/platform/plugins/private/graph/public/index.scss
lens @mbondyra
lens/public/visualizations/datatable/components/dimension_editor.scss
@mbondyralens/public/visualizations/legacy_metric/dimension_editor.scss
@mbondyralens/public/visualizations/gauge/dimension_editor.scss
@mbondyralens/public/visualizations/heatmap/dimension_editor.scss
@mbondyralens/public/datasources/common/field_item.scss
@mbondyralens/public/visualizations/partition/toolbar.scss
@mbondyralens/public/visualizations/xy/xy_config_panel/axis_settings_popover.scss
@mbondyralens/public/datasources/form_based/help_popover.scss
@mbondyralens/public/editor_frame_service/editor_frame/config_panel/dimension_container.scss
@mbondyralens/public/editor_frame_service/editor_frame/data_panel_wrapper.scss
@mbondyralens/public/visualizations/gauge/toolbar_component/gauge_config_panel.scss
@mbondyralens/public/datasources/form_based/dimension_panel/field_select.scss
@mbondyralens/public/datasources/form_based/operations/definitions/filters/filter_popover.scss
@mbondyralens/public/datasources/form_based/operations/definitions/filters/filters.scss
@mbondyralens/public/datasources/form_based/operations/definitions/ranges/advanced_editor.scss
@mbondyralens/public/datasources/form_based/operations/definitions/shared_components/form_row.scss
@mbondyralens/public/editor_frame_service/editor_frame/workspace_panel/geo_field_workspace_panel.scss
@mbondyralens/public/shared_components/toolbar_popover.scss
@mbondyralens/public/app_plugin/app.scss
lens/public/editor_frame_service/editor_frame/workspace_panel/message_list.scss
lens/public/shared_components/setting_with_sibling_flyout.scss
lens/public/visualizations/datatable/components/table_basic.scss
lens/public/_mixins.scss
lens/public/_variables.scss
lens/public/datasources/form_based/datapanel.scss
lens/public/datasources/form_based/dimension_panel/dimension_editor.scss
lens/public/datasources/form_based/operations/definitions/formula/editor/formula.scss
lens/public/editor_frame_service/editor_frame/config_panel/chart_switch/chart_switch.scss
lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.scss
lens/public/editor_frame_service/editor_frame/frame_layout.scss
lens/public/editor_frame_service/editor_frame/suggestion_panel.scss
lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel_wrapper.scss
lens/public/react_embeddable/user_messages/info_badges.scss
lens/public/shared_components/dataview_picker/toolbar_button.scss
lens/public/shared_components/flyout_container.scss
lens/public/trigger_actions/open_lens_config/helpers.scss
lens/public/visualization_container.scss
tsvb
src/platform/plugins/shared/vis_types/timeseries/public/application/components/_annotations_editor.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/components/_error.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/components/_markdown_editor.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/components/_series_editor.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/components/_vis_editor_visualization.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/components/_vis_with_splits.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/components/last_value_mode_popover.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/components/panel_config/_panel_config.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/components/timeseries_visualization.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/components/vis_types/_vis_types.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/components/vis_types/markdown/_markdown.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/visualizations/views/_annotation.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/visualizations/views/_gauge.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/visualizations/views/_metric.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/visualizations/views/_top_n.scss
src/platform/plugins/shared/vis_types/timeseries/public/application/visualizations/views/_variables.scss
src/platform/plugins/shared/visualizations/public/legacy/embeddable/embeddables.scss
src/platform/plugins/shared/visualizations/public/legacy/embeddable/error_embeddable.scss
legacy visualizations
src/platform/plugins/private/vis_default_editor/public/_agg.scss
src/platform/plugins/private/vis_default_editor/public/_agg_params.scss
src/platform/plugins/private/vis_default_editor/public/_default.scss
src/platform/plugins/private/vis_default_editor/public/_sidebar.scss
src/platform/plugins/private/vis_default_editor/public/index.scss
src/platform/plugins/private/vis_types/table/public/components/table_visualization.scss
src/platform/plugins/private/vis_types/timelion/public/components/timelion_vis.scss
src/platform/plugins/private/vis_types/timelion/public/timelion_options.scss
src/platform/plugins/private/vis_types/vega/public/components/vega_editor.scss
src/platform/plugins/private/vis_types/vega/public/components/vega_vis.scss
src/platform/plugins/private/vis_types/vega/public/vega_inspector/vega_data_inspector.scss
src/platform/plugins/private/vis_types/vega/public/vega_view/vega_map_view/vega_map_view.scss
src/platform/plugins/private/vis_types/vislib/public/index.scss
src/platform/plugins/private/vis_types/vislib/public/vislib/_index.scss
src/platform/plugins/private/vis_types/vislib/public/vislib/_variables.scss
src/platform/plugins/private/vis_types/vislib/public/vislib/_vislib_vis_type.scss
src/platform/plugins/private/vis_types/vislib/public/vislib/components/legend/_index.scss
src/platform/plugins/private/vis_types/vislib/public/vislib/components/legend/_legend.scss
src/platform/plugins/private/vis_types/vislib/public/vislib/components/tooltip/_index.scss
src/platform/plugins/private/vis_types/vislib/public/vislib/components/tooltip/_tooltip.scss
src/platform/plugins/private/vis_types/vislib/public/vislib/lib/_index.scss
src/platform/plugins/private/vis_types/vislib/public/vislib/lib/layout/_index.scss
src/platform/plugins/private/vis_types/vislib/public/vislib/lib/layout/_layout.scss
src/platform/plugins/private/vis_types/vislib/public/vislib/visualizations/gauges/_index.scss
src/platform/plugins/private/vis_types/vislib/public/vislib/visualizations/gauges/_meter.scss
src/platform/plugins/shared/visualizations/public/vis.scss
src/platform/plugins/shared/visualizations/public/visualize_app/app.scss
src/platform/plugins/shared/visualizations/public/visualize_app/components/visualize_editor.scss
src/platform/plugins/shared/visualizations/public/visualize_app/components/visualize_listing.scss
src/platform/plugins/shared/visualizations/public/visualize_app/utils/visualize_navigation.scss
src/platform/plugins/shared/visualizations/public/visualize_screenshot_mode.scss
src/platform/plugins/shared/visualizations/public/wizard/dialog.scss
src/platform/plugins/shared/visualizations/public/wizard/group_selection/group_selection.scss
Shared with data discovery team:
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/drag_drop_mixins.scss
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/draggable.scss
src/platform/packages/shared/kbn-dom-drag-drop/src/sass/droppable.scss
src/platform/plugins/shared/data/public/index.scss
src/platform/plugins/shared/data/public/search/session/session_indicator/search_session_indicator/search_session_indicator.scss
src/platform/plugins/shared/data/public/search/session/sessions_mgmt/components/actions/inspect_button.scss
src/platform/plugins/shared/data/public/utils/table_inspector_view/_data_table.scss
src/platform/plugins/shared/data/public/utils/table_inspector_view/_index.scss
The text was updated successfully, but these errors were encountered: