-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] [Inconsistent] [Bug] The 'Enable' button should be disabled if no changes are made to the confirmation modal #209242
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
@amolnater-qasource please review! |
Reviewed & assigned to @MadameSheema |
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
Exploration path: @abhishekbhatia1710 mentioned this could be due to the fact that the Entity store creates some Risk scoring components, need to investigate if that is the cause |
Another path: make sure this fix is actually in the 8.18 branch (and if not, make sure it's in 8.x as well) |
@jaredburgettelastic Looks like the fix is in 8.18—both the confirmation modal message and logic to check state/hide/message are here, under I think @abhishekbhatia1710's suggestion is the way to go 🚀 |
This issue seems to be specific to version I checked in Additionally, if the For 8.16 : Screen.Recording.2025-02-14.at.2.51.20.PM.movFor 8.17 onwards: Screen.Recording.2025-02-14.at.3.33.27.PM.movI recall an issue in the past where the Entity Store wasn’t enabled because certain Risk Score components weren’t available beforehand. It was a "sequence issue" where both the Risk Score Engine and Entity Store Engine were enabled in parallel using the Enablement modal. If the Risk Score Engine failed to run, the Entity Store wouldn’t get enabled. However, this seems like the UI changes are not reflecting in 8.16 version at all. |
Thanks all for the collab on above! I added a final fix here. Previous fix looked only at the state of the toggle buttons only and did not account for riskScore or EntityStore enablement specifically. |
…ore Modal (#212078) ## Summary Ensure Enable Button Considers Disabled State of Risk Score & Entity Store. Previously only used the checked state of the toggle. ### Reproduce the Issue Steps, as [per bug ticket:](#209242 (comment)) 1. Kibana version 8.16.0 or above should exist 2. Navigate to the Dashboards tab under Security 3. Select Entity Analytics dashboard 4. Click on the enable button and enable risk score 5. Disable the options for Entity store 6. Then again select the enable button for Entity store 7. Disable the enable button 8. Observe the Enable button is still enabled ### After Issue Solved Same steps as above, but should show the warning and disable the button. #### Videos Videos show when either riskScore or entityStore is enabled, and the other is unchecked, the warning should show and the button should be disabled. https://github.com/user-attachments/assets/236f9e69-f810-4116-9948-38fd27d4d945 https://github.com/user-attachments/assets/2971e845-5d46-4eac-997a-79b3b17922c0 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…ore Modal (elastic#212078) ## Summary Ensure Enable Button Considers Disabled State of Risk Score & Entity Store. Previously only used the checked state of the toggle. ### Reproduce the Issue Steps, as [per bug ticket:](elastic#209242 (comment)) 1. Kibana version 8.16.0 or above should exist 2. Navigate to the Dashboards tab under Security 3. Select Entity Analytics dashboard 4. Click on the enable button and enable risk score 5. Disable the options for Entity store 6. Then again select the enable button for Entity store 7. Disable the enable button 8. Observe the Enable button is still enabled ### After Issue Solved Same steps as above, but should show the warning and disable the button. #### Videos Videos show when either riskScore or entityStore is enabled, and the other is unchecked, the warning should show and the button should be disabled. https://github.com/user-attachments/assets/236f9e69-f810-4116-9948-38fd27d4d945 https://github.com/user-attachments/assets/2971e845-5d46-4eac-997a-79b3b17922c0 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ba9210c)
…ore Modal (elastic#212078) ## Summary Ensure Enable Button Considers Disabled State of Risk Score & Entity Store. Previously only used the checked state of the toggle. ### Reproduce the Issue Steps, as [per bug ticket:](elastic#209242 (comment)) 1. Kibana version 8.16.0 or above should exist 2. Navigate to the Dashboards tab under Security 3. Select Entity Analytics dashboard 4. Click on the enable button and enable risk score 5. Disable the options for Entity store 6. Then again select the enable button for Entity store 7. Disable the enable button 8. Observe the Enable button is still enabled ### After Issue Solved Same steps as above, but should show the warning and disable the button. #### Videos Videos show when either riskScore or entityStore is enabled, and the other is unchecked, the warning should show and the button should be disabled. https://github.com/user-attachments/assets/236f9e69-f810-4116-9948-38fd27d4d945 https://github.com/user-attachments/assets/2971e845-5d46-4eac-997a-79b3b17922c0 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ba9210c)
…ore Modal (elastic#212078) ## Summary Ensure Enable Button Considers Disabled State of Risk Score & Entity Store. Previously only used the checked state of the toggle. ### Reproduce the Issue Steps, as [per bug ticket:](elastic#209242 (comment)) 1. Kibana version 8.16.0 or above should exist 2. Navigate to the Dashboards tab under Security 3. Select Entity Analytics dashboard 4. Click on the enable button and enable risk score 5. Disable the options for Entity store 6. Then again select the enable button for Entity store 7. Disable the enable button 8. Observe the Enable button is still enabled ### After Issue Solved Same steps as above, but should show the warning and disable the button. #### Videos Videos show when either riskScore or entityStore is enabled, and the other is unchecked, the warning should show and the button should be disabled. https://github.com/user-attachments/assets/236f9e69-f810-4116-9948-38fd27d4d945 https://github.com/user-attachments/assets/2971e845-5d46-4eac-997a-79b3b17922c0 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ba9210c) # Conflicts: # x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/enablement_modal.tsx
…ore Modal (elastic#212078) Ensure Enable Button Considers Disabled State of Risk Score & Entity Store. Previously only used the checked state of the toggle. Steps, as [per bug ticket:](elastic#209242 (comment)) 1. Kibana version 8.16.0 or above should exist 2. Navigate to the Dashboards tab under Security 3. Select Entity Analytics dashboard 4. Click on the enable button and enable risk score 5. Disable the options for Entity store 6. Then again select the enable button for Entity store 7. Disable the enable button 8. Observe the Enable button is still enabled Same steps as above, but should show the warning and disable the button. Videos show when either riskScore or entityStore is enabled, and the other is unchecked, the warning should show and the button should be disabled. https://github.com/user-attachments/assets/236f9e69-f810-4116-9948-38fd27d4d945 https://github.com/user-attachments/assets/2971e845-5d46-4eac-997a-79b3b17922c0 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ba9210c)
…ore Modal (elastic#212078) ## Summary Ensure Enable Button Considers Disabled State of Risk Score & Entity Store. Previously only used the checked state of the toggle. ### Reproduce the Issue Steps, as [per bug ticket:](elastic#209242 (comment)) 1. Kibana version 8.16.0 or above should exist 2. Navigate to the Dashboards tab under Security 3. Select Entity Analytics dashboard 4. Click on the enable button and enable risk score 5. Disable the options for Entity store 6. Then again select the enable button for Entity store 7. Disable the enable button 8. Observe the Enable button is still enabled ### After Issue Solved Same steps as above, but should show the warning and disable the button. #### Videos Videos show when either riskScore or entityStore is enabled, and the other is unchecked, the warning should show and the button should be disabled. https://github.com/user-attachments/assets/236f9e69-f810-4116-9948-38fd27d4d945 https://github.com/user-attachments/assets/2971e845-5d46-4eac-997a-79b3b17922c0 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
The first fix is in for this, however, not adding the "fixed" label until @machadoum adds a couple more bug fixes. |
Linking PR |
Thank you for the update @machadoum, We will validate this issue once we receive a new BC build for 8.18.0. Thank you! |
Describe the bug
The 'Enable' button should be disabled if no changes are made to the confirmation modal
Kibana/Elasticsearch Stack version
Steps
Expected Result
The Enable button should be disabled when no changes are made
Screen Recording
Entity.Analytics.-.Kibana.-.Google.Chrome.2025-02-03.15-01-06.mp4
NOTE
This issue is inconsistent and hence marked it as priority low.
The text was updated successfully, but these errors were encountered: