Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [Inconsistent] [Bug] The 'Enable' button should be disabled if no changes are made to the confirmation modal #209242

Open
muskangulati-qasource opened this issue Feb 3, 2025 · 12 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed v8.18.0

Comments

@muskangulati-qasource
Copy link

Describe the bug
The 'Enable' button should be disabled if no changes are made to the confirmation modal

Kibana/Elasticsearch Stack version

VERSION: 8.18.0
BUILD: 82206
COMMIT: 33e6754d67870b0e403266b752c3973539506cc6

Steps

  1. Kibana version 8.16.0 or above should exist
  2. Navigate to the Dashboards tab under Security
  3. Select Entity Analytics dashboard
  4. Click on the enable button and enable risk score
  5. Disable the options for Entity store
  6. Then again select the enable button for Entity store
  7. Disable the enable button
  8. Observe the Enable button is still enabled

Expected Result
The Enable button should be disabled when no changes are made

Screen Recording

Entity.Analytics.-.Kibana.-.Google.Chrome.2025-02-03.15-01-06.mp4

NOTE
This issue is inconsistent and hence marked it as priority low.

@muskangulati-qasource muskangulati-qasource added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed v8.18.0 labels Feb 3, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@muskangulati-qasource
Copy link
Author

@amolnater-qasource please review!

@amolnater-qasource
Copy link

Reviewed & assigned to @MadameSheema

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@jaredburgettelastic jaredburgettelastic removed their assignment Feb 10, 2025
@jaredburgettelastic
Copy link
Contributor

Exploration path: @abhishekbhatia1710 mentioned this could be due to the fact that the Entity store creates some Risk scoring components, need to investigate if that is the cause

@jaredburgettelastic
Copy link
Contributor

Another path: make sure this fix is actually in the 8.18 branch (and if not, make sure it's in 8.x as well)

@CAWilson94
Copy link
Contributor

@jaredburgettelastic Looks like the fix is in 8.18—both the confirmation modal message and logic to check state/hide/message are here, under enablementOptions and ENABLEMENT_WARNING_SELECT_TO_PROCEED.

I think @abhishekbhatia1710's suggestion is the way to go 🚀

@abhishekbhatia1710
Copy link
Contributor

This issue seems to be specific to version 8.16. I created a cluster with 8.16 and was able to reproduce it, but I couldn’t reproduce it on 8.17 or 8.18.

I checked in 8.x, the changes are there.

Additionally, if the Enable button is clicked while the Enable Entity Store toggle is off, only the init API for the Risk Engine is triggered. This is likely because the UI detects that it should be switched on, given that its state remains ON if it was previously installed. However, nothing gets installed for the Entity Store.

For 8.16 :

Screen.Recording.2025-02-14.at.2.51.20.PM.mov

For 8.17 onwards:

Screen.Recording.2025-02-14.at.3.33.27.PM.mov

I recall an issue in the past where the Entity Store wasn’t enabled because certain Risk Score components weren’t available beforehand. It was a "sequence issue" where both the Risk Score Engine and Entity Store Engine were enabled in parallel using the Enablement modal. If the Risk Score Engine failed to run, the Entity Store wouldn’t get enabled.

However, this seems like the UI changes are not reflecting in 8.16 version at all.

@CAWilson94
Copy link
Contributor

Thanks all for the collab on above! I added a final fix here. Previous fix looked only at the state of the toggle buttons only and did not account for riskScore or EntityStore enablement specifically.

CAWilson94 added a commit that referenced this issue Feb 24, 2025
…ore Modal (#212078)

## Summary

Ensure Enable Button Considers Disabled State of Risk Score & Entity
Store. Previously only used the checked state of the toggle.

### Reproduce the Issue
Steps, as [per bug
ticket:](#209242 (comment))

1. Kibana version 8.16.0 or above should exist
2. Navigate to the Dashboards tab under Security
3. Select Entity Analytics dashboard
4. Click on the enable button and enable risk score
5. Disable the options for Entity store
6. Then again select the enable button for Entity store
7. Disable the enable button
8. Observe the Enable button is still enabled

### After Issue Solved

Same steps as above, but should show the warning and disable the button.

#### Videos

Videos show when either riskScore or entityStore is enabled, and the
other is unchecked, the warning should show and the button should be
disabled.


https://github.com/user-attachments/assets/236f9e69-f810-4116-9948-38fd27d4d945



https://github.com/user-attachments/assets/2971e845-5d46-4eac-997a-79b3b17922c0

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 24, 2025
…ore Modal (elastic#212078)

## Summary

Ensure Enable Button Considers Disabled State of Risk Score & Entity
Store. Previously only used the checked state of the toggle.

### Reproduce the Issue
Steps, as [per bug
ticket:](elastic#209242 (comment))

1. Kibana version 8.16.0 or above should exist
2. Navigate to the Dashboards tab under Security
3. Select Entity Analytics dashboard
4. Click on the enable button and enable risk score
5. Disable the options for Entity store
6. Then again select the enable button for Entity store
7. Disable the enable button
8. Observe the Enable button is still enabled

### After Issue Solved

Same steps as above, but should show the warning and disable the button.

#### Videos

Videos show when either riskScore or entityStore is enabled, and the
other is unchecked, the warning should show and the button should be
disabled.

https://github.com/user-attachments/assets/236f9e69-f810-4116-9948-38fd27d4d945

https://github.com/user-attachments/assets/2971e845-5d46-4eac-997a-79b3b17922c0

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit ba9210c)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 24, 2025
…ore Modal (elastic#212078)

## Summary

Ensure Enable Button Considers Disabled State of Risk Score & Entity
Store. Previously only used the checked state of the toggle.

### Reproduce the Issue
Steps, as [per bug
ticket:](elastic#209242 (comment))

1. Kibana version 8.16.0 or above should exist
2. Navigate to the Dashboards tab under Security
3. Select Entity Analytics dashboard
4. Click on the enable button and enable risk score
5. Disable the options for Entity store
6. Then again select the enable button for Entity store
7. Disable the enable button
8. Observe the Enable button is still enabled

### After Issue Solved

Same steps as above, but should show the warning and disable the button.

#### Videos

Videos show when either riskScore or entityStore is enabled, and the
other is unchecked, the warning should show and the button should be
disabled.

https://github.com/user-attachments/assets/236f9e69-f810-4116-9948-38fd27d4d945

https://github.com/user-attachments/assets/2971e845-5d46-4eac-997a-79b3b17922c0

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit ba9210c)
CAWilson94 added a commit to CAWilson94/kibana that referenced this issue Feb 24, 2025
…ore Modal (elastic#212078)

## Summary

Ensure Enable Button Considers Disabled State of Risk Score & Entity
Store. Previously only used the checked state of the toggle.

### Reproduce the Issue
Steps, as [per bug
ticket:](elastic#209242 (comment))

1. Kibana version 8.16.0 or above should exist
2. Navigate to the Dashboards tab under Security
3. Select Entity Analytics dashboard
4. Click on the enable button and enable risk score
5. Disable the options for Entity store
6. Then again select the enable button for Entity store
7. Disable the enable button
8. Observe the Enable button is still enabled

### After Issue Solved

Same steps as above, but should show the warning and disable the button.

#### Videos

Videos show when either riskScore or entityStore is enabled, and the
other is unchecked, the warning should show and the button should be
disabled.

https://github.com/user-attachments/assets/236f9e69-f810-4116-9948-38fd27d4d945

https://github.com/user-attachments/assets/2971e845-5d46-4eac-997a-79b3b17922c0

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit ba9210c)

# Conflicts:
#	x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/enablement_modal.tsx
CAWilson94 added a commit to CAWilson94/kibana that referenced this issue Feb 24, 2025
…ore Modal (elastic#212078)

Ensure Enable Button Considers Disabled State of Risk Score & Entity
Store. Previously only used the checked state of the toggle.
Steps, as [per bug
ticket:](elastic#209242 (comment))

1. Kibana version 8.16.0 or above should exist
2. Navigate to the Dashboards tab under Security
3. Select Entity Analytics dashboard
4. Click on the enable button and enable risk score
5. Disable the options for Entity store
6. Then again select the enable button for Entity store
7. Disable the enable button
8. Observe the Enable button is still enabled

Same steps as above, but should show the warning and disable the button.

Videos show when either riskScore or entityStore is enabled, and the
other is unchecked, the warning should show and the button should be
disabled.

https://github.com/user-attachments/assets/236f9e69-f810-4116-9948-38fd27d4d945

https://github.com/user-attachments/assets/2971e845-5d46-4eac-997a-79b3b17922c0

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit ba9210c)
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this issue Feb 27, 2025
…ore Modal (elastic#212078)

## Summary

Ensure Enable Button Considers Disabled State of Risk Score & Entity
Store. Previously only used the checked state of the toggle.

### Reproduce the Issue
Steps, as [per bug
ticket:](elastic#209242 (comment))

1. Kibana version 8.16.0 or above should exist
2. Navigate to the Dashboards tab under Security
3. Select Entity Analytics dashboard
4. Click on the enable button and enable risk score
5. Disable the options for Entity store
6. Then again select the enable button for Entity store
7. Disable the enable button
8. Observe the Enable button is still enabled

### After Issue Solved

Same steps as above, but should show the warning and disable the button.

#### Videos

Videos show when either riskScore or entityStore is enabled, and the
other is unchecked, the warning should show and the button should be
disabled.


https://github.com/user-attachments/assets/236f9e69-f810-4116-9948-38fd27d4d945



https://github.com/user-attachments/assets/2971e845-5d46-4eac-997a-79b3b17922c0

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@jaredburgettelastic
Copy link
Contributor

The first fix is in for this, however, not adding the "fixed" label until @machadoum adds a couple more bug fixes.

@machadoum
Copy link
Member

machadoum commented Mar 6, 2025

Linking PR

@muskangulati-qasource
Copy link
Author

Thank you for the update @machadoum,

We will validate this issue once we receive a new BC build for 8.18.0.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed v8.18.0
Projects
None yet
Development

No branches or pull requests

8 participants