Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add refresh for event log, when we fill gap #209906

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Add refresh for event log, when we fill gap #209906

merged 4 commits into from
Feb 10, 2025
+56 −1

Conversation

nkhristinin
Copy link
Contributor

@nkhristinin nkhristinin commented Feb 5, 2025 •
edited by kibanamachine
Loading

Add refresh for event log, when we fill gap

As we update gaps, and don't wait for refresh in UI we can have inconsistent state:

  • Go to gap table
  • Click fill gap, wait for api response
  • Then we refetch gaps, but because we don't wait for refresh we get old gaps and action "Fill gap" still remain in the table

In this PR we introduce index refresh, which only happens when user make an action to fill gap

@nkhristinin
Copy link
Contributor Author

/ci

@nkhristinin
Copy link
Contributor Author

/ci

@nkhristinin nkhristinin marked this pull request as ready for review February 6, 2025 15:00
@nkhristinin nkhristinin requested a review from a team as a code owner February 6, 2025 15:00
@nkhristinin nkhristinin added release_note:skip Skip the PR/issue when compiling release notes backport:8.18 backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Feb 6, 2025
@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

pmuellr
pmuellr approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin nkhristinin enabled auto-merge (squash) February 10, 2025 09:50
@nkhristinin nkhristinin merged commit fd7c759 into elastic:main Feb 10, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13239859797

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
eventLog 82 83 +1
Unknown metric groups

API count

id before after diff
eventLog 82 83 +1

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 10, 2025
@nkhristinin
Add refresh for event log, when we fill gap (elastic#209906)
d393e4c 
## Add refresh for event log, when we fill gap

As we update gaps, and don't wait for refresh in UI we can have
inconsistent state:

- Go to gap table
- Click fill gap, wait for api response
- Then we refetch gaps, but because we don't wait for refresh we get old
gaps and action "Fill gap" still remain in the table

In this PR we introduce index refresh, which only happens when user make
an action to fill gap

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit fd7c759)
@kibanamachine kibanamachine mentioned this pull request Feb 10, 2025
Open
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

This was referenced Feb 10, 2025
Merged
Merged
@nkhristinin
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x
✅ 8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nkhristinin added a commit to nkhristinin/kibana that referenced this pull request Feb 10, 2025
@nkhristinin
Add refresh for event log, when we fill gap (elastic#209906)
f0ec174 
## Add refresh for event log, when we fill gap

As we update gaps, and don't wait for refresh in UI we can have
inconsistent state:

- Go to gap table
- Click fill gap, wait for api response
- Then we refetch gaps, but because we don't wait for refresh we get old
gaps and action "Fill gap" still remain in the table

In this PR we introduce index refresh, which only happens when user make
an action to fill gap

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit fd7c759)
nkhristinin added a commit to nkhristinin/kibana that referenced this pull request Feb 10, 2025
@nkhristinin
Add refresh for event log, when we fill gap (elastic#209906)
35d45b1 
## Add refresh for event log, when we fill gap

As we update gaps, and don't wait for refresh in UI we can have
inconsistent state:

- Go to gap table
- Click fill gap, wait for api response
- Then we refetch gaps, but because we don't wait for refresh we get old
gaps and action "Fill gap" still remain in the table

In this PR we introduce index refresh, which only happens when user make
an action to fill gap

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit fd7c759)
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Feb 10, 2025
@nkhristinin @elasticmachine @Samiul-TheSoccerFan
Add refresh for event log, when we fill gap (elastic#209906)
13cb3ab 
## Add refresh for event log, when we fill gap 

As we update gaps, and don't wait for refresh in UI we can have
inconsistent state:

- Go to gap table
- Click fill gap, wait for api response
- Then we refetch gaps, but because we don't wait for refresh we get old
gaps and action "Fill gap" still remain in the table

In this PR we introduce index refresh, which only happens when user make
an action to fill gap

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 11, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

nkhristinin added a commit that referenced this pull request Feb 11, 2025
@nkhristinin
[8.18] Add refresh for event log, when we fill gap (#209906) (#210352)
010e768 
# Backport

This will backport the following commits from `main` to `8.18`:
- [Add refresh for event log, when we fill gap
(#209906)](#209906)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"nikita.khristinin@elastic.co"},"sourceCommit":{"committedDate":"2025-02-10T11:31:49Z","message":"Add
refresh for event log, when we fill gap (#209906)\n\n## Add refresh for
event log, when we fill gap \r\n\r\nAs we update gaps, and don't wait
for refresh in UI we can have\r\ninconsistent state:\r\n\r\n- Go to gap
table\r\n- Click fill gap, wait for api response\r\n- Then we refetch
gaps, but because we don't wait for refresh we get old\r\ngaps and
action \"Fill gap\" still remain in the table\r\n\r\nIn this PR we
introduce index refresh, which only happens when user make\r\nan action
to fill gap\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"fd7c7591daacf68fcc628515687ed1f1f839c589","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v9.1.0","backport:8.18"],"title":"Add
refresh for event log, when we fill
gap","number":209906,"url":"https://github.com/elastic/kibana/pull/209906","mergeCommit":{"message":"Add
refresh for event log, when we fill gap (#209906)\n\n## Add refresh for
event log, when we fill gap \r\n\r\nAs we update gaps, and don't wait
for refresh in UI we can have\r\ninconsistent state:\r\n\r\n- Go to gap
table\r\n- Click fill gap, wait for api response\r\n- Then we refetch
gaps, but because we don't wait for refresh we get old\r\ngaps and
action \"Fill gap\" still remain in the table\r\n\r\nIn this PR we
introduce index refresh, which only happens when user make\r\nan action
to fill gap\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"fd7c7591daacf68fcc628515687ed1f1f839c589"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209906","number":209906,"mergeCommit":{"message":"Add
refresh for event log, when we fill gap (#209906)\n\n## Add refresh for
event log, when we fill gap \r\n\r\nAs we update gaps, and don't wait
for refresh in UI we can have\r\ninconsistent state:\r\n\r\n- Go to gap
table\r\n- Click fill gap, wait for api response\r\n- Then we refetch
gaps, but because we don't wait for refresh we get old\r\ngaps and
action \"Fill gap\" still remain in the table\r\n\r\nIn this PR we
introduce index refresh, which only happens when user make\r\nan action
to fill gap\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"fd7c7591daacf68fcc628515687ed1f1f839c589"}},{"url":"https://github.com/elastic/kibana/pull/210338","number":210338,"branch":"9.0","state":"OPEN"}]}]
BACKPORT-->
nkhristinin added a commit that referenced this pull request Feb 11, 2025
@nkhristinin
[8.x] Add refresh for event log, when we fill gap (#209906) (#210351)
4176e33 
# Backport

This will backport the following commits from `main` to `8.x`:
- [Add refresh for event log, when we fill gap
(#209906)](#209906)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"nikita.khristinin@elastic.co"},"sourceCommit":{"committedDate":"2025-02-10T11:31:49Z","message":"Add
refresh for event log, when we fill gap (#209906)\n\n## Add refresh for
event log, when we fill gap \r\n\r\nAs we update gaps, and don't wait
for refresh in UI we can have\r\ninconsistent state:\r\n\r\n- Go to gap
table\r\n- Click fill gap, wait for api response\r\n- Then we refetch
gaps, but because we don't wait for refresh we get old\r\ngaps and
action \"Fill gap\" still remain in the table\r\n\r\nIn this PR we
introduce index refresh, which only happens when user make\r\nan action
to fill gap\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"fd7c7591daacf68fcc628515687ed1f1f839c589","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v9.1.0","backport:8.18"],"title":"Add
refresh for event log, when we fill
gap","number":209906,"url":"https://github.com/elastic/kibana/pull/209906","mergeCommit":{"message":"Add
refresh for event log, when we fill gap (#209906)\n\n## Add refresh for
event log, when we fill gap \r\n\r\nAs we update gaps, and don't wait
for refresh in UI we can have\r\ninconsistent state:\r\n\r\n- Go to gap
table\r\n- Click fill gap, wait for api response\r\n- Then we refetch
gaps, but because we don't wait for refresh we get old\r\ngaps and
action \"Fill gap\" still remain in the table\r\n\r\nIn this PR we
introduce index refresh, which only happens when user make\r\nan action
to fill gap\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"fd7c7591daacf68fcc628515687ed1f1f839c589"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209906","number":209906,"mergeCommit":{"message":"Add
refresh for event log, when we fill gap (#209906)\n\n## Add refresh for
event log, when we fill gap \r\n\r\nAs we update gaps, and don't wait
for refresh in UI we can have\r\ninconsistent state:\r\n\r\n- Go to gap
table\r\n- Click fill gap, wait for api response\r\n- Then we refetch
gaps, but because we don't wait for refresh we get old\r\ngaps and
action \"Fill gap\" still remain in the table\r\n\r\nIn this PR we
introduce index refresh, which only happens when user make\r\nan action
to fill gap\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"fd7c7591daacf68fcc628515687ed1f1f839c589"}},{"url":"https://github.com/elastic/kibana/pull/210338","number":210338,"branch":"9.0","state":"OPEN"}]}]
BACKPORT-->
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

15 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

Assignees
No one assigned
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) backport:8.18 release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v8.19.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkhristinin @kibanamachine @elasticmachine @pmuellr