Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Change fieldDefinitionType to enum #211775

Closed
stratoula opened this issue Feb 19, 2025 · 1 comment · Fixed by #211782
Closed

[ES|QL] Change fieldDefinitionType to enum #211775

stratoula opened this issue Feb 19, 2025 · 1 comment · Fixed by #211782
Labels
Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana technical debt Improvement of the software architecture and operational architecture

Comments

@stratoula
Copy link
Contributor

Describe the feature:

We can change https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-esql-validation-autocomplete/src/definitions/types.ts#L177 to enum:

export enum FunctionDefinitionType {
  AGG = 'agg',
  SCALAR = 'scalar',
  OPERATOR = 'operator',
  GROUPING = 'grouping',
}

and use them across the codebase.

@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Feb 19, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added the technical debt Improvement of the software architecture and operational architecture label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants