[Security Solution] Convert isolate host to standalone flyout #211853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Desk tested and while I feel that the code shouldn't really belong within the flyout folder as it is not a panel, like we discussed over Zoom, this is the fastest and safest way to implement this change right now.
You have no idea how this change makes me happy though! I've been wanting to do this since April 2023, so thank you for finally getting rid of this... awful UI behavior! 🙇 🤣 🚀
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
christineweng
added
release_note:fix
and removed
release_note:skip
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 25, 2025
…c#211853) ## Summary Ref: elastic#207596 This PR fixed a bug where when user has a alert open in preview, then clicks isolate/release host, the panel opens in the background. This is because the isolate host panel was called via `openRightPanel`, which only replaces the panel and not opens a new flyout. To make the isolate host flyout consistent with other actions, this PR converts the panel into a normal EUI flyout. https://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547 **How to test** - Apply license (platinum+) - To enable the isolate/release host button, you can use this command `yarn test:generate --fleet --withNewUser=test:changeme` ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 74e1320)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 25, 2025
…c#211853) ## Summary Ref: elastic#207596 This PR fixed a bug where when user has a alert open in preview, then clicks isolate/release host, the panel opens in the background. This is because the isolate host panel was called via `openRightPanel`, which only replaces the panel and not opens a new flyout. To make the isolate host flyout consistent with other actions, this PR converts the panel into a normal EUI flyout. https://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547 **How to test** - Apply license (platinum+) - To enable the isolate/release host button, you can use this command `yarn test:generate --fleet --withNewUser=test:changeme` ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 74e1320)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 25, 2025
…c#211853) ## Summary Ref: elastic#207596 This PR fixed a bug where when user has a alert open in preview, then clicks isolate/release host, the panel opens in the background. This is because the isolate host panel was called via `openRightPanel`, which only replaces the panel and not opens a new flyout. To make the isolate host flyout consistent with other actions, this PR converts the panel into a normal EUI flyout. https://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547 **How to test** - Apply license (platinum+) - To enable the isolate/release host button, you can use this command `yarn test:generate --fleet --withNewUser=test:changeme` ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 74e1320)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 25, 2025
…211853) (#212433) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Convert isolate host to standalone flyout (#211853)](#211853) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-25T18:11:36Z","message":"[Security Solution] Convert isolate host to standalone flyout (#211853)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/207596\n\nThis PR fixed a bug where when user has a alert open in preview, then\nclicks isolate/release host, the panel opens in the background. This is\nbecause the isolate host panel was called via `openRightPanel`, which\nonly replaces the panel and not opens a new flyout. To make the isolate\nhost flyout consistent with other actions, this PR converts the panel\ninto a normal EUI flyout.\n\n\nhttps://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547\n\n\n**How to test**\n- Apply license (platinum+)\n- To enable the isolate/release host button, you can use this command\n`yarn test:generate --fleet --withNewUser=test:changeme`\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"74e132027617cbeef8a41450626065a884505068","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Convert isolate host to standalone flyout","number":211853,"url":"https://github.com/elastic/kibana/pull/211853","mergeCommit":{"message":"[Security Solution] Convert isolate host to standalone flyout (#211853)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/207596\n\nThis PR fixed a bug where when user has a alert open in preview, then\nclicks isolate/release host, the panel opens in the background. This is\nbecause the isolate host panel was called via `openRightPanel`, which\nonly replaces the panel and not opens a new flyout. To make the isolate\nhost flyout consistent with other actions, this PR converts the panel\ninto a normal EUI flyout.\n\n\nhttps://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547\n\n\n**How to test**\n- Apply license (platinum+)\n- To enable the isolate/release host button, you can use this command\n`yarn test:generate --fleet --withNewUser=test:changeme`\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"74e132027617cbeef8a41450626065a884505068"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211853","number":211853,"mergeCommit":{"message":"[Security Solution] Convert isolate host to standalone flyout (#211853)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/207596\n\nThis PR fixed a bug where when user has a alert open in preview, then\nclicks isolate/release host, the panel opens in the background. This is\nbecause the isolate host panel was called via `openRightPanel`, which\nonly replaces the panel and not opens a new flyout. To make the isolate\nhost flyout consistent with other actions, this PR converts the panel\ninto a normal EUI flyout.\n\n\nhttps://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547\n\n\n**How to test**\n- Apply license (platinum+)\n- To enable the isolate/release host button, you can use this command\n`yarn test:generate --fleet --withNewUser=test:changeme`\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"74e132027617cbeef8a41450626065a884505068"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 25, 2025
…211853) (#212434) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Convert isolate host to standalone flyout (#211853)](#211853) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-25T18:11:36Z","message":"[Security Solution] Convert isolate host to standalone flyout (#211853)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/207596\n\nThis PR fixed a bug where when user has a alert open in preview, then\nclicks isolate/release host, the panel opens in the background. This is\nbecause the isolate host panel was called via `openRightPanel`, which\nonly replaces the panel and not opens a new flyout. To make the isolate\nhost flyout consistent with other actions, this PR converts the panel\ninto a normal EUI flyout.\n\n\nhttps://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547\n\n\n**How to test**\n- Apply license (platinum+)\n- To enable the isolate/release host button, you can use this command\n`yarn test:generate --fleet --withNewUser=test:changeme`\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"74e132027617cbeef8a41450626065a884505068","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Convert isolate host to standalone flyout","number":211853,"url":"https://github.com/elastic/kibana/pull/211853","mergeCommit":{"message":"[Security Solution] Convert isolate host to standalone flyout (#211853)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/207596\n\nThis PR fixed a bug where when user has a alert open in preview, then\nclicks isolate/release host, the panel opens in the background. This is\nbecause the isolate host panel was called via `openRightPanel`, which\nonly replaces the panel and not opens a new flyout. To make the isolate\nhost flyout consistent with other actions, this PR converts the panel\ninto a normal EUI flyout.\n\n\nhttps://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547\n\n\n**How to test**\n- Apply license (platinum+)\n- To enable the isolate/release host button, you can use this command\n`yarn test:generate --fleet --withNewUser=test:changeme`\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"74e132027617cbeef8a41450626065a884505068"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211853","number":211853,"mergeCommit":{"message":"[Security Solution] Convert isolate host to standalone flyout (#211853)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/207596\n\nThis PR fixed a bug where when user has a alert open in preview, then\nclicks isolate/release host, the panel opens in the background. This is\nbecause the isolate host panel was called via `openRightPanel`, which\nonly replaces the panel and not opens a new flyout. To make the isolate\nhost flyout consistent with other actions, this PR converts the panel\ninto a normal EUI flyout.\n\n\nhttps://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547\n\n\n**How to test**\n- Apply license (platinum+)\n- To enable the isolate/release host button, you can use this command\n`yarn test:generate --fleet --withNewUser=test:changeme`\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"74e132027617cbeef8a41450626065a884505068"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 26, 2025
…211853) (#212435) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Convert isolate host to standalone flyout (#211853)](#211853) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-25T18:11:36Z","message":"[Security Solution] Convert isolate host to standalone flyout (#211853)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/207596\n\nThis PR fixed a bug where when user has a alert open in preview, then\nclicks isolate/release host, the panel opens in the background. This is\nbecause the isolate host panel was called via `openRightPanel`, which\nonly replaces the panel and not opens a new flyout. To make the isolate\nhost flyout consistent with other actions, this PR converts the panel\ninto a normal EUI flyout.\n\n\nhttps://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547\n\n\n**How to test**\n- Apply license (platinum+)\n- To enable the isolate/release host button, you can use this command\n`yarn test:generate --fleet --withNewUser=test:changeme`\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"74e132027617cbeef8a41450626065a884505068","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Convert isolate host to standalone flyout","number":211853,"url":"https://github.com/elastic/kibana/pull/211853","mergeCommit":{"message":"[Security Solution] Convert isolate host to standalone flyout (#211853)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/207596\n\nThis PR fixed a bug where when user has a alert open in preview, then\nclicks isolate/release host, the panel opens in the background. This is\nbecause the isolate host panel was called via `openRightPanel`, which\nonly replaces the panel and not opens a new flyout. To make the isolate\nhost flyout consistent with other actions, this PR converts the panel\ninto a normal EUI flyout.\n\n\nhttps://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547\n\n\n**How to test**\n- Apply license (platinum+)\n- To enable the isolate/release host button, you can use this command\n`yarn test:generate --fleet --withNewUser=test:changeme`\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"74e132027617cbeef8a41450626065a884505068"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211853","number":211853,"mergeCommit":{"message":"[Security Solution] Convert isolate host to standalone flyout (#211853)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/207596\n\nThis PR fixed a bug where when user has a alert open in preview, then\nclicks isolate/release host, the panel opens in the background. This is\nbecause the isolate host panel was called via `openRightPanel`, which\nonly replaces the panel and not opens a new flyout. To make the isolate\nhost flyout consistent with other actions, this PR converts the panel\ninto a normal EUI flyout.\n\n\nhttps://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547\n\n\n**How to test**\n- Apply license (platinum+)\n- To enable the isolate/release host button, you can use this command\n`yarn test:generate --fleet --withNewUser=test:changeme`\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"74e132027617cbeef8a41450626065a884505068"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Feb 27, 2025
…c#211853) ## Summary Ref: elastic#207596 This PR fixed a bug where when user has a alert open in preview, then clicks isolate/release host, the panel opens in the background. This is because the isolate host panel was called via `openRightPanel`, which only replaces the panel and not opens a new flyout. To make the isolate host flyout consistent with other actions, this PR converts the panel into a normal EUI flyout. https://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547 **How to test** - Apply license (platinum+) - To enable the isolate/release host button, you can use this command `yarn test:generate --fleet --withNewUser=test:changeme` ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Mar 4, 2025
…lastic#211853) (elastic#212434) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Convert isolate host to standalone flyout (elastic#211853)](elastic#211853) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-25T18:11:36Z","message":"[Security Solution] Convert isolate host to standalone flyout (elastic#211853)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/207596\n\nThis PR fixed a bug where when user has a alert open in preview, then\nclicks isolate/release host, the panel opens in the background. This is\nbecause the isolate host panel was called via `openRightPanel`, which\nonly replaces the panel and not opens a new flyout. To make the isolate\nhost flyout consistent with other actions, this PR converts the panel\ninto a normal EUI flyout.\n\n\nhttps://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547\n\n\n**How to test**\n- Apply license (platinum+)\n- To enable the isolate/release host button, you can use this command\n`yarn test:generate --fleet --withNewUser=test:changeme`\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"74e132027617cbeef8a41450626065a884505068","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Convert isolate host to standalone flyout","number":211853,"url":"https://github.com/elastic/kibana/pull/211853","mergeCommit":{"message":"[Security Solution] Convert isolate host to standalone flyout (elastic#211853)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/207596\n\nThis PR fixed a bug where when user has a alert open in preview, then\nclicks isolate/release host, the panel opens in the background. This is\nbecause the isolate host panel was called via `openRightPanel`, which\nonly replaces the panel and not opens a new flyout. To make the isolate\nhost flyout consistent with other actions, this PR converts the panel\ninto a normal EUI flyout.\n\n\nhttps://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547\n\n\n**How to test**\n- Apply license (platinum+)\n- To enable the isolate/release host button, you can use this command\n`yarn test:generate --fleet --withNewUser=test:changeme`\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"74e132027617cbeef8a41450626065a884505068"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211853","number":211853,"mergeCommit":{"message":"[Security Solution] Convert isolate host to standalone flyout (elastic#211853)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/207596\n\nThis PR fixed a bug where when user has a alert open in preview, then\nclicks isolate/release host, the panel opens in the background. This is\nbecause the isolate host panel was called via `openRightPanel`, which\nonly replaces the panel and not opens a new flyout. To make the isolate\nhost flyout consistent with other actions, this PR converts the panel\ninto a normal EUI flyout.\n\n\nhttps://github.com/user-attachments/assets/7da4baa0-61ee-4166-9ff1-57c1078a1547\n\n\n**How to test**\n- Apply license (platinum+)\n- To enable the isolate/release host button, you can use this command\n`yarn test:generate --fleet --withNewUser=test:changeme`\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"74e132027617cbeef8a41450626065a884505068"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref: #207596
This PR fixed a bug where when user has a alert open in preview, then clicks isolate/release host, the panel opens in the background. This is because the isolate host panel was called via
openRightPanel, which only replaces the panel and not opens a new flyout. To make the isolate host flyout consistent with other actions, this PR converts the panel into a normal EUI flyout.Screen.Recording.2025-02-19.at.4.20.45.PM.mov
How to test
yarn test:generate --fleet --withNewUser=test:changemeChecklist
release_note:*label is applied per the guidelines