-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inspector] Use tabs instead of dropdown for view selection #212864
base: main
Are you sure you want to change the base?
[Inspector] Use tabs instead of dropdown for view selection #212864
Conversation
56b00b0
to
805ea79
Compare
805ea79
to
c2eb46d
Compare
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tabs.In addition to the changes, the functional testing code at https://github.com/elastic/kibana/blob/main/test/functional/services/inspector.ts#L191 should be updated. The inspectorViewChooser
button no longer exists so there is no need to click it and instead, the tab can just be selected directly.
src/platform/plugins/shared/inspector/public/ui/inspector_view_chooser.tsx
Show resolved
Hide resolved
Just tweaked the functional tests. Not 100% sure I correctly tested them locally. I got no failures when running:
But running it with
|
💔 Build Failed
Failed CI StepsHistory
cc @cqliu1 |
Summary
Closes #126918.
Currently, the inspector uses a button and dropdown for just two options as in this screenshot:
This PR switches it to instead use tabs as in this screenshot:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.