Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inspector] Use tabs instead of dropdown for view selection #212864

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

matthewabbott
Copy link

Summary

Closes #126918.

Currently, the inspector uses a button and dropdown for just two options as in this screenshot:

Screenshot 2025-03-03 at 1 45 35 AM

This PR switches it to instead use tabs as in this screenshot:

Screenshot 2025-03-03 at 12 40 06 AM

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@matthewabbott matthewabbott added Feature:Inspector Inspector infrastructure and implementations enhancement New value added to drive a business result Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Mar 3, 2025
@matthewabbott matthewabbott force-pushed the inspector/view-selection-tabs branch from 56b00b0 to 805ea79 Compare March 3, 2025 11:19
@matthewabbott matthewabbott force-pushed the inspector/view-selection-tabs branch from 805ea79 to c2eb46d Compare March 3, 2025 11:32
@matthewabbott matthewabbott added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Mar 3, 2025
@matthewabbott matthewabbott marked this pull request as ready for review March 3, 2025 23:20
@matthewabbott matthewabbott requested review from a team as code owners March 3, 2025 23:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tabs.In addition to the changes, the functional testing code at https://github.com/elastic/kibana/blob/main/test/functional/services/inspector.ts#L191 should be updated. The inspectorViewChooser button no longer exists so there is no need to click it and instead, the tab can just be selected directly.

@matthewabbott
Copy link
Author

functional testing code at https://github.com/elastic/kibana/blob/main/test/functional/services/inspector.ts#L191 should be updated. The inspectorViewChooser button no longer exists so there is no need to click it and instead, the tab can just be selected directly.

Just tweaked the functional tests. Not 100% sure I correctly tested them locally. I got no failures when running:

node scripts/functional_test_runner --config test/functional/apps/home/config.ts

But running it with --grep="inspector" did no tests, so I’m not sure I was targeting the right config.

node scripts/functional_test_runner --config test/functional/apps/home/config.ts --grep="inspector"

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 5, 2025

💔 Build Failed

Failed CI Steps

History

cc @cqliu1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result Feature:Inspector Inspector infrastructure and implementations impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:enhancement release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Inspector] Use tabs for view selection
4 participants