🌊 Streams: Move routing into wired object in the API #213121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
release_note:skip
flash1293
commented
Mar 4, 2025
| @@ -241,9 +241,6 @@ export async function syncUnwiredStreamDefinitionObjects({ | |||
| dataStream: IndicesDataStream; | |||
| definition: UnwiredStreamDefinition; | |||
| }) { | |||
| if (definition.ingest.routing.length) { | |||
There was a problem hiding this comment.
ℹ️ Not necessary anymore since zod will do this validation for us
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we decided we don't want to provide routing for classic streams, it doesn't make sense to be on the level of the ingest stream in the API. This PR moves routing next to fields to make clear that it's only supported for wired streams.