Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [embeddable] replace Embeddable ViewMode with presentation-publishing ViewMode (#211960) #213135

Merged
merged 5 commits into from
Mar 5, 2025
Merged

[8.x] [embeddable] replace Embeddable ViewMode with presentation-publishing ViewMode (#211960) #213135

merged 5 commits into from
Mar 5, 2025

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 4, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@nreese
[embeddable] replace Embeddable ViewMode with presentation-publishing…
1279454 
… ViewMode (elastic#211960)

Embeddable ViewMode is part of legacy embeddable architecture. This PR
removes Embeddable ViewMode and replaces its usage with
presentation-publishing ViewMode. presentation-publishing ViewMode is a
string literal type so an enum is no longer needed.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit b213eb6)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/dashboards/components/dashboard_tool_bar.tsx
@nreese nreese requested a review from kibanamachine as a code owner March 4, 2025 16:19
@nreese nreese added the backport label Mar 4, 2025
@nreese nreese enabled auto-merge (squash) March 4, 2025 16:19
@botelastic botelastic bot added Feature:Embedding Embedding content via iFrame Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Mar 4, 2025
@nreese nreese mentioned this pull request Mar 4, 2025
Merged
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

nreese and others added 3 commits March 4, 2025 10:19
@nreese @jennypavlova
Update x-pack/solutions/observability/plugins/infra/public/alerting/l…
f3b5641 
…og_threshold/components/alert_details_app_section/components/threhsold_chart/log_threshold_count_chart.tsx

Co-authored-by: jennypavlova <jennypavlova94@gmail.com>
@nreese @jennypavlova
Update x-pack/solutions/observability/plugins/infra/public/alerting/l…
e4b5f67 
…og_threshold/components/alert_details_app_section/components/threhsold_chart/log_threshold_ratio_chart.tsx

Co-authored-by: jennypavlova <jennypavlova94@gmail.com>
@nreese @jennypavlova
Update x-pack/solutions/observability/plugins/infra/public/components…
090fce0 
…/lens/lens_wrapper.tsx

Co-authored-by: jennypavlova <jennypavlova94@gmail.com>
@nreese
Copy link
Contributor Author

nreese commented Mar 4, 2025

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 4, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #17 / Unenroll agent from fleet changing when agent tamper protection is enabled but then is switched to a policy with it disabled "before each" hook for "should unenroll from fleet without issues" "before each" hook for "should unenroll from fleet without issues"
  • [job] [logs] Defend Workflows Cypress Tests #13 / Unenroll agent from fleet with agent tamper protection is disabled "before each" hook for "should unenroll from fleet without issues" "before each" hook for "should unenroll from fleet without issues"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 84 83 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 138 136 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.5MB 2.5MB -42.0B
controls 465.5KB 465.4KB -30.0B
datasetQuality 240.8KB 240.8KB -19.0B
discover 796.2KB 796.2KB -19.0B
exploratoryView 154.2KB 154.2KB -21.0B
infra 1.5MB 1.5MB -77.0B
maps 3.1MB 3.1MB -18.0B
ml 5.2MB 5.2MB -78.0B
securitySolution 9.1MB 9.1MB -163.0B
slo 758.8KB 758.8KB -19.0B
triggersActionsUi 1.5MB 1.5MB -55.0B
unifiedHistogram 63.3KB 63.2KB -34.0B
ux 162.7KB 162.6KB -21.0B
visualizations 347.7KB 347.7KB -38.0B
total -634.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
datasetQuality 20.0KB 19.8KB -139.0B
discover 45.8KB 45.6KB -139.0B
discoverEnhanced 7.5KB 7.5KB -9.0B
embeddable 21.1KB 20.9KB -205.0B
exploratoryView 40.3KB 40.2KB -139.0B
inputControlVis 8.6KB 8.6KB -9.0B
reporting 50.3KB 50.3KB -9.0B
securitySolution 83.5KB 83.4KB -140.0B
triggersActionsUi 110.6KB 110.5KB -139.0B
unifiedHistogram 10.3KB 10.2KB -138.0B
ux 7.4KB 7.3KB -139.0B
visualizations 35.4KB 35.2KB -139.0B
total -1.3KB
Unknown metric groups

API count

id before after diff
embeddable 165 163 -2

History

@nreese
Copy link
Contributor Author

nreese commented Mar 4, 2025

@elasticmachine merge upstream

@nreese nreese merged commit 93aada0 into elastic:8.x Mar 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennypavlova jennypavlova jennypavlova approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport Feature:Embedding Embedding content via iFrame Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nreese @elasticmachine @jennypavlova