Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps] stop skipping .gen-ai and .inference connectors in schema integration test #213146

Open
pmuellr opened this issue Mar 4, 2025 · 1 comment
Labels
Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@pmuellr
Copy link
Member

pmuellr commented Mar 4, 2025

We just reviewed a .gen-ai PR which touched some ResponseOps code, but I was surprised the integration test we have to detect schema changes didn't get flagged.

Checking the code, I see we are skipping it:

for (const connectorTypeId of connectorTypes) {
const skipConnectorType = ['.gen-ai', '.inference'];
if (skipConnectorType.includes(connectorTypeId)) {
continue;
}

I believe this was in place BEFORE the gen-ai connectors started getting used as alerting actions. When it was a "live" and not "queued", the schema changes wouldn't cause BWC / ZDT issues. But as actions they can. So we should remove this check.

cc: @stephmilovic

@pmuellr pmuellr added Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 4, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

No branches or pull requests

2 participants