Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controls] Korean characters split into 2 characters with space in between when typing in options list search input #213150

Closed
nreese opened this issue Mar 4, 2025 · 2 comments · Fixed by #213164
Closed

[controls] Korean characters split into 2 characters with space in between when typing in options list search input #213150

nreese opened this issue Mar 4, 2025 · 2 comments · Fixed by #213164
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.16.0 v8.17.0

Comments

@nreese
Copy link
Contributor

nreese commented Mar 4, 2025 •
edited
Loading

Steps

  • Follow https://www.youtube.com/watch?v=vjulSf3Kwu4 to setup duel language inputs with English and Korean.
  • Create a dashboard with an options list. Switch to Korean input and type in option list control. Type the characters d and k on an english keyboard.
  • Notice how the characters are seperated by a space. Instead this should be a single character.
    Image

Cause

The value of the EuiFieldSearch is provided by useBatchedPublishingSubjects. useBatchedPublishingSubjects converts RXJS observables into react state via useState. useBatchedPublishingSubjects contains a debounceTime(0). This debounceTime somehow prevents the input from keeping characters as a single character. Thanks @tkajtoch for figuring this out.
@nreese nreese added the bug Fixes for quality problems that affect the customer experience label Mar 4, 2025
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 4, 2025
@nreese nreese added regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed needs-team Issues missing a team label labels Mar 4, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nickpeihl
Copy link
Member

I wonder if we need to listen to CompositionEvents? https://developer.mozilla.org/en-US/docs/Web/API/Element/compositionstart_event

@nreese nreese self-assigned this Mar 4, 2025
@nreese nreese mentioned this issue Mar 4, 2025
Merged
@nreese nreese closed this as completed in 3ce9019 Mar 4, 2025
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Mar 4, 2025
@nreese
[controls] fix Korean characters split into 2 characters with space i…
b843a40 
…n between when typing in options list search input (elastic#213164)

Closes elastic#213150

Test steps
* Follow https://www.youtube.com/watch?v=vjulSf3Kwu4 to setup duel
language inputs with English and Korean.
* Create a dashboard with an options list. Switch to Korean input and
type in option list control. Type the characters `d` and `k` on an
english keyboard.
* Ensure input treats value as a single character.
<img width="591" alt="Screenshot 2025-03-04 at 1 52 14 PM"
src="https://github.com/user-attachments/assets/c7cfe0f5-156d-4949-932a-96067bf20fd6"
/>

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3ce9019)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Mar 4, 2025
@nreese
[controls] fix Korean characters split into 2 characters with space i…
a77a5a3 
…n between when typing in options list search input (elastic#213164)

Closes elastic#213150

Test steps
* Follow https://www.youtube.com/watch?v=vjulSf3Kwu4 to setup duel
language inputs with English and Korean.
* Create a dashboard with an options list. Switch to Korean input and
type in option list control. Type the characters `d` and `k` on an
english keyboard.
* Ensure input treats value as a single character.
<img width="591" alt="Screenshot 2025-03-04 at 1 52 14 PM"
src="https://github.com/user-attachments/assets/c7cfe0f5-156d-4949-932a-96067bf20fd6"
/>

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3ce9019)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Mar 4, 2025
@nreese
[controls] fix Korean characters split into 2 characters with space i…
e1f1ca9 
…n between when typing in options list search input (elastic#213164)

Closes elastic#213150

Test steps
* Follow https://www.youtube.com/watch?v=vjulSf3Kwu4 to setup duel
language inputs with English and Korean.
* Create a dashboard with an options list. Switch to Korean input and
type in option list control. Type the characters `d` and `k` on an
english keyboard.
* Ensure input treats value as a single character.
<img width="591" alt="Screenshot 2025-03-04 at 1 52 14 PM"
src="https://github.com/user-attachments/assets/c7cfe0f5-156d-4949-932a-96067bf20fd6"
/>

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3ce9019)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Mar 4, 2025
@nreese
[controls] fix Korean characters split into 2 characters with space i…
c56be40 
…n between when typing in options list search input (elastic#213164)

Closes elastic#213150

Test steps
* Follow https://www.youtube.com/watch?v=vjulSf3Kwu4 to setup duel
language inputs with English and Korean.
* Create a dashboard with an options list. Switch to Korean input and
type in option list control. Type the characters `d` and `k` on an
english keyboard.
* Ensure input treats value as a single character.
<img width="591" alt="Screenshot 2025-03-04 at 1 52 14 PM"
src="https://github.com/user-attachments/assets/c7cfe0f5-156d-4949-932a-96067bf20fd6"
/>

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3ce9019)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Mar 4, 2025
@nreese
[controls] fix Korean characters split into 2 characters with space i…
2ff545c 
…n between when typing in options list search input (elastic#213164)

Closes elastic#213150

Test steps
* Follow https://www.youtube.com/watch?v=vjulSf3Kwu4 to setup duel
language inputs with English and Korean.
* Create a dashboard with an options list. Switch to Korean input and
type in option list control. Type the characters `d` and `k` on an
english keyboard.
* Ensure input treats value as a single character.
<img width="591" alt="Screenshot 2025-03-04 at 1 52 14 PM"
src="https://github.com/user-attachments/assets/c7cfe0f5-156d-4949-932a-96067bf20fd6"
/>

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3ce9019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.16.0 v8.17.0
Projects
None yet
Milestone
No milestone
3 participants
@nreese @nickpeihl @elasticmachine