Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Add alert details action button !! #213195

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Mar 5, 2025

Summary

Add alert details action button !!

if you have opened up the flyout, reason action button gets hidden.

Also fixed dark theme issues for the chart !!

image

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.3MB 1.3MB +405.0B

@shahzad31 shahzad31 marked this pull request as ready for review March 5, 2025 13:21
@shahzad31 shahzad31 requested a review from a team as a code owner March 5, 2025 13:21
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Mar 5, 2025
@benakansara
Copy link
Contributor

@shahzad31 we had previously discussed to bring "Alert details" link from under "..." to outside and keep it next to "View in app" link (slack), as it is a bit hidden right now. What do you think about changing the action button from opening alert flyout to redirecting to alert details page?

@shahzad31
Copy link
Contributor Author

@shahzad31 we had previously discussed to bring "Alert details" link from under "..." to outside and keep it next to "View in app" link (slack), as it is a bit hidden right now. What do you think about changing the action button from opening alert flyout to redirecting to alert details page?

well from flyout user can already go to the details page. i think we should try to bring more stuff into flyout to make it useful, that's the plan so i think we should keep it to open flyout

Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Mar 5, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@shahzad31 shahzad31 merged commit 8f7f5ff into elastic:main Mar 6, 2025
15 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13693070061

@shahzad31 shahzad31 deleted the add-alert-details-button branch March 6, 2025 07:03
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 213195

Questions ?

Please refer to the Backport tool documentation

@shahzad31 shahzad31 removed the backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) label Mar 6, 2025
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants