Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover][Profiles] Add profileId for document profiles in telemetry context for relevant events #213222

Open
iblancof opened this issue Mar 5, 2025 · 1 comment
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@iblancof
Copy link
Contributor

iblancof commented Mar 5, 2025

Summary

Background
With the introduction of profiles in Discover, the discoverProfiles attribute was added to the telemetry context to include the profileId for active Data Source Profiles.

While working on the Document Profile implementation, I noticed that the profileId is not included in the discoverProfiles attribute for document profiles in the event context.

Why?
As explained by @jughosta, it wasn't implemented because multiple document profiles can be resolved on the same page depending on the data in the rows. Adding them to the discoverProfiles attribute on load (as is done for data source profiles) wouldn't clarify which profile was actually in action at the time of the event.

Goal
The goal of this issue is to add the profileId for document profiles when relevant. This may involve manually adding the event context in specific cases when using the ebtManager.

For example, when calling onAddFilter from the flyout, we could pass the context for that specific event optionally, making sure it doesn't unintentionally carry over to other events.

@iblancof iblancof added Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Mar 5, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

3 participants