[9.0] [scout] fix playwright configs discovery script and add save flag for CI (#213147)
#213242
+107
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or CI (elastic#213147) ## Summary This PR fixes the search logic to look for playwright configs in all possible & expected locations (`src/*` was not working), matching one of 3 regexp: ``` /(x-pack\/platform\/plugins\/(?:private|shared|[^\/]+)\/([^\/]+))\/ui_tests\//, /(x-pack\/solutions\/[^\/]+\/plugins\/([^\/]+))\/ui_tests\//, /(src\/platform\/plugins\/(?:private|shared)?\/?([^\/]+))\/ui_tests\//, ``` For each plugin we also have `usesParallelWorkers` prop (`true` if at least 1 config runs with concurrent workers) to decide later, if we need worker with 4 or 8 VCPUs. The idea is to run `node scripts/scout discover-playwright-configs --save` on CI and use generated json as source to build test run pipeline. Current output: ``` { "discover_enhanced": { "group": "platform", "pluginPath": "x-pack/platform/plugins/private/discover_enhanced", "configs": [ "x-pack/platform/plugins/private/discover_enhanced/ui_tests/parallel.playwright.config.ts", "x-pack/platform/plugins/private/discover_enhanced/ui_tests/playwright.config.ts" ], "usesParallelWorkers": true }, "maps": { "group": "platform", "pluginPath": "x-pack/platform/plugins/shared/maps", "configs": [ "x-pack/platform/plugins/shared/maps/ui_tests/playwright.config.ts" ], "usesParallelWorkers": false }, "observability_onboarding": { "group": "observability", "pluginPath": "x-pack/solutions/observability/plugins/observability_onboarding", "configs": [ "x-pack/solutions/observability/plugins/observability_onboarding/ui_tests/parallel.playwright.config.ts", "x-pack/solutions/observability/plugins/observability_onboarding/ui_tests/playwright.config.ts" ], "usesParallelWorkers": true } } ``` (cherry picked from commit 1e3bb05)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]
cc @dmlemeshko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:saveflag for CI (#213147)Questions ?
Please refer to the Backport tool documentation