Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [dashboard] remove folder src/platform/plugins/shared/dashboard/public/dashboard_container (#212587) #213264

Merged
merged 2 commits into from
Mar 5, 2025
Merged

[8.x] [dashboard] remove folder src/platform/plugins/shared/dashboard/public/dashboard_container (#212587) #213264

merged 2 commits into from
Mar 5, 2025
+174 −213

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 5, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@nreese
[dashboard] remove folder src/platform/plugins/shared/dashboard/publi…
5c2f213 
…c/dashboard_container (elastic#212587)

PR removes `dashboard_container` and adds `dashboard_renderer` folder. I
tried to find a best fit for files but have no strong opinions about
where I put things. Please comment if you would like files in different
locations.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit f66fa68)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/dashboards/components/dashboard_tool_bar.tsx
@nreese nreese requested a review from kibanamachine as a code owner March 5, 2025 16:12
@nreese nreese added the backport label Mar 5, 2025
@nreese nreese enabled auto-merge (squash) March 5, 2025 16:12
@nreese nreese mentioned this pull request Mar 5, 2025
Merged
@nreese
Copy link
Contributor Author

nreese commented Mar 5, 2025

/ci

1 similar comment
@nreese
Copy link
Contributor Author

nreese commented Mar 5, 2025

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 5, 2025

@elasticmachine merge upstream

@nreese nreese merged commit c9b092d into elastic:8.x Mar 5, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #12 / dashboard app - esql controls dashboard - add a value type ES|QL control should handle properly a query to retrieve the values that return more than one column

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 666 665 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dashboard 90 99 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 592.6KB 592.5KB -116.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 17.5KB 17.4KB -11.0B
Unknown metric groups

API count

id before after diff
dashboard 93 102 +9

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nreese @elasticmachine @ThomThomson