[Fleet] Fetch only relevant assets for package policies operation #213267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
nchaulet
commented
Mar 5, 2025
| @@ -126,6 +126,8 @@ export type InstallablePackage = RegistryPackage | ArchivePackage; | |||
|
|
|||
| export type AssetsMap = Map<string, Buffer | undefined>; | |||
|
|
|||
| export type PackagePolicyAssetsMap = AssetsMap & { __brand: 'PackagePolicyAssetsMap' }; | |||
There was a problem hiding this comment.
use type branding to make sure AssetsMap is not used as a PackagePolicyAssetsMap by error
nchaulet
commented
Mar 5, 2025
| @@ -17,12 +17,15 @@ const cacheStore = new AsyncLocalStorage<CacheSession>(); | |||
|
|
|||
| const PACKAGE_INFO_CACHE_SIZE = 20; | |||
| const PACKAGE_ASSETS_MAP_CACHE_SIZE = 1; | |||
| const AGENT_TEMPLATE_ASSETS_MAP_CACHE_SIZE = 5; | |||
There was a problem hiding this comment.
We can cache more than package assets map as it only contains agent template and manifest, and not all ES|kibana assets like PACKAGE_ASSETS_MAP_CACHE_SIZE
nchaulet
force-pushed
the
feature-package-assets-map
branch
from
0a4948a to
615a7af
Compare
nchaulet
force-pushed
the
feature-package-assets-map
branch
from
615a7af to
748a6e2
Compare
|
Pinging @elastic/fleet (Team:Fleet) |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
History
cc @nchaulet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #205332
That PR change the way we fetch assets, it now fetch only relevant assets for package policies operations instead of the whole assets maps (manifest and agents template).
Saved object change
To be able to filter assets we load I now store the path in
package_assetsarray store on the package saved objectBenchmark
Upgrade dry run on 5 aws policies
Before
After
Upgrade 10 packages policies (without agent policy as there are need to improve the package policy too in a next PR)
Before
Kibana memory usage at the same time
After
TODO