Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Attack discovery] Fixes animated counter styling for pre-Borealis (8.x) themes #213279

Open
wants to merge 2 commits into
base: 8.x
Choose a base branch
from
Open

[Security Solution] [Attack discovery] Fixes animated counter styling for pre-Borealis (8.x) themes #213279

wants to merge 2 commits into from
+5 −4

Conversation

andrew-goldstein
Copy link
Contributor

[Security Solution] [Attack discovery] Fixes animated counter styling for pre-Borealis (8.x) themes

This PR, which targets the 8.x branch directly, fixes an animated counter styling issue in pre-Borealis (8.x) themes, as reported in #213225

Image

Details

Styling in the main (9.x) branch, which features the new Borealis theme, has diverged from styling in the 8.x branch.

This PR, targets the 8.x branch directly to restore the pre-Borealis styling, as illustrated by the before / after screenshots below:

Before

before

After

after

@andrew-goldstein
### [Security Solution] [Attack discovery] Fixes animated counter sty…
3c74009 
…ling for pre-Borealis (8.x) themes

This PR, which targets the `8.x` branch directly, fixes an animated counter styling issue in pre-Borealis (8.x) themes, as reported in <elastic#213225>

![Image](https://github.com/user-attachments/assets/a27751e4-9a1f-4cda-a3ab-a2b62ea66a41)

#### Details

Styling in the `main` (9.x) branch, which features the new `Borealis` theme, has diverged from styling in the `8.x` branch.

This PR, targets the `8.x` branch directly to restore the pre-Borealis styling, as illustrated by the before / after screenshots below:

**Before**

![before](https://github.com/user-attachments/assets/2ae4a1cb-a4d8-49e0-a9b3-36ed99562888)

**After**

![after](https://github.com/user-attachments/assets/118a9aef-432b-471d-a81d-3f7d657b8d11)
@andrew-goldstein andrew-goldstein added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI backport:version Backport to applied version labels v8.18.0 v8.19.0 v8.18.1 labels Mar 5, 2025
@andrew-goldstein andrew-goldstein self-assigned this Mar 5, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@andrew-goldstein
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #4 / dashboard app - esql controls dashboard - add a value type ES|QL control should handle properly a query to retrieve the values that return more than one column
  • [job] [logs] FTR Configs #83 / discover/context_awareness extension getAdditionalCellActions data view mode should render additional cell actions for logs data source

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB -2.0B

History

cc @andrew-goldstein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees

@andrew-goldstein andrew-goldstein

Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v8.18.1 v8.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrew-goldstein @elasticmachine @spong