Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Synthetics] Fix overview error popover !! (#211431) #213328

Merged
merged 3 commits into from
Mar 6, 2025
Merged

[8.x] [Synthetics] Fix overview error popover !! (#211431) #213328

merged 3 commits into from
Mar 6, 2025
+235 −101

Conversation

shahzad31
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@shahzad31
[Synthetics] Fix overview error popover !! (elastic#211431)
049b9bb 
## Summary

Fix overview error popover !!

Pings aren't being returned as part of overview data anymore, so had to
add redux actions to fetch it separately via an existing API

Fixes elastic#211745

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/2244948f-e42d-443d-b6e7-42e0a72b1bfa"
/>

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Justin Kambic <jk@elastic.co>
(cherry picked from commit aaf73ff)

# Conflicts:
#	x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/monitors_page/overview/overview/metric_item/metric_item.tsx
@shahzad31 shahzad31 requested a review from kibanamachine as a code owner March 6, 2025 08:59
@shahzad31 shahzad31 enabled auto-merge (squash) March 6, 2025 08:59
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Mar 6, 2025
@shahzad31 shahzad31 mentioned this pull request Mar 6, 2025
Merged
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 6, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

@shahzad31 shahzad31 merged commit 9b4b568 into elastic:8.x Mar 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkanout fkanout fkanout approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahzad31 @elasticmachine @fkanout @kibanamachine