Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Proposal: Merge error sample and trace summary into a single component #213436

Open
jennypavlova opened this issue Mar 6, 2025 · 1 comment
Labels
discuss good first issue low hanging fruit low Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@jennypavlova
Copy link
Member

Trace summary and error sample summary look super similar, and they could be merged into a single component.
As a background, we had 2 bugs related to those because of missing fields coming from the queries: if it was a single component, we wouldn't have prevented the bug from happening, but we could have found all usages and would have been easier to fix all places as now they are completely separate. Ref: #213430 and #206932

👍 :

  • Easier to test
  • Less repeating code
  • Easier to maintain
  • Easier to find similar issues to the above

👎 :

  • Harder to customize and have different data
  • Changes will affect both places (which can be 👍 and 👎 )
  • They are different summaries based on the context, so it might create confusion - good naming is required

⚠ This is just a proposal open for discussion

@jennypavlova jennypavlova added discuss good first issue low hanging fruit low Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture labels Mar 6, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss good first issue low hanging fruit low Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

2 participants