Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] map center change shows unsaved change after clicking reset #213444

Closed
nreese opened this issue Mar 6, 2025 · 1 comment · Fixed by #213445
Closed

[dashboard] map center change shows unsaved change after clicking reset #213444

nreese opened this issue Mar 6, 2025 · 1 comment · Fixed by #213445
Labels
bug Fixes for quality problems that affect the customer experience regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Mar 6, 2025

Steps

  • create dashboard with map panel and globe projection with globe visible
  • save dashboard
  • move map center
  • click reset, notice how unsaved changes panel remains
@nreese nreese added the bug Fixes for quality problems that affect the customer experience label Mar 6, 2025
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 6, 2025
@nreese nreese added regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed needs-team Issues missing a team label labels Mar 6, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese mentioned this issue Mar 6, 2025
Merged
nreese added a commit that referenced this issue Mar 7, 2025
@nreese @kibanamachine @elasticmachine
[dashboard] fix map center change shows unsaved change after clicking…
ea266bc 
… reset (#213445)

Closes #213444

The problem is setting the view with the globe view may not set the view
to the exact value. For example setting zoom to 1.74 may move the map to
zoom 1.77. PR resolves this problem by adding a margin of error for
comparing zoom differences.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Mar 7, 2025
@nreese
[dashboard] fix map center change shows unsaved change after clicking…
3d45f1b 
… reset (elastic#213445)

Closes elastic#213444

The problem is setting the view with the globe view may not set the view
to the exact value. For example setting zoom to 1.74 may move the map to
zoom 1.77. PR resolves this problem by adding a margin of error for
comparing zoom differences.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit ea266bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dashboard] fix map center change shows unsaved change after clicking reset nreese/kibana
2 participants
@nreese @elasticmachine