-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs Onboarding] Added api integration tests #160165
Merged
yngrdyn
merged 9 commits into
elastic:main
from
yngrdyn:159451-logs-onboarding-custom-logs-api-tests
Jun 26, 2023
Merged
[Logs Onboarding] Added api integration tests #160165
yngrdyn
merged 9 commits into
elastic:main
from
yngrdyn:159451-logs-onboarding-custom-logs-api-tests
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-custom-logs-api-tests
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Ikuni17
approved these changes
Jun 21, 2023
sorenlouv
reviewed
Jun 22, 2023
x-pack/test/observability_onboarding_api_integration/tests/custom_logs/privileges.spec.ts
Outdated
Show resolved
Hide resolved
sorenlouv
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of boilerplate but I suppose that's unavoidable when starting from scratch.
Tests look good, thanks!
95009d8
to
e7b03cd
Compare
e5a2436
to
f7f691e
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
v8.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #159451.
This PR adds api integration tests to: