Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Onboarding] Added api integration tests #160165

Merged

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Jun 21, 2023

Relates to #159451.

This PR adds api integration tests to:

  • GET /internal/observability_onboarding/custom_logs/privileges
  • GET /internal/observability_onboarding/custom_logs/install_shipper_setup
  • POST /internal/observability_onboarding/custom_logs/save

@yngrdyn yngrdyn requested review from a team as code owners June 21, 2023 15:50
@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Jun 21, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of boilerplate but I suppose that's unavoidable when starting from scratch.
Tests look good, thanks!

@yngrdyn yngrdyn force-pushed the 159451-logs-onboarding-custom-logs-api-tests branch from 95009d8 to e7b03cd Compare June 26, 2023 08:50
@yngrdyn yngrdyn force-pushed the 159451-logs-onboarding-custom-logs-api-tests branch from e5a2436 to f7f691e Compare June 26, 2023 09:37
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
observabilityOnboarding 3 5 +2

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
observabilityOnboarding 12 14 +2
securitySolution 497 501 +4
total +8

History

  • 💔 Build #137988 failed e5a243669d52156cc4dfc549c33e39c7f82471d4
  • 💚 Build #137007 succeeded 95009d8cd596cab94b100a22b684b4678a157429

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yngrdyn yngrdyn merged commit 39ddf4d into elastic:main Jun 26, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants