Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs onboarding] Align elastic-agent version with stackVersion #162622

Merged
merged 6 commits into from
Jul 27, 2023
Merged

[Logs onboarding] Align elastic-agent version with stackVersion #162622

merged 6 commits into from
Jul 27, 2023

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Jul 27, 2023 •
edited
Loading

Closes #159382.

Changes

  • kibanaVersion is passed as a resources to the routes.
  • elastic-agent version is based on kibanaVersion.

Before

image

After

image

@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Jul 27, 2023
@yngrdyn yngrdyn requested a review from a team as a code owner July 27, 2023 11:10
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

achyutjhunjhunwala
achyutjhunjhunwala approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ogupte
ogupte approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yngrdyn yngrdyn merged commit 11e56ec into elastic:main Jul 27, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 27, 2023
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
@yngrdyn
[Logs onboarding] Align elastic-agent version with stackVersion (elas…
f417511 
…tic#162622)

Closes elastic#159382.

### Changes
- `kibanaVersion` is passed as a resources to the routes.
- `elastic-agent` version is based on `kibanaVersion`.

#### Before
<img width="1073" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/00e291a2-3f8d-4d1d-9520-c0a29cc9454e">

#### After
<img width="1115" alt="image"
src="https://github.com/elastic/kibana/assets/1313018/dffcf95f-f3a2-46f0-bb78-daebe8597b89">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

@achyutjhunjhunwala achyutjhunjhunwala achyutjhunjhunwala approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs onboarding] Elastic agent download url
6 participants
@yngrdyn @apmmachine @kibana-ci @ogupte @achyutjhunjhunwala @kibanamachine