Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Adds unit tests for simple diff algorithm #184483

Merged
merged 2 commits into from
May 31, 2024
Merged

[Security Solution] Adds unit tests for simple diff algorithm #184483

merged 2 commits into from
May 31, 2024

Conversation

dplumlee
Copy link
Contributor

@dplumlee dplumlee commented May 29, 2024 •
edited
Loading

Summary

Adds unit tests in accordance to #180158

Abstracts the simpleDiffAlgorithm function used in the prebuilt rule upgrade workflow into singleLineStringDiffAlgorithm and numberDiffAlgorithm and adds unit tests for both cases

Addresses the following test cases defined in the related RFC section table

  • AAA
  • ABA
  • AAB
  • ABB
  • ABC
  • -AA
  • -AB

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee added test release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area v8.15.0 labels May 29, 2024
@dplumlee dplumlee self-assigned this May 29, 2024
@dplumlee dplumlee requested a review from a team as a code owner May 29, 2024 23:12
@dplumlee dplumlee requested a review from xcrzx May 29, 2024 23:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@dplumlee dplumlee mentioned this pull request May 29, 2024
Closed
8 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dplumlee

@dplumlee dplumlee mentioned this pull request May 30, 2024
Closed
8 tasks
xcrzx
xcrzx approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@xcrzx xcrzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you, @dplumlee!

@dplumlee dplumlee merged commit 06fc22a into elastic:main May 31, 2024
35 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 31, 2024
@dplumlee dplumlee deleted the single-line-field-diff-unit-tests branch May 31, 2024 14:51
@banderror
Copy link
Contributor

Just checked the PR -- looks very good, thank you @dplumlee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcrzx xcrzx xcrzx approved these changes

Assignees

@dplumlee dplumlee

Labels
backport:skip This commit does not require backporting Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dplumlee @elasticmachine @kibana-ci @banderror @xcrzx @kibanamachine