-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Integrating the editor with the time picker #187047
Conversation
Pinging @elastic/kibana-esql (Team:ESQL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited for this feature! Looks like we have a bug where the timepicker text gets inserted.
Screen.Recording.2024-07-23.at.12.39.41.PM.mov
packages/kbn-text-based-editor/src/text_based_languages_editor.tsx
Outdated
Show resolved
Hide resolved
@drewdaemon thanx for the bug, great find. I did this change without testing it. I wanted to fix the autocomplete tests so I added a text |
I see the problem. There's no amazing answer. The tests currently only support checking the |
I created an issue and linked it in the description of this PR. In part, to track the work but also to, later, link this to a potential badge menu. It wouldn't be easy; just want to capture the idea in a light way. |
Much appreciated @drewdaemon. Looks awesome, also created a tech debt issue here #189029 |
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Part of #189010
Summary
It displays the date picker for date fields. It is currently only possible for where and eval commands (and not in stats bucker) exactly as the earliest and latest params mostly because the bucket command is not well defined and we need to fix the autocomplete first before we integrate the latest / earliest params and the timepicker
Checklist