Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][ML] Left navigation updates #204290

Draft
wants to merge 50 commits into
base: main
Choose a base branch
from
Draft

[WIP][ML] Left navigation updates #204290

wants to merge 50 commits into from

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Dec 13, 2024 •
edited
Loading

Summary

Note: this is a WIP. Pushed this branch to ensure work is backed up as this PR will grow over the course of a few weeks.

This PR will include all updates to ML navigation for phase 1.
This includes reducing the left nav items within the Machine Learning plugin and creating a Machine Learning section within Stack Management to move some of those items into.

Stack management for classic/observability/security:
Image

Stack management for search:
Image

ML app Classic:
- note: The overview item will need a redesign as a new landing page
Image

ML app Observability/Security:
Image Image

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@alvarezmelissa87 alvarezmelissa87 self-assigned this Dec 13, 2024
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-nav-updates branch 4 times, most recently from 9f46c98 to 41320e3 Compare December 19, 2024 17:51
@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-nav-updates branch 2 times, most recently from c12e467 to 18a27ba Compare December 23, 2024 23:45
@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-nav-updates branch 4 times, most recently from 12529c1 to b7c58a6 Compare December 30, 2024 22:39
peteharverson
peteharverson reviewed Jan 6, 2025
View reviewed changes
src/platform/plugins/shared/management/public/components/management_sections.tsx Outdated
});

const machineLearningTip = i18n.translate('management.sections.machineLearningTip', {
defaultMessage: 'Manage the detection of anomalies in your data',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe something like Manage your machine learning jobs and trained models.

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-nav-updates branch 4 times, most recently from 062d31f to 81451e2 Compare January 10, 2025 23:04
@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-nav-updates branch 3 times, most recently from 714e506 to 9999c68 Compare January 16, 2025 17:21
@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-nav-updates branch 2 times, most recently from d2388cf to e18252e Compare January 22, 2025 18:39
@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

peteharverson
peteharverson reviewed Feb 13, 2025
View reviewed changes
...form/plugins/shared/ml/public/application/overview/components/anomaly_detection_overview.tsx Outdated
>
<FormattedMessage
id="xpack.ml.overview.anomalyDetection.multiMetricExplorerButtonText"
defaultMessage="Multi-metric explorer"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should say 'Anomaly Explorer' as I think we decided not to change the page name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here 35d2e68 (#204290)

@qn895
Copy link
Member

qn895 commented Feb 13, 2025 •
edited
Loading

Latests commits have the following changes:

  • Old bookmarked links now redirect automatically to the corresponding management pages:
Screen.Recording.2025-02-13.at.17.31.55.mov
  • + Create job buttons are added to Single metric viewer, Anomaly explorer, and Data frame analytics result explorers
Screen.Recording.2025-02-13.at.17.31.10.mov
Screenshot 2025-02-13 at 17 29 37 Screenshot 2025-02-13 at 17 29 33
  • Fixed and updated Typescript and i18n

@qn895
Copy link
Member

qn895 commented Feb 19, 2025

Latest changes (as of 0306e83) now include fixing some broken links and redirecting to the new management pages:

Redirecting:

  • /app/ml/notifications - redirect to the new Management ML Overview page and select Notifications tab
Screen.Recording.2025-02-19.at.12.26.18.mov
  • /app/ml/memory_usage - redirect to the new Management ML Overview page
Screen.Recording.2025-02-19.at.12.27.04.mov
  • /app/ml/supplied_configurations - redirect to the new Management Supplied Configurations page
Screen.Recording.2025-02-19.at.12.28.05.mov
  • /app/ml/settings - redirect to the new Management Settings page
    • Calendar list | Create new calendar
    • DST Calendar list | Create new DST calendar
    • Filters list | Create new filter
Screen.Recording.2025-02-19.at.12.28.26.mov
Screen.Recording.2025-02-19.at.12.30.38.mov

Broken links:

  • Link to the advanced job wizard from the index data visualizer
  • Link to convert to the advanced job wizard from the multi-metric wizard
  • Link to the DFA job wizard from the index data visualizer
  • Link to the data recognizer job wizard from the index data visualizer
  • From the AD job wizards - Job details step - Additional settings - links to Manage calendars
  • From the AD job wizards - Advanced Jobs - Apply data view change
  • Kibana Home page - Sample data sets - View ML jobs

qn895 and others added 2 commits February 19, 2025 16:02
@qn895
Update links:
a769e88 
Observability - APM- Settings - Anomaly Detection - Manage jobs
Security - Rules - Detection rules - Create new rule - Select ML rule
@alvarezmelissa87
fix short_tests part 1
36e2af9
@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson left review comments

@qn895 qn895 qn895 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@alvarezmelissa87 alvarezmelissa87

@qn895 qn895

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alvarezmelissa87 @elasticmachine @qn895 @peteharverson