Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Default CSPM integration to use Agentless as the setup technology. #205965

Merged
merged 12 commits into from
Jan 15, 2025
Merged

[Cloud Security] Default CSPM integration to use Agentless as the setup technology. #205965

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7fc35eb
Defaulting to agentless placeholder
seanrathier Jan 7, 2025
3873b21
Defaulting to agentless placeholder
seanrathier Jan 7, 2025
7d37d7a
Fixed tests and opened up for Asset Inventory
seanrathier Jan 9, 2025
9d87fe8
fix tests
seanrathier Jan 9, 2025
d449e9a
refactored out useEffect from setup technology
seanrathier Jan 10, 2025
cad9ee2
Code review changes
seanrathier Jan 10, 2025
24b2ef3
Code review changes
seanrathier Jan 10, 2025
cff9382
Code review changes
seanrathier Jan 10, 2025
320a88d
Link to Fleet issue to implement the default agentless
seanrathier Jan 13, 2025
17bc540
removed useless if statement
seanrathier Jan 13, 2025
e936182
Merge branch 'main' into default-cspm-agentless
seanrathier Jan 13, 2025
0d9ac3b
Merge branch 'main' into default-cspm-agentless
seanrathier Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 72 additions & 13 deletions ...agent_policy/create_package_policy_page/single_page_layout/hooks/setup_technology.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,12 +246,11 @@ describe('useSetupTechnology', () => {
})
);

expect(generateNewAgentPolicyWithDefaults).toHaveBeenCalled();

act(() => {
result.current.handleSetupTechnologyChange(SetupTechnology.AGENTLESS);
});
await waitFor(() => {
expect(generateNewAgentPolicyWithDefaults).toHaveBeenCalled();
expect(updatePackagePolicyMock).toHaveBeenCalledWith({ supports_agentless: true });
expect(result.current.selectedSetupTechnology).toBe(SetupTechnology.AGENTLESS);
expect(setNewAgentPolicy).toHaveBeenCalledWith({
Expand Down Expand Up @@ -290,13 +289,12 @@ describe('useSetupTechnology', () => {
initialProps,
});

expect(generateNewAgentPolicyWithDefaults).toHaveBeenCalled();

act(() => {
result.current.handleSetupTechnologyChange(SetupTechnology.AGENTLESS);
});

expect(result.current.selectedSetupTechnology).toBe(SetupTechnology.AGENTLESS);
expect(generateNewAgentPolicyWithDefaults).toHaveBeenCalled();
expect(updatePackagePolicyMock).toHaveBeenCalledWith({ supports_agentless: true });
expect(setNewAgentPolicy).toHaveBeenCalledWith({
inactivity_timeout: 3600,
Expand Down Expand Up @@ -450,6 +448,7 @@ describe('useSetupTechnology', () => {
updateAgentPolicies: updateAgentPoliciesMock,
setSelectedPolicyTab: setSelectedPolicyTabMock,
packagePolicy: packagePolicyMock,
packageInfo: packageInfoMock,
updatePackagePolicy: updatePackagePolicyMock,
})
);
Expand All @@ -469,6 +468,11 @@ describe('useSetupTechnology', () => {
name: 'Agentless policy for endpoint-1',
supports_agentless: true,
inactivity_timeout: 3600,
global_data_tags: [
{ name: 'organization', value: 'org' },
{ name: 'division', value: 'div' },
{ name: 'team', value: 'team' },
],
});
expect(updatePackagePolicyMock).toHaveBeenCalledWith({ supports_agentless: true });
});
Expand Down Expand Up @@ -512,7 +516,7 @@ describe('useSetupTechnology', () => {
);

act(() => {
result.current.handleSetupTechnologyChange(SetupTechnology.AGENTLESS, 'cspm');
result.current.handleSetupTechnologyChange(SetupTechnology.AGENTLESS);
});

await waitFor(() => {
Expand Down Expand Up @@ -544,23 +548,48 @@ describe('useSetupTechnology', () => {
},
});

const packageInfoWithoutGlobalDataTags = {
policy_templates: [
{
name: 'cspm',
title: 'Template 1',
description: '',
deployment_modes: {
default: {
enabled: true,
},
agentless: {
enabled: true,
},
},
},
{
name: 'not-cspm',
title: 'Template 2',
description: '',
deployment_modes: {
default: {
enabled: true,
},
},
},
] as RegistryPolicyTemplate[],
} as PackageInfo;

const { result } = renderHook(() =>
useSetupTechnology({
setNewAgentPolicy,
newAgentPolicy: newAgentPolicyMock,
updateAgentPolicies: updateAgentPoliciesMock,
setSelectedPolicyTab: setSelectedPolicyTabMock,
packagePolicy: packagePolicyMock,
packageInfo: packageInfoMock,
packageInfo: packageInfoWithoutGlobalDataTags,
updatePackagePolicy: updatePackagePolicyMock,
})
);

act(() => {
result.current.handleSetupTechnologyChange(
SetupTechnology.AGENTLESS,
'never-gonna-give-you-up'
);
result.current.handleSetupTechnologyChange(SetupTechnology.AGENTLESS);
});

await waitFor(() => {
Expand Down Expand Up @@ -594,14 +623,42 @@ describe('useSetupTechnology', () => {
},
});

const packageInfoWithoutGlobalDataTags = {
policy_templates: [
{
name: 'cspm',
title: 'Template 1',
description: '',
deployment_modes: {
default: {
enabled: true,
},
agentless: {
enabled: true,
},
},
},
{
name: 'not-cspm',
title: 'Template 2',
description: '',
deployment_modes: {
default: {
enabled: true,
},
},
},
] as RegistryPolicyTemplate[],
} as PackageInfo;

const { result } = renderHook(() =>
useSetupTechnology({
setNewAgentPolicy,
newAgentPolicy: newAgentPolicyMock,
updateAgentPolicies: updateAgentPoliciesMock,
setSelectedPolicyTab: setSelectedPolicyTabMock,
packagePolicy: packagePolicyMock,
packageInfo: packageInfoMock,
packageInfo: packageInfoWithoutGlobalDataTags,
updatePackagePolicy: updatePackagePolicyMock,
})
);
Expand Down Expand Up @@ -653,7 +710,7 @@ describe('useSetupTechnology', () => {
);

act(() => {
result.current.handleSetupTechnologyChange(SetupTechnology.AGENTLESS, 'cspm');
result.current.handleSetupTechnologyChange(SetupTechnology.AGENTLESS);
});

await waitFor(() => {
Expand Down Expand Up @@ -700,10 +757,11 @@ describe('useSetupTechnology', () => {
);

act(() => {
result.current.handleSetupTechnologyChange(SetupTechnology.AGENTLESS, 'cspm');
result.current.handleSetupTechnologyChange(SetupTechnology.AGENTLESS);
});

await waitFor(() => {
expect(result.current.selectedSetupTechnology).toBe(SetupTechnology.AGENTLESS);
expect(setNewAgentPolicy).toHaveBeenCalledWith(
expect.objectContaining({
supports_agentless: true,
Expand All @@ -721,6 +779,7 @@ describe('useSetupTechnology', () => {
});

await waitFor(() => {
expect(result.current.selectedSetupTechnology).toBe(SetupTechnology.AGENT_BASED);
expect(setNewAgentPolicy).toHaveBeenCalledWith(newAgentPolicyMock);
expect(setNewAgentPolicy).not.toHaveBeenCalledWith({
global_data_tags: [
Expand Down
Loading