Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps] move redux-thunk to correct owners #206232

Merged
merged 3 commits into from
Mar 4, 2025
Merged

[deps] move redux-thunk to correct owners #206232

merged 3 commits into from
Mar 4, 2025
+3 −1

Conversation

markov00
Copy link
Member

Summary

The redux-thunk dependency was assigned to the kibana-visualization team but we are not even using it in our code.

The current PR proposes a change, moving the ownership/dependency review to @elastic/kibana-presentation, @elastic/kibana-management, and @elastic/security-solution because they are the main and only consumers of that library.

@markov00 markov00 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes dependencies Pull requests that update a dependency file backport:skip This commit does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jan 10, 2025
@markov00 markov00 requested review from legrego and a team January 10, 2025 09:18
legrego
legrego approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the error, and thanks for editing a fix - LGTM

@markov00 markov00 enabled auto-merge (squash) March 4, 2025 12:03
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

@markov00 markov00 merged commit 14b18ac into elastic:main Mar 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

@nickpeihl nickpeihl nickpeihl approved these changes

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting dependencies Pull requests that update a dependency file release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markov00 @elasticmachine @mattkime @nickpeihl @legrego @kibanamachine