[Observability AI Assistant] duplicate conversations #208044

arturoliduena · 2025-01-23T12:49:30Z

Closes #209382

Summary:

Duplicate Conversation

Readonly → Public conversations can only be modified by the owner.
Duplicated conversations are owned by the user who duplicates them.
Duplicated conversations are private by default public: false.

Screen.Recording.2025-02-12.at.15.19.11.mov

UPDATE:

Screen.Recording.2025-02-18.at.12.32.38.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

elasticmachine · 2025-01-23T12:49:32Z

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

...gins/shared/observability_solution/observability_ai_assistant/server/service/client/index.ts

...olutions/observability/plugins/observability_ai_assistant_app/server/rule_connector/index.ts

x-pack/platform/packages/shared/kbn-ai-assistant/src/hooks/use_conversation.ts

sorenlouv

@arturoliduena Is this PR ready for review?

arturoliduena · 2025-01-30T16:18:31Z

@arturoliduena Is this PR ready for review?

@sorenlouv I’ve marked this PR as draft because it was initially ready for review, but we’ve changed the approach. It’s now a WIP.

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_body.tsx

github-actions · 2025-02-09T23:40:57Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

viduni94

Hey @arturoliduena
I added some comments about the UI and some functionality.

Do we want to allow users to fork private conversations too?
Or should we only have this option for shared conversations?
(I can see the option is available for both private and shared conversations)

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_actions_menu.tsx

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_body.tsx

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_header.tsx

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_body.tsx

viduni94 · 2025-02-10T21:42:16Z

@arturoliduena
Could you update the screen recording in the PR description with the latest changes?
Thank you

arturoliduena · 2025-02-11T11:34:04Z

I added some comments about the UI and some functionality.

Do we want to allow users to fork private conversations too?
Or should we only have this option for shared conversations?
(I can see the option is available for both private and shared conversations)

Thank you @viduni94, I added that users can only fork shared conversations

arturoliduena · 2025-02-11T11:38:43Z

I see a few differences here from the Figma Design

The text seem larger here than Figma
The icon is not loading
Needs some spacing between the banner and the input
The banner color seems darker than Figma

I've added those fixes.
I am troubleshooting what happens with the plugs icon:

arturoliduena · 2025-02-11T13:11:02Z

@viduni94 @isaclfreire
The plugs icon is not available in Kibana yet.
The upgrade PR is still under review here. Once it’s merged, we should be able to use it.

In the meantime, I’ve temporarily replaced the plugs icon with the branch icon to avoid being blocked.

isaclfreire · 2025-02-11T15:51:39Z

Hello, here's my comments:

Users should be able to type a message in the input field to “continue the conversation” = automatically create a fork of the conversation - visibility of new conversation should be private by default - instead of hitting a dead end, and getting an error.
Users could be able to fork private conversations as well, but I would rather call it “Duplicate” instead. I’m not quite sure we really need to cross-link the new conversation to its original in this case, as they were initiated by the same person. Wdyt, @teknogeek0?
Please remove the “Fork this conversation” button from the callout message as it’s redundant, since the input field should be interactive and do the job.
I would also refrain from using the branch icon when we are speaking about the alert connector, as it can be misleading. Please, let’s use the bell icon instead for the time being.

Thanks everyone for the awesome work 👍

viduni94 · 2025-02-27T16:22:47Z

x-pack/platform/packages/shared/kbn-ai-assistant/src/hooks/use_conversation.ts

@@ -75,10 +84,6 @@ export function useConversation({
  const initialMessages = useOnce(initialMessagesFromProps);
  const initialTitle = useOnce(initialTitleFromProps);

-  if (initialMessages.length && initialConversationId) {
-    throw new Error('Cannot set initialMessages if initialConversationId is set');


Hmmm, I'm not sure whether we should remove this 🤔
Any thoughts @dgieselaar @sorenlouv ?

@arturoliduena
I know you might have removed this to fix https://github.com/elastic/kibana/pull/208044/files#r1971621797
But I'm not sure what other things might break if we remove this..

Let's wait to hear from Dario or Soren

Cz there's a specific test to cover this scenario too - https://github.com/elastic/kibana/pull/208044/files#diff-6ae996f673c49cb1e5b461807ab7f7689995b08ebacf84ba47824bdab46a231eL87
So I'm guessing this validation is important. I'm not 100% sure though

@viduni94, we don’t need to catch this error anymore, as there’s now a valid case for it, duplicating a conversation when the initial messages aren’t empty.

What this check was originally preventing is:

When a user starts a conversation with an initial message and then navigates to another conversation using a conversation ID, the previous conversation’s messages are lost. However, this only happens if the conversation was started from Contextual Insights, since those conversations are not persisted. If the user navigates away, the messages are lost, which is what this validation was trying to prevent.
In reality, though, users cannot navigate to another conversation in this scenario because the conversation list is hidden. I believe we should allow users to navigate freely (for another discussion) if they lose their messages, they can always start a new conversation from Contextual Insights again.
Additionally, when updating the title, a separate validation already handles this, so the title (pencil icon) cannot be edited when the conversation hasn’t been stored yet.

This change fixes the original bug while also removing unnecessary code.

To close this thread, as discussed during the dev sync.. instead of removing this check, consider resetting initial messages when navigating to a stored conversation with conversationId.

Done! Instead of removing the check, I’ve added a reset for initialMessages when duplicating the conversation.
We can open a new issue to enable the conversation list in the flyout for conversations opened from Contextual Insights and apply the same changes there.

We can open a new issue to enable the conversation list in the flyout

If you enable the conversation list and click on "New conversation" after initialMessages are set from contextual insights, does the initial messages get cleared?
(It might still be there, since the messages in use_chat is not cleared with the solution in this PR)

Unless you do the below when clicked on "New conversation" (to reset initial messages)

service.conversations.openNewConversation({ messages: [], });

But this will close and re-open the flyout.

neptunian · 2025-02-28T05:02:16Z

Hi @arturoliduena I'm trying to test this in the UI. Can you provide directions? I'm trying it locally, stateful, and have alerts but I don't see how to share them. Should I be able to share conversations not created by alerts, too?

I see you added some integration tests but having some functional UI tests would probably be good as well.

arturoliduena · 2025-02-28T10:59:06Z

Hi @arturoliduena I'm trying to test this in the UI. Can you provide directions? I'm trying it locally, stateful, and have alerts but I don't see how to share them. Should I be able to share conversations not created by alerts, too?
I see you added some integration tests but having some functional UI tests would probably be good as well.

@neptunian
With the latest change, conversations created by the rule connector are private by default, meaning only the owner can see them. However, you can duplicate your own conversations and duplicate shared conversations (sharing is part of another issue [Obs AI Assistant] Sharing conversations).

To manually test this:

Create an alert in a previous Kibana version (before this change). This will generate a public conversation with no user attached. this is an artificial way to create a public/share conversation until we add the sharing functionality.
Run this Kibana version and open the AI Assistant.
You should see the previously created public conversation, but since it’s public, you won’t be able to edit or continue it. Instead, you’ll see the share panel with the option to duplicate it.
Once duplicated, you can continue interacting with it as a private conversation.

Screen.Recording.2025-02-28.at.11.54.03.mov

x-pack/platform/packages/shared/kbn-ai-assistant/src/hooks/use_conversation.ts

…_body.tsx Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com>

…-fix'

…d duplication

…_body.tsx Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com>

…nId is present

…ersations

elasticmachine · 2025-03-04T21:39:58Z

💚 Build Succeeded

Buildkite Build
Commit: 9f751df
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-208044-9f751df2e1de

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/ai-assistant`	76	78	+2
`observabilityAIAssistant`	382	385	+3
total			+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observabilityAIAssistantApp`	252.1KB	255.1KB	+3.1KB
`searchAssistant`	146.7KB	149.7KB	+3.0KB
total			+6.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observabilityAIAssistant`	38.0KB	38.0KB	+17.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/ai-assistant`	76	78	+2
`observabilityAIAssistant`	384	387	+3
total			+5

History

💚 Build #280878 succeeded f143b17
💚 Build #280186 succeeded 8b79614
💚 Build #280144 succeeded 668dcaf
💚 Build #279635 succeeded 34ad8f8
💔 Build #279486 failed 52a7b32

kibanamachine · 2025-03-04T22:15:54Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13663996871

Closes elastic#209382 ### Summary: #### Duplicate Conversation - **Readonly** → Public conversations can only be modified by the owner. - Duplicated conversations are **owned** by the user who duplicates them. - Duplicated conversations are **private** by default `public: false`. https://github.com/user-attachments/assets/9a2d1727-aa0d-4d8f-a886-727c0ce1578c UPDATE: https://github.com/user-attachments/assets/ee3282e8-5ae8-445d-9368-928dd59cfb75 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit b331fa1)

kibanamachine · 2025-03-04T22:21:31Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…213167) # Backport This will backport the following commits from `main` to `8.x`: - [[Observability AI Assistant] duplicate conversations (#208044)](#208044)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Arturo Lidueña <arturo.liduena@elastic.co>

arturoliduena added release_note:feature Makes this part of the condensed release notes Team:Obs AI Assistant Observability AI Assistant backport:version Backport to applied version labels v8.18.0 labels Jan 23, 2025

arturoliduena requested a review from a team as a code owner January 23, 2025 12:49

dgieselaar reviewed Jan 23, 2025

View reviewed changes

...gins/shared/observability_solution/observability_ai_assistant/server/service/client/index.ts Outdated Show resolved Hide resolved

dgieselaar reviewed Jan 23, 2025

View reviewed changes

...olutions/observability/plugins/observability_ai_assistant_app/server/rule_connector/index.ts Outdated Show resolved Hide resolved

arturoliduena force-pushed the obs-ai-assistant-180710-alerting-public-conversations branch from 8d79ec4 to 5aae81a Compare January 29, 2025 13:30

arturoliduena requested a review from a team as a code owner January 30, 2025 10:25

sorenlouv reviewed Jan 30, 2025

View reviewed changes

x-pack/platform/packages/shared/kbn-ai-assistant/src/hooks/use_conversation.ts Outdated Show resolved Hide resolved

sorenlouv reviewed Jan 30, 2025

View reviewed changes

arturoliduena marked this pull request as draft January 30, 2025 16:14

arturoliduena force-pushed the obs-ai-assistant-180710-alerting-public-conversations branch 2 times, most recently from d522071 to 3ab94b5 Compare February 3, 2025 09:48

arturoliduena changed the base branch from main to conversations-management-obs-ai-assistant February 4, 2025 10:06

arturoliduena marked this pull request as ready for review February 4, 2025 10:10

viduni94 reviewed Feb 4, 2025

View reviewed changes

x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_body.tsx Outdated Show resolved Hide resolved

botelastic bot added the ci:project-deploy-observability Create an Observability project label Feb 9, 2025

viduni94 reviewed Feb 10, 2025

View reviewed changes

arturoliduena added v9.0.0 and removed v8.18.0 backport:version Backport to applied version labels labels Feb 13, 2025

neptunian added the v9.1.0 label Feb 27, 2025

viduni94 reviewed Feb 27, 2025

View reviewed changes

dgieselaar reviewed Feb 28, 2025

View reviewed changes

x-pack/platform/packages/shared/kbn-ai-assistant/src/hooks/use_conversation.ts Outdated Show resolved Hide resolved

arturoliduena changed the title ~~[Observability AI Assistant] public and duplicate conversations~~ [Observability AI Assistant] duplicate conversations Mar 3, 2025

viduni94 approved these changes Mar 4, 2025

View reviewed changes

arturoliduena added the v9.0.0 label Mar 4, 2025

arturoliduena and others added 11 commits March 4, 2025 20:02

Add conversation duplication feature

282200e

update Elasticsearch refresh behavior in setConversationUser

2ab624a

Update x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat…

0274749

…_body.tsx Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com>

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

b252843

…-fix'

Add tests for private and public conversation creation, retrieval, an…

cd677d5

…d duplication

Implement i18n for shared conversation banner text in ChatBody component

73b8f81

Update x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat…

8b94496

…_body.tsx Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com>

Remove restriction on setting initialMessages when initialConversatio…

e2fcb77

…nId is present

update tests

9e7ac76

remove rule createdBy user from conversation

1a09552

reset initialMessage when duplicate the conversation

f143b17

arturoliduena force-pushed the obs-ai-assistant-180710-alerting-public-conversations branch from 8b79614 to f143b17 Compare March 4, 2025 19:02

arturoliduena removed the v9.0.0 label Mar 4, 2025

arturoliduena enabled auto-merge (squash) March 4, 2025 19:47

Merge branch 'main' into obs-ai-assistant-180710-alerting-public-conv…

9f751df

…ersations

arturoliduena merged commit b331fa1 into elastic:main Mar 4, 2025
9 checks passed

kibanamachine mentioned this pull request Mar 4, 2025

[8.x] [Observability AI Assistant] duplicate conversations (#208044) #213167

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Observability AI Assistant] duplicate conversations #208044

[Observability AI Assistant] duplicate conversations #208044

arturoliduena commented Jan 23, 2025 •

edited by kibanamachine

Loading

elasticmachine commented Jan 23, 2025

sorenlouv left a comment

arturoliduena commented Jan 30, 2025

github-actions bot commented Feb 9, 2025

viduni94 left a comment

viduni94 commented Feb 10, 2025

arturoliduena commented Feb 11, 2025

arturoliduena commented Feb 11, 2025

arturoliduena commented Feb 11, 2025

isaclfreire commented Feb 11, 2025 •

edited

Loading

viduni94 Feb 27, 2025

viduni94 Feb 27, 2025

viduni94 Feb 27, 2025 •

edited

Loading

arturoliduena Feb 28, 2025

viduni94 Feb 28, 2025

arturoliduena Mar 3, 2025

viduni94 Mar 4, 2025 •

edited

Loading

neptunian commented Feb 28, 2025

arturoliduena commented Feb 28, 2025

elasticmachine commented Mar 4, 2025 •

edited

Loading

API count

kibanamachine commented Mar 4, 2025

kibanamachine commented Mar 4, 2025

[Observability AI Assistant] duplicate conversations #208044

[Observability AI Assistant] duplicate conversations #208044

Conversation

arturoliduena commented Jan 23, 2025 • edited by kibanamachine Loading

Summary:

Duplicate Conversation

Checklist

Identify risks

elasticmachine commented Jan 23, 2025

sorenlouv left a comment

Choose a reason for hiding this comment

arturoliduena commented Jan 30, 2025

github-actions bot commented Feb 9, 2025

🤖 GitHub comments

viduni94 left a comment

Choose a reason for hiding this comment

viduni94 commented Feb 10, 2025

arturoliduena commented Feb 11, 2025

arturoliduena commented Feb 11, 2025

arturoliduena commented Feb 11, 2025

isaclfreire commented Feb 11, 2025 • edited Loading

viduni94 Feb 27, 2025

Choose a reason for hiding this comment

viduni94 Feb 27, 2025

Choose a reason for hiding this comment

viduni94 Feb 27, 2025 • edited Loading

Choose a reason for hiding this comment

arturoliduena Feb 28, 2025

Choose a reason for hiding this comment

What this check was originally preventing is:

viduni94 Feb 28, 2025

Choose a reason for hiding this comment

arturoliduena Mar 3, 2025

Choose a reason for hiding this comment

viduni94 Mar 4, 2025 • edited Loading

Choose a reason for hiding this comment

neptunian commented Feb 28, 2025

arturoliduena commented Feb 28, 2025

elasticmachine commented Mar 4, 2025 • edited Loading

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

kibanamachine commented Mar 4, 2025

kibanamachine commented Mar 4, 2025

💚 All backports created successfully

Questions ?

arturoliduena commented Jan 23, 2025 •

edited by kibanamachine

Loading

isaclfreire commented Feb 11, 2025 •

edited

Loading

viduni94 Feb 27, 2025 •

edited

Loading

viduni94 Mar 4, 2025 •

edited

Loading

elasticmachine commented Mar 4, 2025 •

edited

Loading