-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens/SCSS] Delete and migrate annotations.scss
file
#209074
Open
mariairiartef
wants to merge
19
commits into
elastic:main
Choose a base branch
from
mariairiartef:lens/208908
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−79
Open
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8cf9416
Replace scss for heatmap expression
mariairiartef 41be68a
Replace xyAnnotationNumberIcon styles
mariairiartef 01d5063
Replace xyAnnotationNumberIcon text
mariairiartef 2d9d520
Replace icon rotate 90 style
mariairiartef 9c1a52d
Restore heatmap
mariairiartef 1e7b2c3
Merge branch 'main' into lens/208908
mariairiartef 13d6222
Use eui theme instead of vars
mariairiartef 438323e
Remove tooltip scss styles
mariairiartef 64fa8da
Merge branch 'main' into lens/208908
mariairiartef b75e430
Refactor styles
mariairiartef 2935a42
Merge branch 'main' into lens/208908
mariairiartef 8a14638
Merge branch 'main' into lens/208908
mariairiartef 7c9c9df
Use euiTheme for font weight
mariairiartef 347994e
Use useEuiFontSize
mariairiartef 7d6a816
Merge branch 'main' into lens/208908
mbondyra 084465e
Merge branch 'main' into lens/208908
mbondyra 73fd31f
Merge branch 'main' into lens/208908
mariairiartef 0eb9955
Remove prefix from xy annotation tooltip style names
mariairiartef 6ad4f00
Fix import
mariairiartef File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
65 changes: 0 additions & 65 deletions
65
...latform/plugins/shared/chart_expressions/expression_xy/public/components/annotations.scss
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes sense to keep the whole prefix-y name. The styles are collocated so it's ok to simplify:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! I've only removed the
xyAnnotation
prefix here since the first style refers to the tooltip and the rest are related. Let me know if it makes sense too