-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens/SCSS] Replace expression legacy metric scss #209546
Merged
mariairiartef
merged 20 commits into
elastic:main
from
mariairiartef:lens/scss-js/expression-legacy-metric
Mar 3, 2025
Merged
Changes from 5 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a792731
Add path to emotion.d.ts in tsconfig
mariairiartef ddc7ce9
Replace legacyMtrVis css
mariairiartef 7cc76be
Delete .scss file
mariairiartef 908d795
Delete scss import file
mariairiartef 6065797
Merge branch 'main' into lens/scss-js/expression-legacy-metric
mariairiartef 06b0f7d
Remove unused euiTheme
mariairiartef a8693a5
Merge branch 'main' into lens/scss-js/expression-legacy-metric
mariairiartef 7d3e5a4
Remove style property
mariairiartef ed935b6
Delete test cases
mariairiartef 158ac41
Merge branch 'main' into lens/scss-js/expression-legacy-metric
mariairiartef a4b3b7c
Refactor styles
mariairiartef 0a29311
Refactor styles
mariairiartef 1d2061c
Merge branch 'main' into lens/scss-js/expression-legacy-metric
mariairiartef 9415dd5
Fix import issue in metric_value
mariairiartef 0d794c7
Merge branch 'main' into lens/scss-js/expression-legacy-metric
mbondyra d25589a
Update metric_vis_renderer.tsx
mbondyra fa65167
Update visualize_editor_page.ts
mbondyra f677605
Update metric_value.tsx
mbondyra ec46277
Merge branch 'main' into lens/scss-js/expression-legacy-metric
mbondyra 34cf0b9
Merge branch 'main' into lens/scss-js/expression-legacy-metric
mariairiartef File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
56 changes: 0 additions & 56 deletions
56
...m/plugins/shared/chart_expressions/expression_legacy_metric/public/components/metric.scss
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you move it together with the import above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done here: Fix import issue in metric_value