-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Onboarding] Stack - update index management breadcrumbs #209599
Open
saarikabhasi
wants to merge
53
commits into
elastic:main
Choose a base branch
from
saarikabhasi:onboarding/update-breadcrumbs-indexmanagement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+634
−221
Open
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
60b517a
update index management breadcrumb
saarikabhasi 858d4d5
add index name for stack solution nav
saarikabhasi 2ce55e3
fix serverless version breadcrumb
saarikabhasi e47735c
clean up
saarikabhasi 42e6684
update FTR
saarikabhasi 6cf92e2
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 82b297c
fix ci & clean up
saarikabhasi 2e22912
fix conflicts
saarikabhasi d61d6ba
revert unintended change
saarikabhasi 4816549
Clean ups
saarikabhasi 950958c
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine fa25cc6
remove indexName
saarikabhasi 59d38f9
Merge branch 'onboarding/update-breadcrumbs-indexmanagement' of githu…
saarikabhasi c6b44b7
Merge branch 'main' into onboarding/update-breadcrumbs-indexmanagement
saarikabhasi 2c60095
fix ci error
saarikabhasi c5798f1
Merge branch 'onboarding/update-breadcrumbs-indexmanagement' of githu…
saarikabhasi 0972fc7
address feedback and update FTR tests navigate to details page
saarikabhasi 0d998b6
move index management to separate file & fix ci
saarikabhasi 5e0e326
move index management tests from classic nav to index mgmt file
saarikabhasi ed10b5b
Merge branch 'main' into onboarding/update-breadcrumbs-indexmanagement
saarikabhasi 7c815fc
add new variable to the setBreadcrumb
saarikabhasi 791100a
Merge branch 'onboarding/update-breadcrumbs-indexmanagement' of githu…
saarikabhasi 50b2744
update i18n_check
saarikabhasi 8732bca
Merge branch 'main' into onboarding/update-breadcrumbs-indexmanagement
saarikabhasi 0f4ea73
update FTR for search_sidenav
saarikabhasi e5db3a6
Revert "update i18n_check"
saarikabhasi d02b185
Merge branch 'main' of github.com:elastic/kibana into onboarding/upda…
saarikabhasi 85a0292
initial commit use index management to search_indices
saarikabhasi 331dd2c
add deeplinks, update nav tree, update search_indices plugin
saarikabhasi 914504b
fix breadcrumbs to work for serverless & stack
saarikabhasi d10e94a
delete unused files, clean up types
saarikabhasi 4b38e69
fix breadcrumbs for serverless search
saarikabhasi c07063d
fix tests
saarikabhasi e8cfe17
fix types & eslint
saarikabhasi d8b1abb
remove unrelated changes
saarikabhasi 0a84fed
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 1d428ca
remove commented lines from solution_nav ftr
saarikabhasi b5ed052
fix ftrs for failing kibana CI
saarikabhasi 3c08dc0
[CI] Auto-commit changed files from 'node scripts/telemetry_check'
kibanamachine 27e157e
fix FTR search side nav
saarikabhasi 5c959d8
Merge branch 'onboarding/update-breadcrumbs-indexmanagement' of githu…
saarikabhasi e601ab1
Merge branch 'main' into onboarding/update-breadcrumbs-indexmanagement
saarikabhasi 8c53c2e
fix unmount index management app
saarikabhasi 37fa6a1
Merge branch 'onboarding/update-breadcrumbs-indexmanagement' of githu…
saarikabhasi bc98ff9
Merge branch 'main' into onboarding/update-breadcrumbs-indexmanagement
saarikabhasi 511b5de
clean up
saarikabhasi b799e10
FTR: add breadcrumbs check for stack
saarikabhasi 4b12666
Merge branch 'onboarding/update-breadcrumbs-indexmanagement' of githu…
saarikabhasi d6871b8
Merge branch 'main' into onboarding/update-breadcrumbs-indexmanagement
saarikabhasi 8dd3104
create subset type of ManagementAppMountParams
saarikabhasi 31b8741
Merge branch 'onboarding/update-breadcrumbs-indexmanagement' of githu…
saarikabhasi 0c79895
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 069e381
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,5 +19,6 @@ | |
"@kbn/core-application-browser", | ||
"@kbn/utility-types", | ||
"@kbn/share-plugin", | ||
"@kbn/management-plugin" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,10 @@ import { | |
IndexManagementPluginSetup, | ||
IndexManagementPluginStart, | ||
} from '@kbn/index-management-shared-types'; | ||
import { IndexManagementLocator } from '@kbn/index-management-shared-types'; | ||
import { | ||
IndexManagementLocator, | ||
IndexManagementAppMountParams, | ||
} from '@kbn/index-management-shared-types'; | ||
import { Subscription } from 'rxjs'; | ||
import { setExtensionsService } from './application/store/selectors/extension_service'; | ||
import { ExtensionsService } from './services/extensions_service'; | ||
|
@@ -144,6 +147,20 @@ export class IndexMgmtUIPlugin | |
return { | ||
apiService: new PublicApiService(coreSetup.http), | ||
extensionsService: this.extensionsService.setup(), | ||
indexManagementApp: async (params: IndexManagementAppMountParams) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lets call this |
||
const { mountManagementSection } = await import('./application/mount_management_section'); | ||
return mountManagementSection({ | ||
coreSetup, | ||
usageCollection, | ||
params, | ||
extensionsService: this.extensionsService, | ||
isFleetEnabled: Boolean(fleet), | ||
kibanaVersion: this.kibanaVersion, | ||
config: this.config, | ||
cloud, | ||
canUseSyntheticSource: this.canUseSyntheticSource, | ||
}); | ||
}, | ||
locator: this.locator, | ||
}; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! I was really confused previously about how in one situation one set of params would work and another one would need a different set of params.