[Dashboard] Remove mSearch from content management

[nickpeihl]

Summary

Removes the mSearch method from Dashboard content management.

The mSearch content management method was designed to be a temporary implementation of search that allowed searching multiple saved object types (see more [internal]). However, the mSearch implementation in the Dashboard Storage class lacks extensibility as it requires a synchronous toItemResult function. As we start migrating reference handling to the server, we will likely need transforms that return Promises (ex. savedObjectToItem), such as retrieving tag saved objects from the SavedObjectTagging client.

The Dashboard mSearch method was only used by the dashboard_picker and this PR replaces its usage with the search method.

Identify risks

There is a slight risk in serverless environments where a browser may have already loaded the dashboard_picker module but lags behind the server. In this case, the dashboard picker may fail to retrieve a list of dashboards due to it calling the now non-existent mSearch method provided by the server. In this case, the user simply needs to refresh their browser to retrieve the latest UI modules.

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[nreese]

kibana-presentation changes LGTM
code review and tested in chrome

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 964a2c9

Failed CI Steps

• FTR Configs #75

Test Failures

• [job] [logs] FTR Configs #75 / Advanced Settings security feature controls "after all" hook: afterTestSuite.trigger in "security feature controls"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
presentationUtil	84.1KB	84.1KB	-36.0B

History

• 💔 Build #275378 failed cd47284