-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security] Asset Inventory - Universal Flyout Header Boxes, Tags, Fields Components #211366
Conversation
…ersal-entity-fields
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Outdated
Show resolved
Hide resolved
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Outdated
Show resolved
Hide resolved
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Outdated
Show resolved
Hide resolved
.../security/plugins/security_solution/public/flyout/entity_details/universal_right/content.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only checked THI changes and they look good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 🚀
...y_solution/public/flyout/entity_details/universal_right/components/responsive_data_cards.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for explore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! left a couple of questions and suggestions
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Outdated
Show resolved
Hide resolved
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Show resolved
Hide resolved
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Outdated
Show resolved
Hide resolved
.../security/plugins/security_solution/public/flyout/entity_details/universal_right/content.tsx
Show resolved
Hide resolved
...plugins/security_solution/public/flyout/entity_details/universal_right/header_data_cards.tsx
Outdated
Show resolved
Hide resolved
..._solution/public/flyout/entity_details/universal_right/components/expandable_badge_group.tsx
Show resolved
Hide resolved
...s/security_solution/public/flyout/entity_details/universal_right/components/fields_table.tsx
Show resolved
Hide resolved
...s/security/plugins/security_solution/public/flyout/entity_details/universal_right/header.tsx
Outdated
Show resolved
Hide resolved
...s/security/plugins/security_solution/public/flyout/entity_details/universal_right/header.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from EA! 🚀
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
cc @JordanSh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Resolves #212862
Resolves #211487
Resolves #212863
Summary
Added header and body content for Universal Flyout
All new components are built to be reuseable and potentially to be exported from a package if we will decide we want to reuse them in other flyouts or components
Screen.Recording.2025-03-02.at.14.12.19.mov
Reuseable header data boxes
Screen.Recording.2025-02-23.at.18.34.47.mov
This solution will also scale with more/less items and will address situations of uneven amount of items
Screen.Recording.2025-02-23.at.18.36.45.mov
Expandable Badge Group
Screen.Recording.2025-02-25.at.20.16.13.mov
Screen.Recording.2025-02-26.at.18.22.58.mov
Fields Table