Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Asset Inventory - Universal Flyout Header Boxes, Tags, Fields Components #211366

Merged
merged 35 commits into from
Mar 5, 2025

Conversation

JordanSh
Copy link
Contributor

@JordanSh JordanSh commented Feb 16, 2025

Resolves #212862
Resolves #211487
Resolves #212863

Summary

Added header and body content for Universal Flyout
All new components are built to be reuseable and potentially to be exported from a package if we will decide we want to reuse them in other flyouts or components

image

Screen.Recording.2025-03-02.at.14.12.19.mov

Reuseable header data boxes

  • Removed EUI auto resposive which aligns everything in a column when the width is small
  • Used container query to add custom responsive behaviour which will work regardless of placement or window size. for example in the current implementation the boxes are used in a resizeable flyout but keep their custom responsiveness.
  • Added truncation for all text boxes with unexpected values
  • Copy button for ID box
Screen.Recording.2025-02-23.at.18.34.47.mov

This solution will also scale with more/less items and will address situations of uneven amount of items

Screen.Recording.2025-02-23.at.18.36.45.mov

Expandable Badge Group

Screen.Recording.2025-02-25.at.20.16.13.mov
  • Logic to limit amount of badges
  • Calculate and present remaining badges button with count
  • Expand on click
  • Tried to calculate amount to show based on container width.. its a tricky business since each badge can be a different width by itself. it will require to go into calculation before the render and such, seems too complicated. for now we will have to decide on an initial value of max badges by number.
  • Added inner scrolling for a large amount of badges upon expand:
Screen.Recording.2025-02-26.at.18.22.58.mov

Fields Table

  • Table for showing flatten fields from an object
  • Paginated, limited to 100 rows per page
  • Searchable for both values and fields
  • This is just an early state for this table. next PRs will revolve around improvements to match the design

image

@JordanSh JordanSh changed the title [Cloud Security] Asset Inventory - Universal Flyout Fields [Cloud Security] Asset Inventory - Universal Flyout Header Boxes Feb 23, 2025
@JordanSh JordanSh changed the title [Cloud Security] Asset Inventory - Universal Flyout Header Boxes [Cloud Security] Asset Inventory - Universal Flyout Header Boxes, Tags, Fields Components Mar 2, 2025
@JordanSh JordanSh marked this pull request as ready for review March 2, 2025 12:23
@JordanSh JordanSh requested review from a team as code owners March 2, 2025 12:23
@JordanSh JordanSh requested a review from tiansivive March 2, 2025 12:23
@JordanSh JordanSh added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Cloud Security Cloud Security team related v9.1.0 labels Mar 2, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@JordanSh JordanSh assigned JordanSh and unassigned JordanSh Mar 2, 2025
@JordanSh JordanSh requested a review from albertoblaz March 4, 2025 09:09
Copy link
Contributor

@janmonschke janmonschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only checked THI changes and they look good to me 👍

Copy link
Contributor

@albertoblaz albertoblaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚀

Copy link
Contributor

@kapral18 kapral18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for explore

Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! left a couple of questions and suggestions

Copy link
Contributor

@tiansivive tiansivive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from EA! 🚀

@JordanSh JordanSh enabled auto-merge (squash) March 5, 2025 16:36
@JordanSh JordanSh merged commit 827219b into elastic:main Mar 5, 2025
9 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 7100 7104 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.9MB 8.9MB +4.8KB

History

cc @JordanSh

Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fields table section to flyouts body Add flyout expandable tags Add flyout header cards component
8 participants