[Synthetics] Fix overview error popover !! #211431

shahzad31 · 2025-02-17T12:51:25Z

Summary

Fix overview error popover !!

Pings aren't being returned as part of overview data anymore, so had to add redux actions to fetch it separately via an existing API

Fixes #211745

…r-status

…apping'

jbudz

packages/kbn-babel-preset/styled_components_files.js LGTM

elasticmachine · 2025-02-19T14:37:05Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

justinkambic

I would say the only essential change I'd like to see is fixing the test wrap via the suggestion I included, but there are some other things we need to fix up.

We can do those here as they are related, or we can follow up with another patch.

justinkambic · 2025-02-19T16:10:06Z

...nthetics/public/apps/synthetics/components/monitors_page/overview/overview/overview_grid.tsx

@@ -18,6 +18,7 @@ import {
  EuiAutoSizer,
  EuiAutoSize,
 } from '@elastic/eui';
+import { MetricItem } from './metric_item/metric_item';


Are you opposed to using an index.ts export of this to avoid the weird path?

.../apps/synthetics/components/monitors_page/overview/overview/metric_item/metric_item_icon.tsx

justinkambic · 2025-02-19T16:25:15Z

.../apps/synthetics/components/monitors_page/overview/overview/metric_item/metric_item_icon.tsx

 }) => {
  const testNowRun = useSelector(manualTestRunSelector(monitor.configId));
  const isPopoverOpen = useSelector(selectErrorPopoverState);
+  const { latestPing } = useLatestError({


I think we should either hack this with local state to not be undefined during load, or fix it upstream so it doesn't reset it during load but only on completed.

It makes this popover really unpleasant during auto-refreshing of the data, and if the user's mouse is too far up the popover it will suddenly trigger onMouseLeave and close the popover even if the user doesn't want it to close.

done here 8e04b81 (#211431)

...apps/synthetics/components/monitors_page/overview/overview/grid_by_group/grid_group_item.tsx

…synthetics/components/monitors_page/overview/overview/metric_item/metric_item_icon.tsx Co-authored-by: Justin Kambic <jk@elastic.co>

…into fix-over-status

justinkambic

LGTM!

kibanamachine · 2025-02-21T16:39:19Z

Starting backport for target branches: 8.18, 9.0

https://github.com/elastic/kibana/actions/runs/13461196545

elasticmachine · 2025-02-21T16:39:19Z

💚 Build Succeeded

Buildkite Build
Commit: 369a92f

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`synthetics`	971	973	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`synthetics`	788.9KB	790.3KB	+1.4KB

History

💔 Build #277667 failed e68b308
💔 Build #277651 failed dba2c06

## Summary Fix overview error popover !! Pings aren't being returned as part of overview data anymore, so had to add redux actions to fetch it separately via an existing API Fixes elastic#211745 <img width="1728" alt="image" src="https://github.com/user-attachments/assets/2244948f-e42d-443d-b6e7-42e0a72b1bfa" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Justin Kambic <jk@elastic.co> (cherry picked from commit aaf73ff)

kibanamachine · 2025-02-21T16:44:52Z

💔 Some backports could not be created

Status	Branch	Result
❌	8.18	Backport failed because of merge conflicts
✅	9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 211431

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `9.0`: - [[Synthetics] Fix overview error popover !! (#211431)](#211431)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Shahzad <shahzad31comp@gmail.com>

## Summary Fix overview error popover !! Pings aren't being returned as part of overview data anymore, so had to add redux actions to fetch it separately via an existing API Fixes elastic#211745 <img width="1728" alt="image" src="https://github.com/user-attachments/assets/2244948f-e42d-443d-b6e7-42e0a72b1bfa" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Justin Kambic <jk@elastic.co>

shahzad31 · 2025-02-27T11:03:12Z

💚 All backports created successfully

Status	Branch	Result
✅	8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Fix overview error popover !! Pings aren't being returned as part of overview data anymore, so had to add redux actions to fetch it separately via an existing API Fixes elastic#211745 <img width="1728" alt="image" src="https://github.com/user-attachments/assets/2244948f-e42d-443d-b6e7-42e0a72b1bfa" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Justin Kambic <jk@elastic.co> (cherry picked from commit aaf73ff)

# Backport This will backport the following commits from `main` to `8.18`: - [[Synthetics] Fix overview error popover !! (#211431)](#211431)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2025-03-06T08:43:00Z

Starting backport for target branches: 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13694598577

kibanamachine · 2025-03-06T08:48:35Z

💔 All backports failed

Status	Branch	Result
❌	8.18	Backport failed because of merge conflicts
❌	8.x	Backport failed because of merge conflicts
❌	9.0	Cherrypick failed because the selected commit (`aaf73ff`) is empty. It looks like the commit was already backported in #212123

Manual backport

To create the backport manually run:

node scripts/backport --pr 211431

Questions ?

Please refer to the Backport tool documentation

## Summary Fix overview error popover !! Pings aren't being returned as part of overview data anymore, so had to add redux actions to fetch it separately via an existing API Fixes elastic#211745 <img width="1728" alt="image" src="https://github.com/user-attachments/assets/2244948f-e42d-443d-b6e7-42e0a72b1bfa" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Justin Kambic <jk@elastic.co> (cherry picked from commit aaf73ff) # Conflicts: # x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/monitors_page/overview/overview/metric_item/metric_item.tsx

shahzad31 · 2025-03-06T08:59:19Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Fix overview error popover !! (#211431)](#211431)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

shahzad31 and others added 6 commits February 17, 2025 13:50

fix overview error popover

cd31360

wip

7a48b15

Merge branch 'main' of https://github.com/elastic/kibana into fix-ove…

652689b

…r-status

update handler

dba2c06

[CI] Auto-commit changed files from 'node scripts/styled_components_m…

d6f4881

…apping'

fix types

e68b308

shahzad31 marked this pull request as ready for review February 19, 2025 13:09

shahzad31 requested review from a team as code owners February 19, 2025 13:09

shahzad31 added backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes labels Feb 19, 2025

jbudz approved these changes Feb 19, 2025

View reviewed changes

botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Feb 19, 2025

justinkambic requested changes Feb 19, 2025

View reviewed changes

shahzad31 and others added 4 commits February 20, 2025 12:50

update

c4b4212

Update x-pack/solutions/observability/plugins/synthetics/public/apps/…

517fe54

…synthetics/components/monitors_page/overview/overview/metric_item/metric_item_icon.tsx Co-authored-by: Justin Kambic <jk@elastic.co>

handle state

8e04b81

Merge branch 'fix-over-status' of https://github.com/shahzad31/kibana …

b51d8c8

…into fix-over-status

shahzad31 requested a review from justinkambic February 21, 2025 09:52

Merge branch 'main' into fix-over-status

369a92f

justinkambic approved these changes Feb 21, 2025

View reviewed changes

shahzad31 added backport:version Backport to applied version labels v9.0.0 v8.18.0 v9.1.0 and removed backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Feb 21, 2025

shahzad31 enabled auto-merge (squash) February 21, 2025 15:37

shahzad31 merged commit aaf73ff into elastic:main Feb 21, 2025
18 checks passed

kibanamachine mentioned this pull request Feb 21, 2025

[9.0] [Synthetics] Fix overview error popover !! (#211431) #212123

Merged

shahzad31 deleted the fix-over-status branch February 21, 2025 17:08

shahzad31 mentioned this pull request Feb 27, 2025

[8.18] [Synthetics] Fix overview error popover !! (#211431) #212620

Merged

shahzad31 added v8.19.0 backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Mar 6, 2025

shahzad31 mentioned this pull request Mar 6, 2025

[8.x] [Synthetics] Fix overview error popover !! (#211431) #213328

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Synthetics] Fix overview error popover !! #211431

[Synthetics] Fix overview error popover !! #211431

shahzad31 commented Feb 17, 2025 •

edited by kibanamachine

Loading

jbudz left a comment

elasticmachine commented Feb 19, 2025

justinkambic left a comment

justinkambic Feb 19, 2025

justinkambic Feb 19, 2025

shahzad31 Feb 20, 2025

justinkambic left a comment

kibanamachine commented Feb 21, 2025

elasticmachine commented Feb 21, 2025

kibanamachine commented Feb 21, 2025

shahzad31 commented Feb 27, 2025

kibanamachine commented Mar 6, 2025

kibanamachine commented Mar 6, 2025

shahzad31 commented Mar 6, 2025

[Synthetics] Fix overview error popover !! #211431

[Synthetics] Fix overview error popover !! #211431

Conversation

shahzad31 commented Feb 17, 2025 • edited by kibanamachine Loading

Summary

jbudz left a comment

Choose a reason for hiding this comment

elasticmachine commented Feb 19, 2025

justinkambic left a comment

Choose a reason for hiding this comment

justinkambic Feb 19, 2025

Choose a reason for hiding this comment

justinkambic Feb 19, 2025

Choose a reason for hiding this comment

shahzad31 Feb 20, 2025

Choose a reason for hiding this comment

justinkambic left a comment

Choose a reason for hiding this comment

kibanamachine commented Feb 21, 2025

elasticmachine commented Feb 21, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

kibanamachine commented Feb 21, 2025

💔 Some backports could not be created

Manual backport

Questions ?

shahzad31 commented Feb 27, 2025

💚 All backports created successfully

Questions ?

kibanamachine commented Mar 6, 2025

kibanamachine commented Mar 6, 2025

💔 All backports failed

Manual backport

Questions ?

shahzad31 commented Mar 6, 2025

💚 All backports created successfully

Questions ?

shahzad31 commented Feb 17, 2025 •

edited by kibanamachine

Loading