Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] chore(NA): remove ununsed EUI imports into ui-shared-deps #211656

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

mistic
Copy link
Member

@mistic mistic commented Feb 18, 2025

This PR removes from the UI shared deps EUI import exposures that doesn't seem like to be used across the codebase.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v8.18.0 v8.19.0 labels Feb 18, 2025
@mistic mistic changed the title chore(NA): remove ununsed EUI imports into ui-shared-deps [8.x] chore(NA): remove ununsed EUI imports into ui-shared-deps Feb 18, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #68 / discover/group4 adhoc data views should support query and filtering

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ui-shared-deps-src 54 53 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.6MB 3.6MB -52.0B
Unknown metric groups

API count

id before after diff
@kbn/ui-shared-deps-src 63 62 -1

@mistic mistic marked this pull request as ready for review February 19, 2025 00:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic merged commit 356da9e into elastic:8.x Feb 19, 2025
8 checks passed
@mistic mistic added backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Feb 19, 2025
mistic added a commit to mistic/kibana that referenced this pull request Feb 19, 2025
…tic#211656)

This PR removes from the UI shared deps EUI import exposures that
doesn't seem like to be used across the codebase.

(cherry picked from commit 356da9e)
@mistic
Copy link
Member Author

mistic commented Feb 19, 2025

💚 All backports created successfully

Status Branch Result
8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

mistic added a commit that referenced this pull request Feb 19, 2025
#211656) (#211673)

# Backport

This will backport the following commits from `8.x` to `8.18`:
- [[8.x] chore(NA): remove ununsed EUI imports into ui-shared-deps
(#211656)](#211656)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Tiago
Costa","email":"tiago.costa@elastic.co"},"sourceCommit":{"committedDate":"2025-02-19T03:43:29Z","message":"[8.x]
chore(NA): remove ununsed EUI imports into ui-shared-deps
(#211656)\n\nThis PR removes from the UI shared deps EUI import
exposures that\ndoesn't seem like to be used across the
codebase.","sha":"356da9e152ea4e407c656b92fd8d970f8b3a936c","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:version","v8.18.0","v8.19.0"],"title":"[8.x]
chore(NA): remove ununsed EUI imports into
ui-shared-deps","number":211656,"url":"https://github.com/elastic/kibana/pull/211656","mergeCommit":{"message":"[8.x]
chore(NA): remove ununsed EUI imports into ui-shared-deps
(#211656)\n\nThis PR removes from the UI shared deps EUI import
exposures that\ndoesn't seem like to be used across the
codebase.","sha":"356da9e152ea4e407c656b92fd8d970f8b3a936c"}},"sourceBranch":"8.x","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.18.0 v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants