From e8b0c8873202dac012e16c95ccce9ab7291343c3 Mon Sep 17 00:00:00 2001 From: Hannah Mudge Date: Tue, 18 Feb 2025 15:04:48 -0700 Subject: [PATCH 1/2] Try FTR --- .../apps/dashboard_elements/links/links_navigation.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/test/functional/apps/dashboard_elements/links/links_navigation.ts b/test/functional/apps/dashboard_elements/links/links_navigation.ts index cd5457a0b9838..15e5517e6373f 100644 --- a/test/functional/apps/dashboard_elements/links/links_navigation.ts +++ b/test/functional/apps/dashboard_elements/links/links_navigation.ts @@ -29,7 +29,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const FROM_TIME = 'Oct 22, 2018 @ 00:00:00.000'; const TO_TIME = 'Dec 3, 2018 @ 00:00:00.000'; - describe('links panel navigation', () => { + describe.only('links panel navigation', () => { before(async () => { await kibanaServer.savedObjects.cleanStandardList(); await security.testUser.setRoles([ @@ -214,9 +214,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(isDisabled).to.be('true'); }); - // TODO We should not be using an external website for our tests. This will be flaky - // if external network connectivity issues exist. - it.skip('should create an external link when openInNewTab is enabled', async () => { + it('should create an external link when openInNewTab is enabled', async () => { await testSubjects.clickWhenNotDisabled('externalLink--link999'); // Should have opened another tab @@ -227,7 +225,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(currentUrl).to.be('https://example.com/1'); }); - it.skip('should open in same tab when openInNewTab is disabled', async () => { + it('should open in same tab when openInNewTab is disabled', async () => { await testSubjects.clickWhenNotDisabled('externalLink--link888'); // Should have opened in the same tab From dd8730819c5efc5566fdaeba0ec43772d7948ab9 Mon Sep 17 00:00:00 2001 From: Hannah Mudge Date: Tue, 18 Feb 2025 15:13:15 -0700 Subject: [PATCH 2/2] Remove `.only` --- .../apps/dashboard_elements/links/links_navigation.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/functional/apps/dashboard_elements/links/links_navigation.ts b/test/functional/apps/dashboard_elements/links/links_navigation.ts index 15e5517e6373f..d872793e4fa1c 100644 --- a/test/functional/apps/dashboard_elements/links/links_navigation.ts +++ b/test/functional/apps/dashboard_elements/links/links_navigation.ts @@ -29,7 +29,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const FROM_TIME = 'Oct 22, 2018 @ 00:00:00.000'; const TO_TIME = 'Dec 3, 2018 @ 00:00:00.000'; - describe.only('links panel navigation', () => { + describe('links panel navigation', () => { before(async () => { await kibanaServer.savedObjects.cleanStandardList(); await security.testUser.setRoles([