[Security Solution] Fix flyout history flickering #211662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
release_note:skip
christineweng
force-pushed
the
fix-history-flickering
branch
from
cab5f39 to
1e42140
Compare
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
approved these changes
Feb 19, 2025
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 20, 2025
## Summary This PR fixed a flickering issue in flyout history **Before** `Event details` is shown and then replaced by actual alert title https://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b **After** Show a loading skeleton text while fetching rule name  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit e2730f7)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 20, 2025
## Summary This PR fixed a flickering issue in flyout history **Before** `Event details` is shown and then replaced by actual alert title https://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b **After** Show a loading skeleton text while fetching rule name  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit e2730f7)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 20, 2025
## Summary This PR fixed a flickering issue in flyout history **Before** `Event details` is shown and then replaced by actual alert title https://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b **After** Show a loading skeleton text while fetching rule name  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit e2730f7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 20, 2025
…11937) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Fix flyout history flickering (#211662)](#211662) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-20T17:05:54Z","message":"[Security Solution] Fix flyout history flickering (#211662)\n\n## Summary\n\nThis PR fixed a flickering issue in flyout history\n\n**Before**\n`Event details` is shown and then replaced by actual alert title\n\n\nhttps://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b\n\n**After**\nShow a loading skeleton text while fetching rule name\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e2730f70db3bf04efac6a6f227962f88fcc63fce","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix flyout history flickering","number":211662,"url":"https://github.com/elastic/kibana/pull/211662","mergeCommit":{"message":"[Security Solution] Fix flyout history flickering (#211662)\n\n## Summary\n\nThis PR fixed a flickering issue in flyout history\n\n**Before**\n`Event details` is shown and then replaced by actual alert title\n\n\nhttps://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b\n\n**After**\nShow a loading skeleton text while fetching rule name\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e2730f70db3bf04efac6a6f227962f88fcc63fce"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211662","number":211662,"mergeCommit":{"message":"[Security Solution] Fix flyout history flickering (#211662)\n\n## Summary\n\nThis PR fixed a flickering issue in flyout history\n\n**Before**\n`Event details` is shown and then replaced by actual alert title\n\n\nhttps://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b\n\n**After**\nShow a loading skeleton text while fetching rule name\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e2730f70db3bf04efac6a6f227962f88fcc63fce"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 20, 2025
…11936) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Fix flyout history flickering (#211662)](#211662) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-20T17:05:54Z","message":"[Security Solution] Fix flyout history flickering (#211662)\n\n## Summary\n\nThis PR fixed a flickering issue in flyout history\n\n**Before**\n`Event details` is shown and then replaced by actual alert title\n\n\nhttps://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b\n\n**After**\nShow a loading skeleton text while fetching rule name\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e2730f70db3bf04efac6a6f227962f88fcc63fce","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix flyout history flickering","number":211662,"url":"https://github.com/elastic/kibana/pull/211662","mergeCommit":{"message":"[Security Solution] Fix flyout history flickering (#211662)\n\n## Summary\n\nThis PR fixed a flickering issue in flyout history\n\n**Before**\n`Event details` is shown and then replaced by actual alert title\n\n\nhttps://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b\n\n**After**\nShow a loading skeleton text while fetching rule name\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e2730f70db3bf04efac6a6f227962f88fcc63fce"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211662","number":211662,"mergeCommit":{"message":"[Security Solution] Fix flyout history flickering (#211662)\n\n## Summary\n\nThis PR fixed a flickering issue in flyout history\n\n**Before**\n`Event details` is shown and then replaced by actual alert title\n\n\nhttps://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b\n\n**After**\nShow a loading skeleton text while fetching rule name\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e2730f70db3bf04efac6a6f227962f88fcc63fce"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 20, 2025
…211935) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Fix flyout history flickering (#211662)](#211662) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-20T17:05:54Z","message":"[Security Solution] Fix flyout history flickering (#211662)\n\n## Summary\n\nThis PR fixed a flickering issue in flyout history\n\n**Before**\n`Event details` is shown and then replaced by actual alert title\n\n\nhttps://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b\n\n**After**\nShow a loading skeleton text while fetching rule name\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e2730f70db3bf04efac6a6f227962f88fcc63fce","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix flyout history flickering","number":211662,"url":"https://github.com/elastic/kibana/pull/211662","mergeCommit":{"message":"[Security Solution] Fix flyout history flickering (#211662)\n\n## Summary\n\nThis PR fixed a flickering issue in flyout history\n\n**Before**\n`Event details` is shown and then replaced by actual alert title\n\n\nhttps://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b\n\n**After**\nShow a loading skeleton text while fetching rule name\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e2730f70db3bf04efac6a6f227962f88fcc63fce"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211662","number":211662,"mergeCommit":{"message":"[Security Solution] Fix flyout history flickering (#211662)\n\n## Summary\n\nThis PR fixed a flickering issue in flyout history\n\n**Before**\n`Event details` is shown and then replaced by actual alert title\n\n\nhttps://github.com/user-attachments/assets/edb1e6eb-c290-4cdc-a5f9-3f270a26a58b\n\n**After**\nShow a loading skeleton text while fetching rule name\n\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"e2730f70db3bf04efac6a6f227962f88fcc63fce"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixed a flickering issue in flyout history
Before
Event detailsis shown and then replaced by actual alert titleScreen.Recording.2025-02-18.at.3.28.38.PM.mov
After
Show a loading skeleton text while fetching rule name
Checklist
release_note:*label is applied per the guidelines