-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WiP] Share modal re-architecture #211665
Draft
eokoneyo
wants to merge
16
commits into
elastic:main
Choose a base branch
from
eokoneyo:feat/share-rearchitecture
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,109
−538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
1db5b72
to
d4162c9
Compare
333f34a
to
cc0566a
Compare
cc0566a
to
75afcd9
Compare
75afcd9
to
715606a
Compare
/ci |
/ci |
💔 Build Failed
Failed CI StepsHistory
cc @eokoneyo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to rework the internals for how the share plugin works, and brings with it a slight modification to how configs are registered to the share plugin, with this PR the share plugin now defines the following share types i.e.
links
,embeds
andintegrations
. As such native implementations (i.e. copy link and embed) provided by sharedUX remain internal to the share plugin.One might then ask what happens to the existing export functionality provided by the reporting plugin, in this PR the export functionality is now modelled as an integration that's simply grouped as an export, see the type definition for the Export type. Accompanying this change, a new method has been introduced
registerShareIntegration
that's similar to the previous methodregister
, with a slight difference, in that now registered integrations can be scoped to a specific object type like so.Also there's been a clean up with the config options that typically would be passed to the
toggleShareMenu
method, properties that are specific to a specific share type are now expected to be provided within the config property for that specific share type.These aforementioned configs would then be automatically be made available under the property
shareMenuItems
by providing the object type value to theuseShareTabsContext
, like so;because the share type of link is provided,
useShareTabsContext
will only provide data and config that applies specifically to thelink
share type.